2024-02-04 20:36:08

by Ricardo B. Marliere

[permalink] [raw]
Subject: [PATCH] siox: make siox_bus_type const

Now that the driver core can properly handle constant struct bus_type,
move the siox_bus_type variable to be a constant structure as well,
placing it into read-only memory which can not be modified at runtime.

Cc: Greg Kroah-Hartman <[email protected]>
Suggested-by: Greg Kroah-Hartman <[email protected]>
Signed-off-by: Ricardo B. Marliere <[email protected]>
---
drivers/siox/siox-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/siox/siox-core.c b/drivers/siox/siox-core.c
index 561408583b2b..a1eda7bd76ed 100644
--- a/drivers/siox/siox-core.c
+++ b/drivers/siox/siox-core.c
@@ -543,7 +543,7 @@ static void siox_shutdown(struct device *dev)
sdriver->shutdown(sdevice);
}

-static struct bus_type siox_bus_type = {
+static const struct bus_type siox_bus_type = {
.name = "siox",
.match = siox_match,
.probe = siox_probe,

---
base-commit: 41b9fb381a486360b2daaec0c7480f8e3ff72bc7
change-id: 20240204-bus_cleanup-siox-ccf8775bf069

Best regards,
--
Ricardo B. Marliere <[email protected]>



2024-02-04 21:30:26

by Uwe Kleine-König

[permalink] [raw]
Subject: Re: [PATCH] siox: make siox_bus_type const

Hello Ricardo,

On Sun, Feb 04, 2024 at 05:36:03PM -0300, Ricardo B. Marliere wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the siox_bus_type variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
>
> Cc: Greg Kroah-Hartman <[email protected]>
> Suggested-by: Greg Kroah-Hartman <[email protected]>
> Signed-off-by: Ricardo B. Marliere <[email protected]>
> ---
> drivers/siox/siox-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/siox/siox-core.c b/drivers/siox/siox-core.c
> index 561408583b2b..a1eda7bd76ed 100644
> --- a/drivers/siox/siox-core.c
> +++ b/drivers/siox/siox-core.c
> @@ -543,7 +543,7 @@ static void siox_shutdown(struct device *dev)
> sdriver->shutdown(sdevice);
> }
>
> -static struct bus_type siox_bus_type = {
> +static const struct bus_type siox_bus_type = {
> .name = "siox",
> .match = siox_match,
> .probe = siox_probe,

while I like this change, I wonder about the "Now" in the commit log.
Doing the homework, this is about commit d492cc2573a0 ("driver core:
device.h: make struct bus_type a const *") which is in 6.4-rc1. Would
you please care to mention that commit as the one that makes this siox
change possible?

Thanks
Uwe

--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | https://www.pengutronix.de/ |


Attachments:
(No filename) (1.49 kB)
signature.asc (499.00 B)
Download all attachments

2024-02-04 22:27:40

by Ricardo B. Marliere

[permalink] [raw]
Subject: Re: [PATCH] siox: make siox_bus_type const

On 4 Feb 22:29, Uwe Kleine-König wrote:
> Hello Ricardo,
>
> On Sun, Feb 04, 2024 at 05:36:03PM -0300, Ricardo B. Marliere wrote:
> > Now that the driver core can properly handle constant struct bus_type,
> > move the siox_bus_type variable to be a constant structure as well,
> > placing it into read-only memory which can not be modified at runtime.
> >
> > Cc: Greg Kroah-Hartman <[email protected]>
> > Suggested-by: Greg Kroah-Hartman <[email protected]>
> > Signed-off-by: Ricardo B. Marliere <[email protected]>
> > ---
> > drivers/siox/siox-core.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/siox/siox-core.c b/drivers/siox/siox-core.c
> > index 561408583b2b..a1eda7bd76ed 100644
> > --- a/drivers/siox/siox-core.c
> > +++ b/drivers/siox/siox-core.c
> > @@ -543,7 +543,7 @@ static void siox_shutdown(struct device *dev)
> > sdriver->shutdown(sdevice);
> > }
> >
> > -static struct bus_type siox_bus_type = {
> > +static const struct bus_type siox_bus_type = {
> > .name = "siox",
> > .match = siox_match,
> > .probe = siox_probe,
>
> while I like this change, I wonder about the "Now" in the commit log.
> Doing the homework, this is about commit d492cc2573a0 ("driver core:
> device.h: make struct bus_type a const *") which is in 6.4-rc1. Would
> you please care to mention that commit as the one that makes this siox
> change possible?

Hi Uwe!

Sounds reasonable, I just sent a v2. The original log is being used
across the tree, took from a template first used by Greg.

Thanks for reviewing,
- Ricardo.


>
> Thanks
> Uwe
>
> --
> Pengutronix e.K. | Uwe Kleine-K?nig |
> Industrial Linux Solutions | https://www.pengutronix.de/ |