2022-04-22 21:55:05

by Takashi Iwai

[permalink] [raw]
Subject: Re: [PATCH -next V2] sound/oss/dmasound: fix 'dmasound_setup' defined but not used

On Fri, 22 Apr 2022 04:53:12 +0200,
Miles Chen wrote:
>
> Hi Taksshi,
>
> >> We observed: 'dmasound_setup' defined but not used error with
> >> COMPILER=gcc ARCH=m68k DEFCONFIG=allmodconfig build.
> >>
> >> Fix it by adding __maybe_unused to dmasound_setup.
> >>
> >> Error(s):
> >> sound/oss/dmasound/dmasound_core.c:1431:12: error: 'dmasound_setup' defined but not used [-Werror=unused-function]
> >>
> >> Fixes: 9dd7c46346ca ("sound/oss/dmasound: fix build when drivers are mixed =y/=m")
> >> Signed-off-by: Miles Chen <[email protected]>
> >> Cc: Takashi Iwai <[email protected]>
> >
> >Thanks, applied.
>
> This patch is needed in 5.18-rc3 [1] too, should I submit another patch or
> you can pick it to the mainstream?

It's included in the branch for the next PR to 5.18.


thanks,

Takashi