2009-07-15 06:30:55

by Jaswinder Singh Rajput

Subject: sound/soc/codecs/wm9081.c compiler warning

I am getting this compiler warning in linus tree:

CC [M] sound/soc/codecs/wm9081.o
sound/soc/codecs/wm9081.c: In function ‘configure_clock’:
sound/soc/codecs/wm9081.c:674: warning: ‘new_sysclk’ may be used uninitialized in this function

This fixes the warning in my case, hope this will be helpful :

diff --git a/sound/soc/codecs/wm9081.c b/sound/soc/codecs/wm9081.c
index 86fc57e..77a7997 100644
--- a/sound/soc/codecs/wm9081.c
+++ b/sound/soc/codecs/wm9081.c
@@ -696,6 +696,7 @@ static int configure_clock(struct snd_soc_codec *codec)
* not the case, though care must be taken with free
* running mode.
*/
+ new_sysclk = 12288000;
if (wm9081->master && wm9081->bclk) {
/* Make sure we can generate CLK_SYS and BCLK
* and that we've got 3MHz for optimal
@@ -714,8 +715,6 @@ static int configure_clock(struct snd_soc_codec *codec)
if (new_sysclk > 3000000)
break;
}
- } else {
- new_sysclk = 12288000;
}

ret = wm9081_set_fll(codec, WM9081_SYSCLK_FLL_MCLK,

--
JSR

2009-07-15 09:11:21

by Takashi Iwai

Subject: Re: sound/soc/codecs/wm9081.c compiler warning

At Wed, 15 Jul 2009 12:00:34 +0530,
Jaswinder Singh Rajput wrote:
>
> I am getting this compiler warning in linus tree:
>
> CC [M] sound/soc/codecs/wm9081.o
> sound/soc/codecs/wm9081.c: In function ‘configure_clock’:
> sound/soc/codecs/wm9081.c:674: warning: ‘new_sysclk’ may be used uninitialized in this function
>
> This fixes the warning in my case, hope this will be helpful :

I think your fix is OK, but I let it to Mark :)


thanks,

Takashi

>
> diff --git a/sound/soc/codecs/wm9081.c b/sound/soc/codecs/wm9081.c
> index 86fc57e..77a7997 100644
> --- a/sound/soc/codecs/wm9081.c
> +++ b/sound/soc/codecs/wm9081.c
> @@ -696,6 +696,7 @@ static int configure_clock(struct snd_soc_codec *codec)
> * not the case, though care must be taken with free
> * running mode.
> */
> + new_sysclk = 12288000;
> if (wm9081->master && wm9081->bclk) {
> /* Make sure we can generate CLK_SYS and BCLK
> * and that we've got 3MHz for optimal
> @@ -714,8 +715,6 @@ static int configure_clock(struct snd_soc_codec *codec)
> if (new_sysclk > 3000000)
> break;
> }
> - } else {
> - new_sysclk = 12288000;
> }
>
> ret = wm9081_set_fll(codec, WM9081_SYSCLK_FLL_MCLK,
>
> --
> JSR
>

2009-07-15 09:14:12

by Mark Brown

Subject: Re: sound/soc/codecs/wm9081.c compiler warning

On Wed, Jul 15, 2009 at 11:11:19AM +0200, Takashi Iwai wrote:
> At Wed, 15 Jul 2009 12:00:34 +0530,
> Jaswinder Singh Rajput wrote:

> > I am getting this compiler warning in linus tree:

> > CC [M] sound/soc/codecs/wm9081.o
> > sound/soc/codecs/wm9081.c: In function ‘configure_clock’:
> > sound/soc/codecs/wm9081.c:674: warning: ‘new_sysclk’ may be used uninitialized in this function

> > This fixes the warning in my case, hope this will be helpful :

> I think your fix is OK, but I let it to Mark :)

I'm just looking at this at the minute. I'm trying to decide if it
should take that approach or error out if it can't find a configuration.

Again, I'm not seeing the warning itself - compiler versions would be
useful in warning reports (particularly for control flow analysis stuff
like this).

2009-07-15 10:32:07

by Mark Brown

Subject: Re: sound/soc/codecs/wm9081.c compiler warning

On Wed, Jul 15, 2009 at 12:00:34PM +0530, Jaswinder Singh Rajput wrote:

> CC [M] sound/soc/codecs/wm9081.o
> sound/soc/codecs/wm9081.c: In function ‘configure_clock’:
> sound/soc/codecs/wm9081.c:674: warning: ‘new_sysclk’ may be used uninitialized in this function
>
> This fixes the warning in my case, hope this will be helpful :

I've pushed an alternative patch which hopefully fixes this (none of my
compilers appear to generate the warning so I can't check that the
warning is gone).