2021-02-22 19:43:48

by Rajesh Kumbhakar

Subject: [PATCH] sound: core: fixed coding style errors

fixing ERROR: "foo * bar" should be "foo *bar"
fixing WARNING: Missing a blank line after declarations

Signed-off-by: Rajesh Kumbhakar <[email protected]>
---
sound/core/hwdep_compat.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/sound/core/hwdep_compat.c b/sound/core/hwdep_compat.c
index a0b76706c..d8624a14a 100644
--- a/sound/core/hwdep_compat.c
+++ b/sound/core/hwdep_compat.c
@@ -36,11 +36,13 @@ enum {
SNDRV_HWDEP_IOCTL_DSP_LOAD32 = _IOW('H', 0x03, struct snd_hwdep_dsp_image32)
};

-static long snd_hwdep_ioctl_compat(struct file * file, unsigned int cmd,
+static long snd_hwdep_ioctl_compat(struct file *file, unsigned int cmd,
unsigned long arg)
{
struct snd_hwdep *hw = file->private_data;
+
void __user *argp = compat_ptr(arg);
+
switch (cmd) {
case SNDRV_HWDEP_IOCTL_PVERSION:
case SNDRV_HWDEP_IOCTL_INFO:
--
2.25.1

2021-02-23 07:43:25

by Rajesh Kumbhakar

Subject: Re: [PATCH] sound: core: fixed coding style errors

Alright, I will resubmit the patch.

2021-02-23 07:44:59

by Takashi Iwai

Subject: Re: [PATCH] sound: core: fixed coding style errors

On Mon, 22 Feb 2021 20:41:56 +0100,
Rajesh Kumbhakar wrote:
>
> fixing ERROR: "foo * bar" should be "foo *bar"
> fixing WARNING: Missing a blank line after declarations
>
> Signed-off-by: Rajesh Kumbhakar <[email protected]>
> ---
> sound/core/hwdep_compat.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/sound/core/hwdep_compat.c b/sound/core/hwdep_compat.c
> index a0b76706c..d8624a14a 100644
> --- a/sound/core/hwdep_compat.c
> +++ b/sound/core/hwdep_compat.c
> @@ -36,11 +36,13 @@ enum {
> SNDRV_HWDEP_IOCTL_DSP_LOAD32 = _IOW('H', 0x03, struct snd_hwdep_dsp_image32)
> };
>
> -static long snd_hwdep_ioctl_compat(struct file * file, unsigned int cmd,
> +static long snd_hwdep_ioctl_compat(struct file *file, unsigned int cmd,
> unsigned long arg)
> {
> struct snd_hwdep *hw = file->private_data;
> +
> void __user *argp = compat_ptr(arg);

You shouldn't put a blank line here.


thanks,

Takashi