On 5/4/2020 2:05 PM, Sameer Pujar wrote:
>
>
> On 5/4/2020 1:59 PM, Takashi Iwai wrote:
>> External email: Use caution opening links or attachments
>>
>>
>> On Mon, 04 May 2020 10:16:13 +0200,
>> Sameer Pujar wrote:
>>> This series proposes SW workarounds for Tegra194 HDA HW bugs.
>>> Following are the two issues seen:
>>> 1. GCAP register does not reflect true capability.
>>> The actual number of SDO lines is "4", where as it reflects "2".
>>> 2. With 4 SDO line configuration playback fails for,
>>> 44.1K/48K, 2-channel, 16-bps audio stream.
>>>
>>> After fixing [1], issue [2] is uncovered.
>>> As per recommendation by Tegra HW team the workarounds are pushed.
>>>
>>> Testing done
>>> ============
>>> * Verify GCAP register after registering HDA sound card
>>> * Verify audio playback for 44.1K/48K, 2-channel, 16-bps.
>>>
>>> Sameer Pujar (3):
>>> ALSA: hda/tegra: correct number of SDO lines for Tegra194
>>> ALSA: hda: add member to store ratio for stripe control
>>> ALSA: hda/tegra: workaround playback failure on Tegra194
>> Through a quick glance, all changes look good.
>>
>> Is the device already in market, i.e. it had hit users? If yes, I'm
>> going to merge for 5.7, otherwise for 5.8.
>
> Yes the device is in the market. But has not been reported by end users.
> During internal resting this has been discovered. I am fine with
> merging this to 5.8.
To add, end users currently won't see this problem because things work
fine with 2-SDO lines. The issue is seen when Tegra194 is allowed to
utilize its actual capability of 4-SDO lines.
>
> Thanks,
> Sameer.
>>
>>
>> thanks,
>>
>> Takashi
>
On Mon, 04 May 2020 10:48:46 +0200,
Sameer Pujar wrote:
>
>
>
> On 5/4/2020 2:05 PM, Sameer Pujar wrote:
> >
> >
> > On 5/4/2020 1:59 PM, Takashi Iwai wrote:
> >> External email: Use caution opening links or attachments
> >>
> >>
> >> On Mon, 04 May 2020 10:16:13 +0200,
> >> Sameer Pujar wrote:
> >>> This series proposes SW workarounds for Tegra194 HDA HW bugs.
> >>> Following are the two issues seen:
> >>> 1. GCAP register does not reflect true capability.
> >>> The actual number of SDO lines is "4", where as it reflects "2".
> >>> 2. With 4 SDO line configuration playback fails for,
> >>> 44.1K/48K, 2-channel, 16-bps audio stream.
> >>>
> >>> After fixing [1], issue [2] is uncovered.
> >>> As per recommendation by Tegra HW team the workarounds are pushed.
> >>>
> >>> Testing done
> >>> ============
> >>> * Verify GCAP register after registering HDA sound card
> >>> * Verify audio playback for 44.1K/48K, 2-channel, 16-bps.
> >>>
> >>> Sameer Pujar (3):
> >>> ALSA: hda/tegra: correct number of SDO lines for Tegra194
> >>> ALSA: hda: add member to store ratio for stripe control
> >>> ALSA: hda/tegra: workaround playback failure on Tegra194
> >> Through a quick glance, all changes look good.
> >>
> >> Is the device already in market, i.e. it had hit users? If yes, I'm
> >> going to merge for 5.7, otherwise for 5.8.
> >
> > Yes the device is in the market. But has not been reported by end users.
> > During internal resting this has been discovered. I am fine with
> > merging this to 5.8.
>
> To add, end users currently won't see this problem because things work
> fine with 2-SDO lines. The issue is seen when Tegra194 is allowed to
> utilize its actual capability of 4-SDO lines.
Thanks for the information. Then I queued all three patches now to
for-next branch destined for 5.8.
Takashi