2022-05-01 15:11:00

by Randy Dunlap

Subject: [PATCH] ALSA: hda - fix unused Realtek function when PM is not enabled

When CONFIG_PM is not enabled, alc_shutup() is not needed,
so move it inside the #ifdef CONFIG_PM guard.
Also drop some contiguous #endif / #ifdef CONFIG_PM for simplicity.

Fixes this build warning:
sound/pci/hda/patch_realtek.c:886:20: warning: unused function 'alc_shutup'

Fixes: 08c189f2c552 ("ALSA: hda - Use generic parser codes for Realtek driver")
Signed-off-by: Randy Dunlap <[email protected]>
Reported-by: kernel test robot <[email protected]>
Cc: Takashi Iwai <[email protected]>
Cc: Jaroslav Kysela <[email protected]>
Cc: [email protected]
---
sound/pci/hda/patch_realtek.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)

--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -937,6 +937,9 @@ static int alc_init(struct hda_codec *co
return 0;
}

+#define alc_free snd_hda_gen_free
+
+#ifdef CONFIG_PM
static inline void alc_shutup(struct hda_codec *codec)
{
struct alc_spec *spec = codec->spec;
@@ -950,9 +953,6 @@ static inline void alc_shutup(struct hda
alc_shutup_pins(codec);
}

-#define alc_free snd_hda_gen_free
-
-#ifdef CONFIG_PM
static void alc_power_eapd(struct hda_codec *codec)
{
alc_auto_setup_eapd(codec, false);
@@ -966,9 +966,7 @@ static int alc_suspend(struct hda_codec
spec->power_hook(codec);
return 0;
}
-#endif

-#ifdef CONFIG_PM
static int alc_resume(struct hda_codec *codec)
{
struct alc_spec *spec = codec->spec;

2022-05-09 06:41:08

by Takashi Iwai

Subject: Re: [PATCH] ALSA: hda - fix unused Realtek function when PM is not enabled

On Sat, 30 Apr 2022 21:33:18 +0200,
Randy Dunlap wrote:
>
> When CONFIG_PM is not enabled, alc_shutup() is not needed,
> so move it inside the #ifdef CONFIG_PM guard.
> Also drop some contiguous #endif / #ifdef CONFIG_PM for simplicity.
>
> Fixes this build warning:
> sound/pci/hda/patch_realtek.c:886:20: warning: unused function 'alc_shutup'
>
> Fixes: 08c189f2c552 ("ALSA: hda - Use generic parser codes for Realtek driver")
> Signed-off-by: Randy Dunlap <[email protected]>
> Reported-by: kernel test robot <[email protected]>
> Cc: Takashi Iwai <[email protected]>
> Cc: Jaroslav Kysela <[email protected]>
> Cc: [email protected]

Thanks, applied now.


Takashi