2023-09-13 19:06:23

by Danila Tikhonov

Subject: [PATCH] arm64: dts: qcom: pm8150l: Add wled node

WLED is used for controlling the backlight on some boards, add the node
for it.

Signed-off-by: Danila Tikhonov <[email protected]>
---
arch/arm64/boot/dts/qcom/pm8150l.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/pm8150l.dtsi b/arch/arm64/boot/dts/qcom/pm8150l.dtsi
index b1686e5777b8..ac08a09c64c2 100644
--- a/arch/arm64/boot/dts/qcom/pm8150l.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm8150l.dtsi
@@ -132,5 +132,15 @@ pm8150l_lpg: pwm {
status = "disabled";
};

+ pm8150l_wled: leds@d800 {
+ compatible = "qcom,pm8150l-wled";
+ reg = <0xd800>, <0xd900>;
+ interrupts = <0x5 0xd8 0x1 IRQ_TYPE_EDGE_RISING>,
+ <0x5 0xd8 0x2 IRQ_TYPE_EDGE_RISING>;
+ interrupt-names = "ovp", "short";
+ label = "backlight";
+
+ status = "disabled";
+ };
};
};
--
2.41.0

2023-09-13 22:09:32

by Konrad Dybcio

Subject: Re: [PATCH] arm64: dts: qcom: pm8150l: Add wled node

On 13.09.2023 20:55, Danila Tikhonov wrote:
> WLED is used for controlling the backlight on some boards, add the node
> for it.
>
> Signed-off-by: Danila Tikhonov <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/pm8150l.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/pm8150l.dtsi b/arch/arm64/boot/dts/qcom/pm8150l.dtsi
> index b1686e5777b8..ac08a09c64c2 100644
> --- a/arch/arm64/boot/dts/qcom/pm8150l.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm8150l.dtsi
> @@ -132,5 +132,15 @@ pm8150l_lpg: pwm {
> status = "disabled";
> };
>
> + pm8150l_wled: leds@d800 {
> + compatible = "qcom,pm8150l-wled";
> + reg = <0xd800>, <0xd900>;
> + interrupts = <0x5 0xd8 0x1 IRQ_TYPE_EDGE_RISING>,
> + <0x5 0xd8 0x2 IRQ_TYPE_EDGE_RISING>;
> + interrupt-names = "ovp", "short";
Could somebody confirm the second irq? It looks sane when
checking out similar blocks on older gens, but I have no
reference to confirm it's there on this one.

Konrad

2023-09-20 16:51:34

by Bjorn Andersson

Subject: Re: [PATCH] arm64: dts: qcom: pm8150l: Add wled node

On Wed, Sep 13, 2023 at 09:55:14PM +0300, Danila Tikhonov wrote:
> WLED is used for controlling the backlight on some boards, add the node
> for it.
>
> Signed-off-by: Danila Tikhonov <[email protected]>

Reviewed-by: Bjorn Andersson <[email protected]>

Regards,
Bjorn

> ---
> arch/arm64/boot/dts/qcom/pm8150l.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/pm8150l.dtsi b/arch/arm64/boot/dts/qcom/pm8150l.dtsi
> index b1686e5777b8..ac08a09c64c2 100644
> --- a/arch/arm64/boot/dts/qcom/pm8150l.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm8150l.dtsi
> @@ -132,5 +132,15 @@ pm8150l_lpg: pwm {
> status = "disabled";
> };
>
> + pm8150l_wled: leds@d800 {
> + compatible = "qcom,pm8150l-wled";
> + reg = <0xd800>, <0xd900>;
> + interrupts = <0x5 0xd8 0x1 IRQ_TYPE_EDGE_RISING>,
> + <0x5 0xd8 0x2 IRQ_TYPE_EDGE_RISING>;
> + interrupt-names = "ovp", "short";
> + label = "backlight";
> +
> + status = "disabled";
> + };
> };
> };
> --
> 2.41.0
>

2023-09-20 17:21:42

by Bjorn Andersson

Subject: Re: [PATCH] arm64: dts: qcom: pm8150l: Add wled node

On Wed, 13 Sep 2023 21:55:14 +0300, Danila Tikhonov wrote:
> WLED is used for controlling the backlight on some boards, add the node
> for it.
>
>

Applied, thanks!

[1/1] arm64: dts: qcom: pm8150l: Add wled node
commit: 4a94b52a47f63fb6db44871f446d31c28ca89bb9

Best regards,
--
Bjorn Andersson <[email protected]>