2023-01-10 16:36:39

by Yang Xiwen

Subject: [PATCH 2/3] dt-bindings: qcom: Ducument bindings for new msm8916-zhihe-uf896 and msm8916-zhihe-ufi001c

Document the new zhihe,uf896/ufi001c device tree bindings used in
their device trees.

Signed-off-by: Yang Xiwen <[email protected]>
---
Documentation/devicetree/bindings/arm/qcom.yaml | 2 ++
1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 65ef7e442da0d..efe5f6c384b69 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -210,6 +210,8 @@ properties:
- samsung,j5
- samsung,serranove
- wingtech,wt88047
+ - zhihe,uf896
+ - zhihe,ufi001c
- const: qcom,msm8916

- items:
--
2.39.0

2023-01-10 17:05:39

by Krzysztof Kozlowski

Subject: Re: [PATCH 2/3] dt-bindings: qcom: Ducument bindings for new msm8916-zhihe-uf896 and msm8916-zhihe-ufi001c

On 10/01/2023 16:50, Yang Xiwen wrote:
> Document the new zhihe,uf896/ufi001c device tree bindings used in
> their device trees.

Subject: drop second/last, redundant "bindings for". The "dt-bindings"
prefix is already stating that these are bindings.

Subject: typo - Document

Subject: shorten it, use some shorter user descriptive model name

>
> Signed-off-by: Yang Xiwen <[email protected]>
> ---
> Documentation/devicetree/bindings/arm/qcom.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index 65ef7e442da0d..efe5f6c384b69 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -210,6 +210,8 @@ properties:
> - samsung,j5
> - samsung,serranove
> - wingtech,wt88047
> + - zhihe,uf896
> + - zhihe,ufi001c

Real hardware, running real mainline OS cannot be called "placeholder".

> - const: qcom,msm8916
>
> - items:

Best regards,
Krzysztof