2018-09-12 16:47:30

by Zubin Mithra

Subject: [PATCH] perf/pt: Annotate pt_cap_group with __ro_after_init

pt_cap_group is written to in pt_pmu_hw_init and not modified after. This makes
it a suitable candidate for annotating as __ro_after_init.

Signed-off-by: Zubin Mithra <[email protected]>
---
arch/x86/events/intel/pt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/events/intel/pt.c b/arch/x86/events/intel/pt.c
index 8d016ce5b80d..3a0aa83cbd07 100644
--- a/arch/x86/events/intel/pt.c
+++ b/arch/x86/events/intel/pt.c
@@ -95,7 +95,7 @@ static ssize_t pt_cap_show(struct device *cdev,
return snprintf(buf, PAGE_SIZE, "%x\n", pt_cap_get(cap));
}

-static struct attribute_group pt_cap_group = {
+static struct attribute_group pt_cap_group __ro_after_init = {
.name = "caps",
};

--
2.18.0.597.ga71716f1ad-goog

2018-09-12 16:50:55

by Guenter Roeck

Subject: Re: [PATCH] perf/pt: Annotate pt_cap_group with __ro_after_init

On Wed, Sep 12, 2018 at 9:45 AM Zubin Mithra <[email protected]> wrote:
>
> pt_cap_group is written to in pt_pmu_hw_init and not modified after. This makes
> it a suitable candidate for annotating as __ro_after_init.
>
> Signed-off-by: Zubin Mithra <[email protected]>

Reviewed-by: Guenter Roeck <[email protected]>

> ---
> arch/x86/events/intel/pt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/events/intel/pt.c b/arch/x86/events/intel/pt.c
> index 8d016ce5b80d..3a0aa83cbd07 100644
> --- a/arch/x86/events/intel/pt.c
> +++ b/arch/x86/events/intel/pt.c
> @@ -95,7 +95,7 @@ static ssize_t pt_cap_show(struct device *cdev,
> return snprintf(buf, PAGE_SIZE, "%x\n", pt_cap_get(cap));
> }
>
> -static struct attribute_group pt_cap_group = {
> +static struct attribute_group pt_cap_group __ro_after_init = {
> .name = "caps",
> };
>
> --
> 2.18.0.597.ga71716f1ad-goog
>

2018-09-12 21:30:01

by tip-bot for Vasyl Gomonovych

Subject: [tip:perf/core] perf/x86/intel/pt: Annotate 'pt_cap_group' with __ro_after_init

Commit-ID: 49e73246cbe6fe0df9cae2db87f31cdc3a0b2b61
Gitweb: https://git.kernel.org/tip/49e73246cbe6fe0df9cae2db87f31cdc3a0b2b61
Author: Zubin Mithra <[email protected]>
AuthorDate: Wed, 12 Sep 2018 09:45:10 -0700
Committer: Ingo Molnar <[email protected]>
CommitDate: Wed, 12 Sep 2018 21:16:16 +0200

perf/x86/intel/pt: Annotate 'pt_cap_group' with __ro_after_init

'pt_cap_group' is written to in pt_pmu_hw_init() and not modified after.
This makes it a suitable candidate for annotating as __ro_after_init.

Signed-off-by: Zubin Mithra <[email protected]>
Reviewed-by: Guenter Roeck <[email protected]>
Cc: Linus Torvalds <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Cc: [email protected]
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Ingo Molnar <[email protected]>
---
arch/x86/events/intel/pt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/events/intel/pt.c b/arch/x86/events/intel/pt.c
index 8d016ce5b80d..3a0aa83cbd07 100644
--- a/arch/x86/events/intel/pt.c
+++ b/arch/x86/events/intel/pt.c
@@ -95,7 +95,7 @@ static ssize_t pt_cap_show(struct device *cdev,
return snprintf(buf, PAGE_SIZE, "%x\n", pt_cap_get(cap));
}

-static struct attribute_group pt_cap_group = {
+static struct attribute_group pt_cap_group __ro_after_init = {
.name = "caps",
};