2016-10-19 19:11:22

by Alexander Kuleshov

[permalink] [raw]
Subject: [PATCH] x86/calling.h: remove unused addskip parameter of ALLOC_PT_GPREGS_ON_STACK

as no-one user of ALLOC_PT_GPREGS_ON_STACK macro doesn't pass it.

Signed-off-by: Alexander Kuleshov <[email protected]>
---
arch/x86/entry/calling.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/entry/calling.h b/arch/x86/entry/calling.h
index 9a9e588..b493c6a 100644
--- a/arch/x86/entry/calling.h
+++ b/arch/x86/entry/calling.h
@@ -90,8 +90,8 @@ For 32-bit we have the following conventions - kernel is built with

#define SIZEOF_PTREGS 21*8

- .macro ALLOC_PT_GPREGS_ON_STACK addskip=0
- addq $-(15*8+\addskip), %rsp
+ .macro ALLOC_PT_GPREGS_ON_STACK
+ addq $-(15*8), %rsp
.endm

.macro SAVE_C_REGS_HELPER offset=0 rax=1 rcx=1 r8910=1 r11=1
--
2.8.0.rc3.1353.gea9bdc0


2016-10-19 19:28:05

by Borislav Petkov

[permalink] [raw]
Subject: Re: [PATCH] x86/calling.h: remove unused addskip parameter of ALLOC_PT_GPREGS_ON_STACK

On Thu, Oct 20, 2016 at 01:11:08AM +0600, Alexander Kuleshov wrote:
> as no-one user of ALLOC_PT_GPREGS_ON_STACK macro doesn't pass it.
>
> Signed-off-by: Alexander Kuleshov <[email protected]>
> ---
> arch/x86/entry/calling.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/entry/calling.h b/arch/x86/entry/calling.h
> index 9a9e588..b493c6a 100644
> --- a/arch/x86/entry/calling.h
> +++ b/arch/x86/entry/calling.h
> @@ -90,8 +90,8 @@ For 32-bit we have the following conventions - kernel is built with
>
> #define SIZEOF_PTREGS 21*8
>
> - .macro ALLOC_PT_GPREGS_ON_STACK addskip=0
> - addq $-(15*8+\addskip), %rsp
> + .macro ALLOC_PT_GPREGS_ON_STACK
> + addq $-(15*8), %rsp
> .endm
>
> .macro SAVE_C_REGS_HELPER offset=0 rax=1 rcx=1 r8910=1 r11=1
> --

Reviewed-by: Borislav Petkov <[email protected]>

--
Regards/Gruss,
Boris.

ECO tip #101: Trim your mails when you reply.

Subject: [tip:x86/urgent] x86/entry: Remove addskip parameter from ALLOC_PT_GPREGS_ON_STACK

Commit-ID: ac679bf247cf044a5be6ca7d380307540284dd45
Gitweb: http://git.kernel.org/tip/ac679bf247cf044a5be6ca7d380307540284dd45
Author: Alexander Kuleshov <[email protected]>
AuthorDate: Thu, 20 Oct 2016 01:11:08 +0600
Committer: Thomas Gleixner <[email protected]>
CommitDate: Thu, 20 Oct 2016 10:57:37 +0200

x86/entry: Remove addskip parameter from ALLOC_PT_GPREGS_ON_STACK

The ALLOC_PT_GPREGS_ON_STACK macro has an optional addskip parameter, which
is not used by any usage site. Remove it.

Signed-off-by: Alexander Kuleshov <[email protected]>
Reviewed-by: Borislav Petkov <[email protected]>
Cc: Paolo Bonzini <[email protected]>
Cc: Andy Lutomirski <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Thomas Gleixner <[email protected]>

---
arch/x86/entry/calling.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/entry/calling.h b/arch/x86/entry/calling.h
index 9a9e588..b493c6a 100644
--- a/arch/x86/entry/calling.h
+++ b/arch/x86/entry/calling.h
@@ -90,8 +90,8 @@ For 32-bit we have the following conventions - kernel is built with

#define SIZEOF_PTREGS 21*8

- .macro ALLOC_PT_GPREGS_ON_STACK addskip=0
- addq $-(15*8+\addskip), %rsp
+ .macro ALLOC_PT_GPREGS_ON_STACK
+ addq $-(15*8), %rsp
.endm

.macro SAVE_C_REGS_HELPER offset=0 rax=1 rcx=1 r8910=1 r11=1

Subject: [tip:x86/asm] x86/entry/64: Remove unused 'addskip' parameter of the ALLOC_PT_GPREGS_ON_STACK macro

Commit-ID: 59df2268311795ee7161776248d5288ee0841d41
Gitweb: http://git.kernel.org/tip/59df2268311795ee7161776248d5288ee0841d41
Author: Alexander Kuleshov <[email protected]>
AuthorDate: Thu, 20 Oct 2016 01:11:08 +0600
Committer: Ingo Molnar <[email protected]>
CommitDate: Thu, 20 Oct 2016 08:42:36 +0200

x86/entry/64: Remove unused 'addskip' parameter of the ALLOC_PT_GPREGS_ON_STACK macro

Signed-off-by: Alexander Kuleshov <[email protected]>
Reviewed-by: Borislav Petkov <[email protected]>
Cc: Andy Lutomirski <[email protected]>
Cc: Borislav Petkov <[email protected]>
Cc: Brian Gerst <[email protected]>
Cc: Denys Vlasenko <[email protected]>
Cc: H. Peter Anvin <[email protected]>
Cc: Josh Poimboeuf <[email protected]>
Cc: Linus Torvalds <[email protected]>
Cc: Paolo Bonzini <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Ingo Molnar <[email protected]>
---
arch/x86/entry/calling.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/entry/calling.h b/arch/x86/entry/calling.h
index 9a9e588..b493c6a 100644
--- a/arch/x86/entry/calling.h
+++ b/arch/x86/entry/calling.h
@@ -90,8 +90,8 @@ For 32-bit we have the following conventions - kernel is built with

#define SIZEOF_PTREGS 21*8

- .macro ALLOC_PT_GPREGS_ON_STACK addskip=0
- addq $-(15*8+\addskip), %rsp
+ .macro ALLOC_PT_GPREGS_ON_STACK
+ addq $-(15*8), %rsp
.endm

.macro SAVE_C_REGS_HELPER offset=0 rax=1 rcx=1 r8910=1 r11=1