2009-01-05 19:43:55

by Stefan Richter

[permalink] [raw]
Subject: [PATCH] firewire: ohci: change "context_stop: still active" log message

The present message is mostly just noise. We only need to be notified
if the "active" flag does not go off before the retry loop terminates.

Signed-off-by: Stefan Richter <[email protected]>
---
drivers/firewire/fw-ohci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Index: linux/drivers/firewire/fw-ohci.c
===================================================================
--- linux.orig/drivers/firewire/fw-ohci.c
+++ linux/drivers/firewire/fw-ohci.c
@@ -892,11 +892,11 @@ static void context_stop(struct context
for (i = 0; i < 10; i++) {
reg = reg_read(ctx->ohci, CONTROL_SET(ctx->regs));
if ((reg & CONTEXT_ACTIVE) == 0)
- break;
+ return;

- fw_notify("context_stop: still active (0x%08x)\n", reg);
mdelay(1);
}
+ fw_error("Error: DMA context still active (0x%08x)\n", reg);
}

struct driver_data {

--
Stefan Richter
-=====-==--= ---= --=-=
http://arcgraph.de/sr/