2023-02-05 17:48:53

by Frank Wunderlich

[permalink] [raw]
Subject: [PATCH] arm64: dts: mt7986: set Wifi Leds low-active for BPI-R3

From: Frank Wunderlich <[email protected]>

Leds for Wifi are low-active, so add property to devicetree.

Signed-off-by: Frank Wunderlich <[email protected]>
---
arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
index 33bd6febc160..2b028141f1f7 100644
--- a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
+++ b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
@@ -446,5 +446,9 @@ &wifi {
pinctrl-names = "default", "dbdc";
pinctrl-0 = <&wf_2g_5g_pins>, <&wf_led_pins>;
pinctrl-1 = <&wf_dbdc_pins>, <&wf_led_pins>;
+
+ led {
+ led-active-low;
+ };
};

--
2.34.1



2023-02-06 20:21:22

by Matthias Brugger

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: mt7986: set Wifi Leds low-active for BPI-R3



On 05/02/2023 18:48, Frank Wunderlich wrote:
> From: Frank Wunderlich <[email protected]>
>
> Leds for Wifi are low-active, so add property to devicetree.
>
> Signed-off-by: Frank Wunderlich <[email protected]>
> ---
> arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
> index 33bd6febc160..2b028141f1f7 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
> @@ -446,5 +446,9 @@ &wifi {
> pinctrl-names = "default", "dbdc";
> pinctrl-0 = <&wf_2g_5g_pins>, <&wf_led_pins>;
> pinctrl-1 = <&wf_dbdc_pins>, <&wf_led_pins>;
> +
> + led {
> + led-active-low;
> + };

The binding is missing this property also the driver implements it. Could you
please update the bindind description properly?
Thanks
Matthias

Subject: Re: [PATCH] arm64: dts: mt7986: set Wifi Leds low-active for BPI-R3

Il 06/02/23 21:20, Matthias Brugger ha scritto:
>
>
> On 05/02/2023 18:48, Frank Wunderlich wrote:
>> From: Frank Wunderlich <[email protected]>
>>
>> Leds for Wifi are low-active, so add property to devicetree.
>>
>> Signed-off-by: Frank Wunderlich <[email protected]>
>> ---
>>   arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
>> b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
>> index 33bd6febc160..2b028141f1f7 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
>> +++ b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
>> @@ -446,5 +446,9 @@ &wifi {
>>       pinctrl-names = "default", "dbdc";
>>       pinctrl-0 = <&wf_2g_5g_pins>, <&wf_led_pins>;
>>       pinctrl-1 = <&wf_dbdc_pins>, <&wf_led_pins>;
>> +
>> +    led {
>> +        led-active-low;
>> +    };
>
> The binding is missing this property also the driver implements it. Could you
> please update the bindind description properly?
> Thanks
> Matthias


After and only after [1] is picked,

Reviewed-by: AngeloGioacchino Del Regno <[email protected]>

[1]:
https://patchwork.kernel.org/project/linux-mediatek/patch/[email protected]/

2023-05-22 08:29:40

by Frank Wunderlich

[permalink] [raw]
Subject: Aw: Re: [PATCH] arm64: dts: mt7986: set Wifi Leds low-active for BPI-R3

> Gesendet: Dienstag, 07. Februar 2023 um 17:17 Uhr
> Von: "AngeloGioacchino Del Regno" <[email protected]>
> Il 06/02/23 21:20, Matthias Brugger ha scritto:
> >
> >
> > On 05/02/2023 18:48, Frank Wunderlich wrote:
> >> From: Frank Wunderlich <[email protected]>
> >>
> >> Leds for Wifi are low-active, so add property to devicetree.
> >>
> >> Signed-off-by: Frank Wunderlich <[email protected]>
> >> ---
> >>   arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts | 4 ++++
> >>   1 file changed, 4 insertions(+)
> >>
> >> diff --git a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
> >> b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
> >> index 33bd6febc160..2b028141f1f7 100644
> >> --- a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
> >> +++ b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
> >> @@ -446,5 +446,9 @@ &wifi {
> >>       pinctrl-names = "default", "dbdc";
> >>       pinctrl-0 = <&wf_2g_5g_pins>, <&wf_led_pins>;
> >>       pinctrl-1 = <&wf_dbdc_pins>, <&wf_led_pins>;
> >> +
> >> +    led {
> >> +        led-active-low;
> >> +    };
> >
> > The binding is missing this property also the driver implements it. Could you
> > please update the bindind description properly?
> > Thanks
> > Matthias
>
>
> After and only after [1] is picked,
>
> Reviewed-by: AngeloGioacchino Del Regno <[email protected]>
>
> [1]:
> https://patchwork.kernel.org/project/linux-mediatek/patch/[email protected]/

Hi Matthias,

Can you take this patch into your tree? binding is already merged

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml#n114

regards Frank


2023-05-29 16:21:43

by Matthias Brugger

[permalink] [raw]
Subject: Re: Aw: Re: [PATCH] arm64: dts: mt7986: set Wifi Leds low-active for BPI-R3



On 22/05/2023 10:26, Frank Wunderlich wrote:
>> Gesendet: Dienstag, 07. Februar 2023 um 17:17 Uhr
>> Von: "AngeloGioacchino Del Regno" <[email protected]>
>> Il 06/02/23 21:20, Matthias Brugger ha scritto:
>>>
>>>
>>> On 05/02/2023 18:48, Frank Wunderlich wrote:
>>>> From: Frank Wunderlich <[email protected]>
>>>>
>>>> Leds for Wifi are low-active, so add property to devicetree.
>>>>
>>>> Signed-off-by: Frank Wunderlich <[email protected]>
>>>> ---
>>>>   arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts | 4 ++++
>>>>   1 file changed, 4 insertions(+)
>>>>
>>>> diff --git a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
>>>> b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
>>>> index 33bd6febc160..2b028141f1f7 100644
>>>> --- a/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
>>>> +++ b/arch/arm64/boot/dts/mediatek/mt7986a-bananapi-bpi-r3.dts
>>>> @@ -446,5 +446,9 @@ &wifi {
>>>>       pinctrl-names = "default", "dbdc";
>>>>       pinctrl-0 = <&wf_2g_5g_pins>, <&wf_led_pins>;
>>>>       pinctrl-1 = <&wf_dbdc_pins>, <&wf_led_pins>;
>>>> +
>>>> +    led {
>>>> +        led-active-low;
>>>> +    };
>>>
>>> The binding is missing this property also the driver implements it. Could you
>>> please update the bindind description properly?
>>> Thanks
>>> Matthias
>>
>>
>> After and only after [1] is picked,
>>
>> Reviewed-by: AngeloGioacchino Del Regno <[email protected]>
>>
>> [1]:
>> https://patchwork.kernel.org/project/linux-mediatek/patch/[email protected]/
>
> Hi Matthias,
>
> Can you take this patch into your tree? binding is already merged
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml#n114
>

Applied now :)

Regards,
Matthias