2024-03-03 11:05:26

by Maxim Moskalets

Subject: [PATCH] kernel/sched: use seq_putc instead of seq_puts

Using seq_putc for newline characters is faster and more appropriate
than seq_puts, since only one character is passed and there is no need
to use a more powerful and less fast function

Signed-off-by: Maxim Moskalets <[email protected]>
---
kernel/sched/cpuacct.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/kernel/sched/cpuacct.c b/kernel/sched/cpuacct.c
index 0de9dda09949..54d9dd68f517 100644
--- a/kernel/sched/cpuacct.c
+++ b/kernel/sched/cpuacct.c
@@ -217,7 +217,7 @@ static int __cpuacct_percpu_seq_show(struct seq_file *m,
percpu = cpuacct_cpuusage_read(ca, i, index);
seq_printf(m, "%llu ", (unsigned long long) percpu);
}
- seq_printf(m, "\n");
+ seq_putc(m, '\n');
return 0;
}

@@ -245,14 +245,14 @@ static int cpuacct_all_seq_show(struct seq_file *m, void *V)
seq_puts(m, "cpu");
for (index = 0; index < CPUACCT_STAT_NSTATS; index++)
seq_printf(m, " %s", cpuacct_stat_desc[index]);
- seq_puts(m, "\n");
+ seq_putc(m, '\n');

for_each_possible_cpu(cpu) {
seq_printf(m, "%d", cpu);
for (index = 0; index < CPUACCT_STAT_NSTATS; index++)
seq_printf(m, " %llu",
cpuacct_cpuusage_read(ca, cpu, index));
- seq_puts(m, "\n");
+ seq_putc(m, '\n');
}
return 0;
}
--
2.34.1

2024-03-14 16:00:48

by Valentin Schneider

Subject: Re: [PATCH] kernel/sched: use seq_putc instead of seq_puts

On 03/03/24 14:05, Maxim Moskalets wrote:
> Using seq_putc for newline characters is faster and more appropriate
> than seq_puts, since only one character is passed and there is no need
> to use a more powerful and less fast function
>

Why not, but then why not do this treewide? A quick grep shows ~340 such
sites. That makes for a fairly easy coccinelle patch.