2019-04-24 08:10:13

by Yue Haibing

Subject: [PATCH -next] scsi: qedi: remove set but not used variables 'cdev' and 'udev'

From: YueHaibing <[email protected]>

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/scsi/qedi/qedi_iscsi.c: In function 'qedi_ep_connect':
drivers/scsi/qedi/qedi_iscsi.c:813:23: warning: variable 'udev' set but not used [-Wunused-but-set-variable]
drivers/scsi/qedi/qedi_iscsi.c:812:18: warning: variable 'cdev' set but not used [-Wunused-but-set-variable]

They are never used since introduction.

Signed-off-by: YueHaibing <[email protected]>
---
drivers/scsi/qedi/qedi_iscsi.c | 4 ----
1 file changed, 4 deletions(-)

diff --git a/drivers/scsi/qedi/qedi_iscsi.c b/drivers/scsi/qedi/qedi_iscsi.c
index e4391ee..688a6d8 100644
--- a/drivers/scsi/qedi/qedi_iscsi.c
+++ b/drivers/scsi/qedi/qedi_iscsi.c
@@ -809,8 +809,6 @@ qedi_ep_connect(struct Scsi_Host *shost, struct sockaddr *dst_addr,
struct qedi_endpoint *qedi_ep;
struct sockaddr_in *addr;
struct sockaddr_in6 *addr6;
- struct qed_dev *cdev = NULL;
- struct qedi_uio_dev *udev = NULL;
struct iscsi_path path_req;
u32 msg_type = ISCSI_KEVENT_IF_DOWN;
u32 iscsi_cid = QEDI_CID_RESERVED;
@@ -830,8 +828,6 @@ qedi_ep_connect(struct Scsi_Host *shost, struct sockaddr *dst_addr,
}

qedi = iscsi_host_priv(shost);
- cdev = qedi->cdev;
- udev = qedi->udev;

if (test_bit(QEDI_IN_OFFLINE, &qedi->flags) ||
test_bit(QEDI_IN_RECOVERY, &qedi->flags)) {
--
2.7.4

2019-05-10 05:32:05

by Manish Rangankar

Subject: RE: [PATCH -next] scsi: qedi: remove set but not used variables 'cdev' and 'udev'

> -----Original Message-----
> From: [email protected] <linux-scsi-
> [email protected]> On Behalf Of Yue Haibing
> Sent: Wednesday, April 24, 2019 1:33 PM
> To: [email protected]; [email protected];
> [email protected]
> Cc: [email protected]; [email protected]; YueHaibing
> <[email protected]>
> Subject: [PATCH -next] scsi: qedi: remove set but not used variables 'cdev'
> and 'udev'
>
> From: YueHaibing <[email protected]>
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/scsi/qedi/qedi_iscsi.c: In function 'qedi_ep_connect':
> drivers/scsi/qedi/qedi_iscsi.c:813:23: warning: variable 'udev' set but not
> used [-Wunused-but-set-variable]
> drivers/scsi/qedi/qedi_iscsi.c:812:18: warning: variable 'cdev' set but not
> used [-Wunused-but-set-variable]
>
> They are never used since introduction.
>
> Signed-off-by: YueHaibing <[email protected]>
> ---
> drivers/scsi/qedi/qedi_iscsi.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/scsi/qedi/qedi_iscsi.c b/drivers/scsi/qedi/qedi_iscsi.c
> index e4391ee..688a6d8 100644
> --- a/drivers/scsi/qedi/qedi_iscsi.c
> +++ b/drivers/scsi/qedi/qedi_iscsi.c
> @@ -809,8 +809,6 @@ qedi_ep_connect(struct Scsi_Host *shost, struct
> sockaddr *dst_addr,
> struct qedi_endpoint *qedi_ep;
> struct sockaddr_in *addr;
> struct sockaddr_in6 *addr6;
> - struct qed_dev *cdev = NULL;
> - struct qedi_uio_dev *udev = NULL;
> struct iscsi_path path_req;
> u32 msg_type = ISCSI_KEVENT_IF_DOWN;
> u32 iscsi_cid = QEDI_CID_RESERVED;
> @@ -830,8 +828,6 @@ qedi_ep_connect(struct Scsi_Host *shost, struct
> sockaddr *dst_addr,
> }
>
> qedi = iscsi_host_priv(shost);
> - cdev = qedi->cdev;
> - udev = qedi->udev;
>
> if (test_bit(QEDI_IN_OFFLINE, &qedi->flags) ||
> test_bit(QEDI_IN_RECOVERY, &qedi->flags)) {
> --
> 2.7.4
>

Thanks,

Acked-by: Manish Rangankar <[email protected]>

2019-05-13 22:34:31

by Martin K. Petersen

Subject: Re: [PATCH -next] scsi: qedi: remove set but not used variables 'cdev' and 'udev'

Yue,

> From: YueHaibing <[email protected]>
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/scsi/qedi/qedi_iscsi.c: In function 'qedi_ep_connect':
> drivers/scsi/qedi/qedi_iscsi.c:813:23: warning: variable 'udev' set but not used [-Wunused-but-set-variable]
> drivers/scsi/qedi/qedi_iscsi.c:812:18: warning: variable 'cdev' set but not used [-Wunused-but-set-variable]

Applied to 5.2/scsi-queue. Thanks!

--
Martin K. Petersen Oracle Linux Engineering