2024-04-06 15:50:46

by Colin Ian King

[permalink] [raw]
Subject: [PATCH][next] scsi: FlashPoint: remove redundant assignment to pointer currTar_Info

Pointer currTar_Info is being assigned a value that is never read, it
is being re-assigned a few lines later in the start of a following
do-while loop. The assignment is redundant and can be removed.

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/scsi/FlashPoint.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/scsi/FlashPoint.c b/drivers/scsi/FlashPoint.c
index 3d9c56ac8224..9e77b8e1ea7c 100644
--- a/drivers/scsi/FlashPoint.c
+++ b/drivers/scsi/FlashPoint.c
@@ -2631,7 +2631,6 @@ static void FPT_sres(u32 port, unsigned char p_card,
WRW_HARPOON((port + hp_fiforead), (unsigned short)0x00);

our_target = (unsigned char)(RD_HARPOON(port + hp_select_id) >> 4);
- currTar_Info = &FPT_sccbMgrTbl[p_card][our_target];

msgRetryCount = 0;
do {
--
2.39.2



2024-04-09 01:57:20

by Martin K. Petersen

[permalink] [raw]
Subject: Re: [PATCH][next] scsi: FlashPoint: remove redundant assignment to pointer currTar_Info


Colin,

> Pointer currTar_Info is being assigned a value that is never read, it
> is being re-assigned a few lines later in the start of a following
> do-while loop. The assignment is redundant and can be removed.

Applied to 6.10/scsi-staging, thanks!

--
Martin K. Petersen Oracle Linux Engineering

2024-04-12 02:05:51

by Martin K. Petersen

[permalink] [raw]
Subject: Re: [PATCH][next] scsi: FlashPoint: remove redundant assignment to pointer currTar_Info

On Sat, 06 Apr 2024 16:50:29 +0100, Colin Ian King wrote:

> Pointer currTar_Info is being assigned a value that is never read, it
> is being re-assigned a few lines later in the start of a following
> do-while loop. The assignment is redundant and can be removed.
>
>

Applied to 6.10/scsi-queue, thanks!

[1/1] scsi: FlashPoint: remove redundant assignment to pointer currTar_Info
https://git.kernel.org/mkp/scsi/c/9bd8e41358a5

--
Martin K. Petersen Oracle Linux Engineering