2022-04-20 08:29:46

by baihaowen

Subject: [PATCH V2] s390/dasd: Use kzalloc instead of kmalloc/memset

Use kzalloc rather than duplicating its implementation, which
makes code simple and easy to understand.

Signed-off-by: Haowen Bai <[email protected]>
---
V1->V2: also remove the isglobal assigment above, so the whole else block
could go away

drivers/s390/block/dasd_eckd.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/s390/block/dasd_eckd.c b/drivers/s390/block/dasd_eckd.c
index 8410a25a65c1..6b70f9dfff02 100644
--- a/drivers/s390/block/dasd_eckd.c
+++ b/drivers/s390/block/dasd_eckd.c
@@ -1480,7 +1480,7 @@ static int dasd_eckd_pe_handler(struct dasd_device *device,
{
struct pe_handler_work_data *data;

- data = kmalloc(sizeof(*data), GFP_ATOMIC | GFP_DMA);
+ data = kzalloc(sizeof(*data), GFP_ATOMIC | GFP_DMA);
if (!data) {
if (mutex_trylock(&dasd_pe_handler_mutex)) {
data = pe_handler_worker;
@@ -1488,9 +1488,6 @@ static int dasd_eckd_pe_handler(struct dasd_device *device,
} else {
return -ENOMEM;
}
- } else {
- memset(data, 0, sizeof(*data));
- data->isglobal = 0;
}
INIT_WORK(&data->worker, do_pe_handler_work);
dasd_get_device(device);
--
2.7.4

2022-04-22 20:06:40

by Sven Schnelle

Subject: Re: [PATCH V2] s390/dasd: Use kzalloc instead of kmalloc/memset

Haowen Bai <[email protected]> writes:

> Use kzalloc rather than duplicating its implementation, which
> makes code simple and easy to understand.
>
> Signed-off-by: Haowen Bai <[email protected]>
> ---
> V1->V2: also remove the isglobal assigment above, so the whole else block
> could go away
>
> drivers/s390/block/dasd_eckd.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/s390/block/dasd_eckd.c b/drivers/s390/block/dasd_eckd.c
> index 8410a25a65c1..6b70f9dfff02 100644
> --- a/drivers/s390/block/dasd_eckd.c
> +++ b/drivers/s390/block/dasd_eckd.c
> @@ -1480,7 +1480,7 @@ static int dasd_eckd_pe_handler(struct dasd_device *device,
> {
> struct pe_handler_work_data *data;
>
> - data = kmalloc(sizeof(*data), GFP_ATOMIC | GFP_DMA);
> + data = kzalloc(sizeof(*data), GFP_ATOMIC | GFP_DMA);
> if (!data) {
> if (mutex_trylock(&dasd_pe_handler_mutex)) {
> data = pe_handler_worker;
> @@ -1488,9 +1488,6 @@ static int dasd_eckd_pe_handler(struct dasd_device *device,
> } else {
> return -ENOMEM;
> }
> - } else {
> - memset(data, 0, sizeof(*data));
> - data->isglobal = 0;
> }
> INIT_WORK(&data->worker, do_pe_handler_work);
> dasd_get_device(device);

Reviewed-by: Sven Schnelle <[email protected]>

2022-04-29 18:14:20

by Stefan Haberland

Subject: Re: [PATCH V2] s390/dasd: Use kzalloc instead of kmalloc/memset

Am 19.04.22 um 08:05 schrieb Haowen Bai:
> Use kzalloc rather than duplicating its implementation, which
> makes code simple and easy to understand.
>
> Signed-off-by: Haowen Bai <[email protected]>
> ---
> V1->V2: also remove the isglobal assigment above, so the whole else block
> could go away

thanks, applied!