2015-07-28 08:46:04

by Shraddha Barke

Subject: [PATCH] Drivers: isdn: Drop unnecessary continue

The semantic patch used to make this change is :

@@
@@
for (...;...;...) {
...
if (...) {
...
- continue;
}
}

Signed-off-by: Shraddha Barke <[email protected]>
---
drivers/isdn/hardware/mISDN/hfcsusb.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/isdn/hardware/mISDN/hfcsusb.c b/drivers/isdn/hardware/mISDN/hfcsusb.c
index 114f3bc..91beb83 100644
--- a/drivers/isdn/hardware/mISDN/hfcsusb.c
+++ b/drivers/isdn/hardware/mISDN/hfcsusb.c
@@ -1921,10 +1921,9 @@ hfcsusb_probe(struct usb_interface *intf, const struct usb_device_id *id)
if ((le16_to_cpu(dev->descriptor.idVendor)
== hfcsusb_idtab[i].idVendor) &&
(le16_to_cpu(dev->descriptor.idProduct)
- == hfcsusb_idtab[i].idProduct)) {
+ == hfcsusb_idtab[i].idProduct))
vend_idx = i;
- continue;
- }
+
}

printk(KERN_DEBUG
--
2.1.0

2015-07-28 08:48:12

by Julia Lawall

Subject: Re: [PATCH] Drivers: isdn: Drop unnecessary continue

The patch should have v2 in the subject line, and should have a
description of the change since the previous version under the ---

On Tue, 28 Jul 2015, Shraddha Barke wrote:

> The semantic patch used to make this change is :
>
> @@
> @@
> for (...;...;...) {
> ...
> if (...) {
> ...
> - continue;
> }
> }
>
> Signed-off-by: Shraddha Barke <[email protected]>
> ---
> drivers/isdn/hardware/mISDN/hfcsusb.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/isdn/hardware/mISDN/hfcsusb.c b/drivers/isdn/hardware/mISDN/hfcsusb.c
> index 114f3bc..91beb83 100644
> --- a/drivers/isdn/hardware/mISDN/hfcsusb.c
> +++ b/drivers/isdn/hardware/mISDN/hfcsusb.c
> @@ -1921,10 +1921,9 @@ hfcsusb_probe(struct usb_interface *intf, const struct usb_device_id *id)
> if ((le16_to_cpu(dev->descriptor.idVendor)
> == hfcsusb_idtab[i].idVendor) &&
> (le16_to_cpu(dev->descriptor.idProduct)
> - == hfcsusb_idtab[i].idProduct)) {
> + == hfcsusb_idtab[i].idProduct))
> vend_idx = i;
> - continue;
> - }
> +

There is no need to add a blank line here.

julia

> }
>
> printk(KERN_DEBUG
> --
> 2.1.0
>
>

2015-07-28 10:18:18

by Eric Dumazet

Subject: Re: [PATCH] Drivers: isdn: Drop unnecessary continue

On Tue, 2015-07-28 at 14:11 +0530, Shraddha Barke wrote:
> The semantic patch used to make this change is :
>
> @@
> @@
> for (...;...;...) {
> ...
> if (...) {
> ...
> - continue;
> }
> }
>
> Signed-off-by: Shraddha Barke <[email protected]>
> ---
> drivers/isdn/hardware/mISDN/hfcsusb.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/isdn/hardware/mISDN/hfcsusb.c b/drivers/isdn/hardware/mISDN/hfcsusb.c
> index 114f3bc..91beb83 100644
> --- a/drivers/isdn/hardware/mISDN/hfcsusb.c
> +++ b/drivers/isdn/hardware/mISDN/hfcsusb.c
> @@ -1921,10 +1921,9 @@ hfcsusb_probe(struct usb_interface *intf, const struct usb_device_id *id)
> if ((le16_to_cpu(dev->descriptor.idVendor)
> == hfcsusb_idtab[i].idVendor) &&
> (le16_to_cpu(dev->descriptor.idProduct)
> - == hfcsusb_idtab[i].idProduct)) {
> + == hfcsusb_idtab[i].idProduct))
> vend_idx = i;
> - continue;
> - }
> +
> }
>
> printk(KERN_DEBUG


Well, it seems author intent was to use a break instead of a continue.

Not a big deal...