2017-08-09 07:39:06

by Arvind Yadav

Subject: [PATCH] drm: bridge: dw-hdmi: constify snd_pcm_ops structures

snd_pcm_ops are not supposed to change at runtime. All functions
working with snd_pcm_ops provided by <sound/pcm.h> work with
const snd_pcm_ops. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c
index 8f2d137..cf3f0ca 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c
@@ -517,7 +517,7 @@ static snd_pcm_uframes_t dw_hdmi_pointer(struct snd_pcm_substream *substream)
return bytes_to_frames(runtime, dw->buf_offset);
}

-static struct snd_pcm_ops snd_dw_hdmi_ops = {
+static const struct snd_pcm_ops snd_dw_hdmi_ops = {
.open = dw_hdmi_open,
.close = dw_hdmi_close,
.ioctl = snd_pcm_lib_ioctl,
--
1.9.1

2017-08-09 08:37:53

by Laurent Pinchart

Subject: Re: [PATCH] drm: bridge: dw-hdmi: constify snd_pcm_ops structures

Hi Arvind,

Thank you for the patch.

On Wednesday 09 Aug 2017 13:08:37 Arvind Yadav wrote:
> snd_pcm_ops are not supposed to change at runtime. All functions
> working with snd_pcm_ops provided by <sound/pcm.h> work with
> const snd_pcm_ops. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <[email protected]>

Reviewed-by: Laurent Pinchart <[email protected]>

> ---
> drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c
> b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c index
> 8f2d137..cf3f0ca 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c
> @@ -517,7 +517,7 @@ static snd_pcm_uframes_t dw_hdmi_pointer(struct
> snd_pcm_substream *substream) return bytes_to_frames(runtime,
> dw->buf_offset);
> }
>
> -static struct snd_pcm_ops snd_dw_hdmi_ops = {
> +static const struct snd_pcm_ops snd_dw_hdmi_ops = {
> .open = dw_hdmi_open,
> .close = dw_hdmi_close,
> .ioctl = snd_pcm_lib_ioctl,

--
Regards,

Laurent Pinchart

2017-08-09 12:36:30

by Archit Taneja

Subject: Re: [PATCH] drm: bridge: dw-hdmi: constify snd_pcm_ops structures

On 08/09/2017 02:08 PM, Laurent Pinchart wrote:
> Hi Arvind,
>
> Thank you for the patch.
>
> On Wednesday 09 Aug 2017 13:08:37 Arvind Yadav wrote:
>> snd_pcm_ops are not supposed to change at runtime. All functions
>> working with snd_pcm_ops provided by <sound/pcm.h> work with
>> const snd_pcm_ops. So mark the non-const structs as const.
>>
>> Signed-off-by: Arvind Yadav <[email protected]>
>
> Reviewed-by: Laurent Pinchart <[email protected]>

queued to drm-misc-next

Thanks,
Archit

>
>> ---
>> drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c
>> b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c index
>> 8f2d137..cf3f0ca 100644
>> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c
>> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c
>> @@ -517,7 +517,7 @@ static snd_pcm_uframes_t dw_hdmi_pointer(struct
>> snd_pcm_substream *substream) return bytes_to_frames(runtime,
>> dw->buf_offset);
>> }
>>
>> -static struct snd_pcm_ops snd_dw_hdmi_ops = {
>> +static const struct snd_pcm_ops snd_dw_hdmi_ops = {
>> .open = dw_hdmi_open,
>> .close = dw_hdmi_close,
>> .ioctl = snd_pcm_lib_ioctl,
>

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project