2018-12-24 14:33:33

by Brajeswar Ghosh

Subject: [PATCH] drm/bridge/panel: Remove duplicate header

Remove drm/drm_panel.h which is included more than once

Signed-off-by: Brajeswar Ghosh <[email protected]>
---
drivers/gpu/drm/bridge/panel.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
index 7cbaba213ef6..402b318eeeb2 100644
--- a/drivers/gpu/drm/bridge/panel.c
+++ b/drivers/gpu/drm/bridge/panel.c
@@ -15,7 +15,6 @@
#include <drm/drm_crtc_helper.h>
#include <drm/drm_encoder.h>
#include <drm/drm_modeset_helper_vtables.h>
-#include <drm/drm_panel.h>

struct panel_bridge {
struct drm_bridge bridge;
--
2.17.1

2018-12-26 09:42:08

by Laurent Pinchart

Subject: Re: [PATCH] drm/bridge/panel: Remove duplicate header

Hi Brajeswar,

Thank you for the patch.

On Monday, 24 December 2018 16:32:18 EET Brajeswar Ghosh wrote:
> Remove drm/drm_panel.h which is included more than once
>
> Signed-off-by: Brajeswar Ghosh <[email protected]>
> ---
> drivers/gpu/drm/bridge/panel.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
> index 7cbaba213ef6..402b318eeeb2 100644
> --- a/drivers/gpu/drm/bridge/panel.c
> +++ b/drivers/gpu/drm/bridge/panel.c
> @@ -15,7 +15,6 @@
> #include <drm/drm_crtc_helper.h>
> #include <drm/drm_encoder.h>
> #include <drm/drm_modeset_helper_vtables.h>
> -#include <drm/drm_panel.h>

While at it, how about sorting headers alphabetically to make sure this won't
happen again ?

With that change,

Reviewed-by: Laurent Pinchart <[email protected]>

> struct panel_bridge {
> struct drm_bridge bridge;

--
Regards,

Laurent Pinchart

2018-12-26 10:58:58

by Sam Ravnborg

Subject: Re: [PATCH] drm/bridge/panel: Remove duplicate header

Hi Brajeswar

> On Monday, 24 December 2018 16:32:18 EET Brajeswar Ghosh wrote:
> > Remove drm/drm_panel.h which is included more than once
> >
> > Signed-off-by: Brajeswar Ghosh <[email protected]>
> > ---
> > drivers/gpu/drm/bridge/panel.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
> > index 7cbaba213ef6..402b318eeeb2 100644
> > --- a/drivers/gpu/drm/bridge/panel.c
> > +++ b/drivers/gpu/drm/bridge/panel.c
> > @@ -15,7 +15,6 @@
> > #include <drm/drm_crtc_helper.h>
> > #include <drm/drm_encoder.h>
> > #include <drm/drm_modeset_helper_vtables.h>
> > -#include <drm/drm_panel.h>
>
> While at it, how about sorting headers alphabetically to make sure this won't
> happen again ?

Even better would be to address the todo item:
"Clean up the DRM header mess" (see Documentation/gpu/todo.rst)

In other words - replace the include of "drmP.h" with the relevant header files.
Sorted, as suggested by Laurent.

Sam

2019-01-30 14:37:45

by Brajeswar Ghosh

Subject: Re: [PATCH] drm/bridge/panel: Remove duplicate header

On Wed, Dec 26, 2018 at 3:09 PM Laurent Pinchart
<[email protected]> wrote:
>
> Hi Brajeswar,
>
> Thank you for the patch.
>
> On Monday, 24 December 2018 16:32:18 EET Brajeswar Ghosh wrote:
> > Remove drm/drm_panel.h which is included more than once
> >
> > Signed-off-by: Brajeswar Ghosh <[email protected]>
> > ---
> > drivers/gpu/drm/bridge/panel.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
> > index 7cbaba213ef6..402b318eeeb2 100644
> > --- a/drivers/gpu/drm/bridge/panel.c
> > +++ b/drivers/gpu/drm/bridge/panel.c
> > @@ -15,7 +15,6 @@
> > #include <drm/drm_crtc_helper.h>
> > #include <drm/drm_encoder.h>
> > #include <drm/drm_modeset_helper_vtables.h>
> > -#include <drm/drm_panel.h>
>
> While at it, how about sorting headers alphabetically to make sure this won't
> happen again ?
>
> With that change,
>
> Reviewed-by: Laurent Pinchart <[email protected]>

If no further comment, can we get this patch in queue for 5.1 ?

>
> > struct panel_bridge {
> > struct drm_bridge bridge;
>
> --
> Regards,
>
> Laurent Pinchart
>
>
>

2019-01-30 15:11:44

by Souptick Joarder

Subject: Re: [PATCH] drm/bridge/panel: Remove duplicate header

On Wed, Jan 30, 2019 at 8:07 PM Brajeswar Ghosh
<[email protected]> wrote:
>
> On Wed, Dec 26, 2018 at 3:09 PM Laurent Pinchart
> <[email protected]> wrote:
> >
> > Hi Brajeswar,
> >
> > Thank you for the patch.
> >
> > On Monday, 24 December 2018 16:32:18 EET Brajeswar Ghosh wrote:
> > > Remove drm/drm_panel.h which is included more than once
> > >
> > > Signed-off-by: Brajeswar Ghosh <[email protected]>
> > > ---
> > > drivers/gpu/drm/bridge/panel.c | 1 -
> > > 1 file changed, 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
> > > index 7cbaba213ef6..402b318eeeb2 100644
> > > --- a/drivers/gpu/drm/bridge/panel.c
> > > +++ b/drivers/gpu/drm/bridge/panel.c
> > > @@ -15,7 +15,6 @@
> > > #include <drm/drm_crtc_helper.h>
> > > #include <drm/drm_encoder.h>
> > > #include <drm/drm_modeset_helper_vtables.h>
> > > -#include <drm/drm_panel.h>
> >
> > While at it, how about sorting headers alphabetically to make sure this won't
> > happen again ?
> >
> > With that change,
> >
> > Reviewed-by: Laurent Pinchart <[email protected]>
>
> If no further comment, can we get this patch in queue for 5.1 ?

You already got a feedback from Laurent.
>
> >
> > > struct panel_bridge {
> > > struct drm_bridge bridge;
> >
> > --
> > Regards,
> >
> > Laurent Pinchart
> >
> >
> >