2021-03-25 03:42:42

by Jiabing Wan

Subject: [PATCH] include: linux: debug_locks: Remove duplicate declaration

struct task_struct is declared at 9th line. Remove the duplicate.

Signed-off-by: Wan Jiabing <[email protected]>
---
include/linux/debug_locks.h | 1 -
1 file changed, 1 deletion(-)

diff --git a/include/linux/debug_locks.h b/include/linux/debug_locks.h
index 2915f56ad421..0b3187a5290d 100644
--- a/include/linux/debug_locks.h
+++ b/include/linux/debug_locks.h
@@ -46,7 +46,6 @@ extern int debug_locks_off(void);
# define locking_selftest() do { } while (0)
#endif

-struct task_struct;

#ifdef CONFIG_LOCKDEP
extern void debug_show_all_locks(void);
--
2.25.1

2021-03-25 13:24:03

by Andy Shevchenko

Subject: Re: [PATCH] include: linux: debug_locks: Remove duplicate declaration

On Thu, Mar 25, 2021 at 10:26:58AM +0800, Wan Jiabing wrote:
> struct task_struct is declared at 9th line. Remove the duplicate.

It seems the duplicate is the other one and you removed wrong one.

> Signed-off-by: Wan Jiabing <[email protected]>
> ---
> include/linux/debug_locks.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/linux/debug_locks.h b/include/linux/debug_locks.h
> index 2915f56ad421..0b3187a5290d 100644
> --- a/include/linux/debug_locks.h
> +++ b/include/linux/debug_locks.h
> @@ -46,7 +46,6 @@ extern int debug_locks_off(void);
> # define locking_selftest() do { } while (0)
> #endif
>
> -struct task_struct;
>
> #ifdef CONFIG_LOCKDEP
> extern void debug_show_all_locks(void);
> --
> 2.25.1
>

--
With Best Regards,
Andy Shevchenko

2021-03-25 13:25:50

by Andy Shevchenko

Subject: Re: [PATCH] include: linux: debug_locks: Remove duplicate declaration

On Thu, Mar 25, 2021 at 03:22:22PM +0200, Andy Shevchenko wrote:
> On Thu, Mar 25, 2021 at 10:26:58AM +0800, Wan Jiabing wrote:
> > struct task_struct is declared at 9th line. Remove the duplicate.
>
> It seems the duplicate is the other one and you removed wrong one.

Okay, they are on the same level of ifdeffery, technically there is no
difference. Practically the other one closer to its user.

--
With Best Regards,
Andy Shevchenko