The sqe_ptr argument has been gone since 709b302faddf (io_uring:
simplify io_get_sqring, 2020-04-08), made the return value of the
function. Update the comment accordingly.
Signed-off-by: Fam Zheng <[email protected]>
---
fs/io_uring.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/io_uring.c b/fs/io_uring.c
index 903458afd56c..bb3685ba335d 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -6670,7 +6670,7 @@ static void io_commit_sqring(struct io_ring_ctx *ctx)
}
/*
- * Fetch an sqe, if one is available. Note that sqe_ptr will point to memory
+ * Fetch an sqe, if one is available. Note this returns a pointer to memory
* that is mapped by userspace. This means that care needs to be taken to
* ensure that reads are stable, as we cannot rely on userspace always
* being a good citizen. If members of the sqe are validated and then later
--
2.31.1
On 6/4/21 5:42 PM, Fam Zheng wrote:
> The sqe_ptr argument has been gone since 709b302faddf (io_uring:
> simplify io_get_sqring, 2020-04-08), made the return value of the
> function. Update the comment accordingly.
Reviewed-by: Pavel Begunkov <[email protected]>
>
> Signed-off-by: Fam Zheng <[email protected]>
> ---
> fs/io_uring.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/io_uring.c b/fs/io_uring.c
> index 903458afd56c..bb3685ba335d 100644
> --- a/fs/io_uring.c
> +++ b/fs/io_uring.c
> @@ -6670,7 +6670,7 @@ static void io_commit_sqring(struct io_ring_ctx *ctx)
> }
>
> /*
> - * Fetch an sqe, if one is available. Note that sqe_ptr will point to memory
> + * Fetch an sqe, if one is available. Note this returns a pointer to memory
> * that is mapped by userspace. This means that care needs to be taken to
> * ensure that reads are stable, as we cannot rely on userspace always
> * being a good citizen. If members of the sqe are validated and then later
>
--
Pavel Begunkov
On 6/4/21 10:42 AM, Fam Zheng wrote:
> The sqe_ptr argument has been gone since 709b302faddf (io_uring:
> simplify io_get_sqring, 2020-04-08), made the return value of the
> function. Update the comment accordingly.
Applied, thanks.
--
Jens Axboe