Use if and else instead of if(A) and if (!A).
Signed-off-by: Wan Jiabing <[email protected]>
---
drivers/mmc/host/atmel-mci.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c
index 807177c953f3..98893ccad4bd 100644
--- a/drivers/mmc/host/atmel-mci.c
+++ b/drivers/mmc/host/atmel-mci.c
@@ -1125,8 +1125,7 @@ atmci_prepare_data_dma(struct atmel_mci *host, struct mmc_data *data)
chan = host->dma.chan;
if (chan)
host->data_chan = chan;
-
- if (!chan)
+ else
return -ENODEV;
if (data->flags & MMC_DATA_READ) {
--
2.35.1
On Sun, 24 Apr 2022 at 11:04, Wan Jiabing <[email protected]> wrote:
>
> Use if and else instead of if(A) and if (!A).
>
> Signed-off-by: Wan Jiabing <[email protected]>
> ---
> drivers/mmc/host/atmel-mci.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c
> index 807177c953f3..98893ccad4bd 100644
> --- a/drivers/mmc/host/atmel-mci.c
> +++ b/drivers/mmc/host/atmel-mci.c
> @@ -1125,8 +1125,7 @@ atmci_prepare_data_dma(struct atmel_mci *host, struct mmc_data *data)
> chan = host->dma.chan;
> if (chan)
> host->data_chan = chan;
> -
> - if (!chan)
> + else
> return -ENODEV;
To make a slightly better improvement of the code, I suggest we add an
early bail out point in the atmci_prepare_data_dma() function. Like
below:
if (!host->dma.chan)
return -ENODEV;
[...]
Kind regards
Uffe
On Tue, 26 Apr 2022 at 17:06, Wan Jiabing <[email protected]> wrote:
>
> On Tue, Apr 26, 2022 at 03:53:09PM +0200, Ulf Hansson wrote:
> > On Sun, 24 Apr 2022 at 11:04, Wan Jiabing <[email protected]> wrote:
> > >
> > > Use if and else instead of if(A) and if (!A).
> > >
> > > Signed-off-by: Wan Jiabing <[email protected]>
> > > ---
> > > drivers/mmc/host/atmel-mci.c | 3 +--
> > > 1 file changed, 1 insertion(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c
> > > index 807177c953f3..98893ccad4bd 100644
> > > --- a/drivers/mmc/host/atmel-mci.c
> > > +++ b/drivers/mmc/host/atmel-mci.c
> > > @@ -1125,8 +1125,7 @@ atmci_prepare_data_dma(struct atmel_mci *host, struct mmc_data *data)
> > > chan = host->dma.chan;
> > > if (chan)
> > > host->data_chan = chan;
> > > -
> > > - if (!chan)
> > > + else
> > > return -ENODEV;
> >
> > To make a slightly better improvement of the code, I suggest we add an
> > early bail out point in the atmci_prepare_data_dma() function. Like
> > below:
> >
> > if (!host->dma.chan)
> > return -ENODEV;
> >
> > [...]
> >
> > Kind regards
> > Uffe
>
> OK
>
> How about this new patch?
Please post a new version in plain text, not as an attachment.
Kind regards
Uffe
On Tue, Apr 26, 2022 at 03:53:09PM +0200, Ulf Hansson wrote:
> On Sun, 24 Apr 2022 at 11:04, Wan Jiabing <[email protected]> wrote:
> >
> > Use if and else instead of if(A) and if (!A).
> >
> > Signed-off-by: Wan Jiabing <[email protected]>
> > ---
> > drivers/mmc/host/atmel-mci.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c
> > index 807177c953f3..98893ccad4bd 100644
> > --- a/drivers/mmc/host/atmel-mci.c
> > +++ b/drivers/mmc/host/atmel-mci.c
> > @@ -1125,8 +1125,7 @@ atmci_prepare_data_dma(struct atmel_mci *host, struct mmc_data *data)
> > chan = host->dma.chan;
> > if (chan)
> > host->data_chan = chan;
> > -
> > - if (!chan)
> > + else
> > return -ENODEV;
>
> To make a slightly better improvement of the code, I suggest we add an
> early bail out point in the atmci_prepare_data_dma() function. Like
> below:
>
> if (!host->dma.chan)
> return -ENODEV;
>
> [...]
>
> Kind regards
> Uffe
OK
How about this new patch?
Thanks,
Wan Jiabing