2023-06-09 12:12:56

by Arnd Bergmann

Subject: [PATCH] accel/habanalabs: add more debugfs stub helpers

From: Arnd Bergmann <[email protected]>

Two functions got added with normal prototypes for debugfs, but not
alternative when building without it:

drivers/accel/habanalabs/common/device.c: In function 'hl_device_init':
drivers/accel/habanalabs/common/device.c:2177:14: error: implicit declaration of function 'hl_debugfs_device_init'; did you mean 'hl_debugfs_init'? [-Werror=implicit-function-declaration]
drivers/accel/habanalabs/common/device.c:2305:9: error: implicit declaration of function 'hl_debugfs_device_fini'; did you mean 'hl_debugfs_remove_file'? [-Werror=implicit-function-declaration]

Add stubs for these as well.

Fixes: 553311fc7b76e ("accel/habanalabs: expose debugfs files later")
Signed-off-by: Arnd Bergmann <[email protected]>
---
drivers/accel/habanalabs/common/habanalabs.h | 9 +++++++++
1 file changed, 9 insertions(+)

diff --git a/drivers/accel/habanalabs/common/habanalabs.h b/drivers/accel/habanalabs/common/habanalabs.h
index d92ba2e30e310..2f027d5a82064 100644
--- a/drivers/accel/habanalabs/common/habanalabs.h
+++ b/drivers/accel/habanalabs/common/habanalabs.h
@@ -3980,6 +3980,15 @@ static inline void hl_debugfs_fini(void)
{
}

+static inline int hl_debugfs_device_init(struct hl_device *hdev)
+{
+ return 0;
+}
+
+static inline void hl_debugfs_device_fini(struct hl_device *hdev)
+{
+}
+
static inline void hl_debugfs_add_device(struct hl_device *hdev)
{
}
--
2.39.2

2023-06-09 13:53:21

by Tomer Tayar

Subject: Re: [PATCH] accel/habanalabs: add more debugfs stub helpers

On 09/06/2023 15:06, Arnd Bergmann wrote:
> From: Arnd Bergmann <[email protected]>
>
> Two functions got added with normal prototypes for debugfs, but not
> alternative when building without it:
>
> drivers/accel/habanalabs/common/device.c: In function 'hl_device_init':
> drivers/accel/habanalabs/common/device.c:2177:14: error: implicit declaration of function 'hl_debugfs_device_init'; did you mean 'hl_debugfs_init'? [-Werror=implicit-function-declaration]
> drivers/accel/habanalabs/common/device.c:2305:9: error: implicit declaration of function 'hl_debugfs_device_fini'; did you mean 'hl_debugfs_remove_file'? [-Werror=implicit-function-declaration]
>
> Add stubs for these as well.
>
> Fixes: 553311fc7b76e ("accel/habanalabs: expose debugfs files later")
> Signed-off-by: Arnd Bergmann <[email protected]>

Thanks,
Reviewed-by: Tomer Tayar <[email protected]>

> ---
> drivers/accel/habanalabs/common/habanalabs.h | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/accel/habanalabs/common/habanalabs.h b/drivers/accel/habanalabs/common/habanalabs.h
> index d92ba2e30e310..2f027d5a82064 100644
> --- a/drivers/accel/habanalabs/common/habanalabs.h
> +++ b/drivers/accel/habanalabs/common/habanalabs.h
> @@ -3980,6 +3980,15 @@ static inline void hl_debugfs_fini(void)
> {
> }
>
> +static inline int hl_debugfs_device_init(struct hl_device *hdev)
> +{
> + return 0;
> +}
> +
> +static inline void hl_debugfs_device_fini(struct hl_device *hdev)
> +{
> +}
> +
> static inline void hl_debugfs_add_device(struct hl_device *hdev)
> {
> }

2023-06-11 10:01:39

by Oded Gabbay

Subject: Re: [PATCH] accel/habanalabs: add more debugfs stub helpers

On Fri, Jun 9, 2023 at 4:37 PM Tomer Tayar <[email protected]> wrote:
>
> On 09/06/2023 15:06, Arnd Bergmann wrote:
> > From: Arnd Bergmann <[email protected]>
> >
> > Two functions got added with normal prototypes for debugfs, but not
> > alternative when building without it:
> >
> > drivers/accel/habanalabs/common/device.c: In function 'hl_device_init':
> > drivers/accel/habanalabs/common/device.c:2177:14: error: implicit declaration of function 'hl_debugfs_device_init'; did you mean 'hl_debugfs_init'? [-Werror=implicit-function-declaration]
> > drivers/accel/habanalabs/common/device.c:2305:9: error: implicit declaration of function 'hl_debugfs_device_fini'; did you mean 'hl_debugfs_remove_file'? [-Werror=implicit-function-declaration]
> >
> > Add stubs for these as well.
> >
> > Fixes: 553311fc7b76e ("accel/habanalabs: expose debugfs files later")
> > Signed-off-by: Arnd Bergmann <[email protected]>
>
> Thanks,
> Reviewed-by: Tomer Tayar <[email protected]>

Thanks,
Applied to -fixes.
Oded
>
> > ---
> > drivers/accel/habanalabs/common/habanalabs.h | 9 +++++++++
> > 1 file changed, 9 insertions(+)
> >
> > diff --git a/drivers/accel/habanalabs/common/habanalabs.h b/drivers/accel/habanalabs/common/habanalabs.h
> > index d92ba2e30e310..2f027d5a82064 100644
> > --- a/drivers/accel/habanalabs/common/habanalabs.h
> > +++ b/drivers/accel/habanalabs/common/habanalabs.h
> > @@ -3980,6 +3980,15 @@ static inline void hl_debugfs_fini(void)
> > {
> > }
> >
> > +static inline int hl_debugfs_device_init(struct hl_device *hdev)
> > +{
> > + return 0;
> > +}
> > +
> > +static inline void hl_debugfs_device_fini(struct hl_device *hdev)
> > +{
> > +}
> > +
> > static inline void hl_debugfs_add_device(struct hl_device *hdev)
> > {
> > }
>
>

2023-07-20 10:44:03

by Daniel Vetter

Subject: Re: [PATCH] accel/habanalabs: add more debugfs stub helpers

On Sun, Jun 11, 2023 at 12:50:31PM +0300, Oded Gabbay wrote:
> On Fri, Jun 9, 2023 at 4:37 PM Tomer Tayar <[email protected]> wrote:
> >
> > On 09/06/2023 15:06, Arnd Bergmann wrote:
> > > From: Arnd Bergmann <[email protected]>
> > >
> > > Two functions got added with normal prototypes for debugfs, but not
> > > alternative when building without it:
> > >
> > > drivers/accel/habanalabs/common/device.c: In function 'hl_device_init':
> > > drivers/accel/habanalabs/common/device.c:2177:14: error: implicit declaration of function 'hl_debugfs_device_init'; did you mean 'hl_debugfs_init'? [-Werror=implicit-function-declaration]
> > > drivers/accel/habanalabs/common/device.c:2305:9: error: implicit declaration of function 'hl_debugfs_device_fini'; did you mean 'hl_debugfs_remove_file'? [-Werror=implicit-function-declaration]
> > >
> > > Add stubs for these as well.
> > >
> > > Fixes: 553311fc7b76e ("accel/habanalabs: expose debugfs files later")
> > > Signed-off-by: Arnd Bergmann <[email protected]>
> >
> > Thanks,
> > Reviewed-by: Tomer Tayar <[email protected]>
>
> Thanks,
> Applied to -fixes.

As requested applied to drm-fixes, hopeful for the next one your drm-misc
account issue is fixed.
-Daniel

> Oded
> >
> > > ---
> > > drivers/accel/habanalabs/common/habanalabs.h | 9 +++++++++
> > > 1 file changed, 9 insertions(+)
> > >
> > > diff --git a/drivers/accel/habanalabs/common/habanalabs.h b/drivers/accel/habanalabs/common/habanalabs.h
> > > index d92ba2e30e310..2f027d5a82064 100644
> > > --- a/drivers/accel/habanalabs/common/habanalabs.h
> > > +++ b/drivers/accel/habanalabs/common/habanalabs.h
> > > @@ -3980,6 +3980,15 @@ static inline void hl_debugfs_fini(void)
> > > {
> > > }
> > >
> > > +static inline int hl_debugfs_device_init(struct hl_device *hdev)
> > > +{
> > > + return 0;
> > > +}
> > > +
> > > +static inline void hl_debugfs_device_fini(struct hl_device *hdev)
> > > +{
> > > +}
> > > +
> > > static inline void hl_debugfs_add_device(struct hl_device *hdev)
> > > {
> > > }
> >
> >

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

2023-07-20 11:37:33

by Oded Gabbay

Subject: Re: [PATCH] accel/habanalabs: add more debugfs stub helpers

On Thu, Jul 20, 2023 at 1:29 PM Daniel Vetter <[email protected]> wrote:
>
> On Sun, Jun 11, 2023 at 12:50:31PM +0300, Oded Gabbay wrote:
> > On Fri, Jun 9, 2023 at 4:37 PM Tomer Tayar <[email protected]> wrote:
> > >
> > > On 09/06/2023 15:06, Arnd Bergmann wrote:
> > > > From: Arnd Bergmann <[email protected]>
> > > >
> > > > Two functions got added with normal prototypes for debugfs, but not
> > > > alternative when building without it:
> > > >
> > > > drivers/accel/habanalabs/common/device.c: In function 'hl_device_init':
> > > > drivers/accel/habanalabs/common/device.c:2177:14: error: implicit declaration of function 'hl_debugfs_device_init'; did you mean 'hl_debugfs_init'? [-Werror=implicit-function-declaration]
> > > > drivers/accel/habanalabs/common/device.c:2305:9: error: implicit declaration of function 'hl_debugfs_device_fini'; did you mean 'hl_debugfs_remove_file'? [-Werror=implicit-function-declaration]
> > > >
> > > > Add stubs for these as well.
> > > >
> > > > Fixes: 553311fc7b76e ("accel/habanalabs: expose debugfs files later")
> > > > Signed-off-by: Arnd Bergmann <[email protected]>
> > >
> > > Thanks,
> > > Reviewed-by: Tomer Tayar <[email protected]>
> >
> > Thanks,
> > Applied to -fixes.
>
> As requested applied to drm-fixes, hopeful for the next one your drm-misc
> account issue is fixed.
> -Daniel

Thanks Daniel for the help.
I also hope it will be fixed :)
Oded

>
> > Oded
> > >
> > > > ---
> > > > drivers/accel/habanalabs/common/habanalabs.h | 9 +++++++++
> > > > 1 file changed, 9 insertions(+)
> > > >
> > > > diff --git a/drivers/accel/habanalabs/common/habanalabs.h b/drivers/accel/habanalabs/common/habanalabs.h
> > > > index d92ba2e30e310..2f027d5a82064 100644
> > > > --- a/drivers/accel/habanalabs/common/habanalabs.h
> > > > +++ b/drivers/accel/habanalabs/common/habanalabs.h
> > > > @@ -3980,6 +3980,15 @@ static inline void hl_debugfs_fini(void)
> > > > {
> > > > }
> > > >
> > > > +static inline int hl_debugfs_device_init(struct hl_device *hdev)
> > > > +{
> > > > + return 0;
> > > > +}
> > > > +
> > > > +static inline void hl_debugfs_device_fini(struct hl_device *hdev)
> > > > +{
> > > > +}
> > > > +
> > > > static inline void hl_debugfs_add_device(struct hl_device *hdev)
> > > > {
> > > > }
> > >
> > >
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch