On 3/25/09, Marcel Holtmann <[email protected]> wrote:
> Hi Nick,
>
> > +
> > + if ((cap->category == AVDTP_MEDIA_TRANSPORT) &&
> > (cap->length != 0)) {
> > + err = AVDTP_BAD_MEDIA_TRANSPORT_FORMAT;
> > + goto failed;
>
> no need to put brackets around cap->cat == ... check etc. The comparison
> takes precedence over &&. Please fix and re-send the patch.
fixed
Hi Nick,
> +
> + if ((cap->category == AVDTP_MEDIA_TRANSPORT) &&
> (cap->length != 0)) {
> + err = AVDTP_BAD_MEDIA_TRANSPORT_FORMAT;
> + goto failed;
no need to put brackets around cap->cat == ... check etc. The comparison
takes precedence over &&. Please fix and re-send the patch.
Regards
Marcel