2009-03-26 23:51:49

by Nick Pelly

[permalink] [raw]
Subject: [PATCH] AVDTP Qualification: Fix error handling for AVDTP set configuration command


Attachments:
0005-AVDTP-Qualification-Fix-error-handling-for-AVDTP-se.patch (1.34 kB)

2009-03-27 00:43:10

by Nick Pelly

[permalink] [raw]
Subject: Re: [PATCH] AVDTP Qualification: Fix error handling for AVDTP set configuration command

On 3/25/09, Marcel Holtmann <[email protected]> wrote:
> Hi Nick,
>
> > +
> > + if ((cap->category == AVDTP_MEDIA_TRANSPORT) &&
> > (cap->length != 0)) {
> > + err = AVDTP_BAD_MEDIA_TRANSPORT_FORMAT;
> > + goto failed;
>
> no need to put brackets around cap->cat == ... check etc. The comparison
> takes precedence over &&. Please fix and re-send the patch.

fixed

Attachments:
0005-AVDTP-Qualification-Fix-error-handling-for-AVDTP-se.patch (1.34 kB)

2009-03-25 23:01:36

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [PATCH] AVDTP Qualification: Fix error handling for AVDTP set configuration command

Hi Nick,

> +
> + if ((cap->category == AVDTP_MEDIA_TRANSPORT) &&
> (cap->length != 0)) {
> + err = AVDTP_BAD_MEDIA_TRANSPORT_FORMAT;
> + goto failed;

no need to put brackets around cap->cat == ... check etc. The comparison
takes precedence over &&. Please fix and re-send the patch.

Regards

Marcel