2015-05-29 08:09:19

by Andrei Emeltchenko

Subject: [PATCH] shared/att: Fix boolean check in handle_notify()

From: Andrei Emeltchenko <[email protected]>

ext_signed is boolean and shall be checked with logical op.
---
src/shared/att.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/shared/att.c b/src/shared/att.c
index 053aa47..a3d8f89 100644
--- a/src/shared/att.c
+++ b/src/shared/att.c
@@ -733,7 +733,7 @@ static void handle_notify(struct bt_att *att, uint8_t opcode, uint8_t *pdu,
const struct queue_entry *entry;
bool found;

- if (opcode & ATT_OP_SIGNED_MASK & !att->ext_signed) {
+ if (opcode & ATT_OP_SIGNED_MASK && !att->ext_signed) {
if (!handle_signed(att, opcode, pdu, pdu_len))
return;
pdu_len -= BT_ATT_SIGNATURE_LEN;
--
2.1.4

2015-05-29 08:53:26

by Andrei Emeltchenko

Subject: [PATCHv2] shared/att: Fix boolean check in handle_notify()

From: Andrei Emeltchenko <[email protected]>

ext_signed is boolean and shall be checked with logical op.
---
src/shared/att.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/shared/att.c b/src/shared/att.c
index 053aa47..f9a5817 100644
--- a/src/shared/att.c
+++ b/src/shared/att.c
@@ -733,7 +733,7 @@ static void handle_notify(struct bt_att *att, uint8_t opcode, uint8_t *pdu,
const struct queue_entry *entry;
bool found;

- if (opcode & ATT_OP_SIGNED_MASK & !att->ext_signed) {
+ if ((opcode & ATT_OP_SIGNED_MASK) && !att->ext_signed) {
if (!handle_signed(att, opcode, pdu, pdu_len))
return;
pdu_len -= BT_ATT_SIGNATURE_LEN;
--
2.1.4

2015-05-29 08:39:01

by Luiz Augusto von Dentz

Subject: Re: [PATCH] shared/att: Fix boolean check in handle_notify()

Hi Andrei,

On Fri, May 29, 2015 at 11:09 AM, Andrei Emeltchenko
<[email protected]> wrote:
> From: Andrei Emeltchenko <[email protected]>
>
> ext_signed is boolean and shall be checked with logical op.
> ---
> src/shared/att.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/shared/att.c b/src/shared/att.c
> index 053aa47..a3d8f89 100644
> --- a/src/shared/att.c
> +++ b/src/shared/att.c
> @@ -733,7 +733,7 @@ static void handle_notify(struct bt_att *att, uint8_t opcode, uint8_t *pdu,
> const struct queue_entry *entry;
> bool found;
>
> - if (opcode & ATT_OP_SIGNED_MASK & !att->ext_signed) {
> + if (opcode & ATT_OP_SIGNED_MASK && !att->ext_signed) {

I guess adding (opcode & ATT_OP_SIGNED_MASK) would make this even more clearer.

> if (!handle_signed(att, opcode, pdu, pdu_len))
> return;
> pdu_len -= BT_ATT_SIGNATURE_LEN;
> --
> 2.1.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html



--
Luiz Augusto von Dentz

2015-06-05 14:41:36

by Luiz Augusto von Dentz

Subject: Re: [PATCHv2] shared/att: Fix boolean check in handle_notify()

Hi Andrei,

On Fri, Jun 5, 2015 at 4:00 PM, Andrei Emeltchenko
<[email protected]> wrote:
> ping
>
> On Mon, Jun 01, 2015 at 01:11:43PM +0300, Andrei Emeltchenko wrote:
>> ping
>>
>> On Fri, May 29, 2015 at 11:53:26AM +0300, Andrei Emeltchenko wrote:
>> > From: Andrei Emeltchenko <[email protected]>
>> >
>> > ext_signed is boolean and shall be checked with logical op.
>> > ---
>> > src/shared/att.c | 2 +-
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/src/shared/att.c b/src/shared/att.c
>> > index 053aa47..f9a5817 100644
>> > --- a/src/shared/att.c
>> > +++ b/src/shared/att.c
>> > @@ -733,7 +733,7 @@ static void handle_notify(struct bt_att *att, uint8_t opcode, uint8_t *pdu,
>> > const struct queue_entry *entry;
>> > bool found;
>> >
>> > - if (opcode & ATT_OP_SIGNED_MASK & !att->ext_signed) {
>> > + if ((opcode & ATT_OP_SIGNED_MASK) && !att->ext_signed) {
>> > if (!handle_signed(att, opcode, pdu, pdu_len))
>> > return;
>> > pdu_len -= BT_ATT_SIGNATURE_LEN;
>> > --
>> > 2.1.4
>> >
>> > --
>> > To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
>> > the body of a message to [email protected]
>> > More majordomo info at http://vger.kernel.org/majordomo-info.html
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
>> the body of a message to [email protected]
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
> --

Applied, thanks.


--
Luiz Augusto von Dentz

2015-06-05 13:00:06

by Andrei Emeltchenko

Subject: Re: [PATCHv2] shared/att: Fix boolean check in handle_notify()

ping

On Mon, Jun 01, 2015 at 01:11:43PM +0300, Andrei Emeltchenko wrote:
> ping
>
> On Fri, May 29, 2015 at 11:53:26AM +0300, Andrei Emeltchenko wrote:
> > From: Andrei Emeltchenko <[email protected]>
> >
> > ext_signed is boolean and shall be checked with logical op.
> > ---
> > src/shared/att.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/shared/att.c b/src/shared/att.c
> > index 053aa47..f9a5817 100644
> > --- a/src/shared/att.c
> > +++ b/src/shared/att.c
> > @@ -733,7 +733,7 @@ static void handle_notify(struct bt_att *att, uint8_t opcode, uint8_t *pdu,
> > const struct queue_entry *entry;
> > bool found;
> >
> > - if (opcode & ATT_OP_SIGNED_MASK & !att->ext_signed) {
> > + if ((opcode & ATT_OP_SIGNED_MASK) && !att->ext_signed) {
> > if (!handle_signed(att, opcode, pdu, pdu_len))
> > return;
> > pdu_len -= BT_ATT_SIGNATURE_LEN;
> > --
> > 2.1.4
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> > the body of a message to [email protected]
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html

2015-06-01 10:11:43

by Andrei Emeltchenko

Subject: Re: [PATCHv2] shared/att: Fix boolean check in handle_notify()

ping

On Fri, May 29, 2015 at 11:53:26AM +0300, Andrei Emeltchenko wrote:
> From: Andrei Emeltchenko <[email protected]>
>
> ext_signed is boolean and shall be checked with logical op.
> ---
> src/shared/att.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/shared/att.c b/src/shared/att.c
> index 053aa47..f9a5817 100644
> --- a/src/shared/att.c
> +++ b/src/shared/att.c
> @@ -733,7 +733,7 @@ static void handle_notify(struct bt_att *att, uint8_t opcode, uint8_t *pdu,
> const struct queue_entry *entry;
> bool found;
>
> - if (opcode & ATT_OP_SIGNED_MASK & !att->ext_signed) {
> + if ((opcode & ATT_OP_SIGNED_MASK) && !att->ext_signed) {
> if (!handle_signed(att, opcode, pdu, pdu_len))
> return;
> pdu_len -= BT_ATT_SIGNATURE_LEN;
> --
> 2.1.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html