2022-02-08 18:41:11

by Sai Teja Aluvala

[permalink] [raw]
Subject: [PATCH v2] arm64: dts: qcom: sc7280: setting the vddio supply for Bluetooth node on CRD

setting the vddio supply for Bluetooth SoC WCN6750 node
on SC7280 crd board

Signed-off-by: Sai Teja Aluvala <[email protected]>
---
arch/arm64/boot/dts/qcom/sc7280-crd.dts | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sc7280-crd.dts b/arch/arm64/boot/dts/qcom/sc7280-crd.dts
index cd2755c..53ea3b4 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-crd.dts
+++ b/arch/arm64/boot/dts/qcom/sc7280-crd.dts
@@ -23,6 +23,10 @@
};
};

+&bluetooth {
+ vddio-supply = <&vreg_l18b_1p8>;
+};
+
ap_tp_i2c: &i2c0 {
status = "okay";
clock-frequency = <400000>;
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc.



2022-02-09 10:43:33

by bluez.test.bot

[permalink] [raw]
Subject: RE: [v2] arm64: dts: qcom: sc7280: setting the vddio supply for Bluetooth node on CRD

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=612157

---Test result---

Test Summary:
CheckPatch PASS 0.71 seconds
GitLint FAIL 0.45 seconds
SubjectPrefix FAIL 0.25 seconds
BuildKernel PASS 37.92 seconds
BuildKernel32 PASS 33.43 seconds
Incremental Build with patchesPASS 43.83 seconds
TestRunner: Setup PASS 600.88 seconds
TestRunner: l2cap-tester PASS 15.78 seconds
TestRunner: bnep-tester PASS 6.85 seconds
TestRunner: mgmt-tester PASS 124.22 seconds
TestRunner: rfcomm-tester PASS 8.51 seconds
TestRunner: sco-tester PASS 8.80 seconds
TestRunner: smp-tester PASS 8.71 seconds
TestRunner: userchan-tester PASS 7.12 seconds

Details
##############################
Test: GitLint - FAIL - 0.45 seconds
Run gitlint with rule in .gitlint
[v2] arm64: dts: qcom: sc7280: setting the vddio supply for Bluetooth node on CRD
1: T1 Title exceeds max length (81>80): "[v2] arm64: dts: qcom: sc7280: setting the vddio supply for Bluetooth node on CRD"


##############################
Test: SubjectPrefix - FAIL - 0.25 seconds
Check subject contains "Bluetooth" prefix
"Bluetooth: " is not specified in the subject



---
Regards,
Linux Bluetooth

2022-02-11 14:32:52

by Sai Teja Aluvala

[permalink] [raw]
Subject: RE: [PATCH v2] arm64: dts: qcom: sc7280: setting the vddio supply for Bluetooth node on CRD



-----Original Message-----
From: Bjorn Andersson <[email protected]>
Sent: Friday, February 11, 2022 6:09 AM
To: Sai Teja Aluvala (Temp) (QUIC) <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; Hemant Gupta (QUIC) <[email protected]>; [email protected]; quic_bgodavar <[email protected]>; quic_rjliao <[email protected]>; quic_hbandi <[email protected]>; [email protected]; [email protected]
Subject: Re: [PATCH v2] arm64: dts: qcom: sc7280: setting the vddio supply for Bluetooth node on CRD

On Tue 08 Feb 05:13 CST 2022, Sai Teja Aluvala wrote:

> setting the vddio supply for Bluetooth SoC WCN6750 node on SC7280 crd
> board
>

While this does better describe what the change does, as Matthias requested on v1, it fails to provide any information about why this done.

Is vddio simply not powered on the IDP? Or did someone forget to add it to the idp.dtsi?
[Sai]: Vddio regulator handle is different for IDP and IDP2. So in common dtsi file i.e. sc7280-idp.dtsi we haven't enabled vddio instead we have add the regulator handle in board specific dts file.
So for CRD too we are adding it in the sc7280-crd.dts file.


Regards,
Bjorn

> Signed-off-by: Sai Teja Aluvala <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/sc7280-crd.dts | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-crd.dts
> b/arch/arm64/boot/dts/qcom/sc7280-crd.dts
> index cd2755c..53ea3b4 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-crd.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7280-crd.dts
> @@ -23,6 +23,10 @@
> };
> };
>
> +&bluetooth {
> + vddio-supply = <&vreg_l18b_1p8>;
> +};
> +
> ap_tp_i2c: &i2c0 {
> status = "okay";
> clock-frequency = <400000>;
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc.
>