2019-04-24 09:15:20

by Amit K Bag

Subject: [PATCH] Bluetooth: btintel: improvement: mask vendor events from controller

This patch mask unnecessary event notifications from controller to host

Signed-off-by: Amit K Bag <[email protected]>
---
drivers/bluetooth/btintel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
index 5270d5513201..7e5cdd37cc1f 100644
--- a/drivers/bluetooth/btintel.c
+++ b/drivers/bluetooth/btintel.c
@@ -313,7 +313,7 @@ EXPORT_SYMBOL_GPL(btintel_load_ddc_config);

int btintel_set_event_mask(struct hci_dev *hdev, bool debug)
{
- u8 mask[8] = { 0x87, 0x0c, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 };
+ u8 mask[8] = { 0x01, 0x0c, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 };
struct sk_buff *skb;
int err;

--
2.7.4

2019-04-24 10:26:52

by Marcel Holtmann

Subject: Re: [PATCH] Bluetooth: btintel: improvement: mask vendor events from controller

Hi Amit,

> This patch mask unnecessary event notifications from controller to host
>
> Signed-off-by: Amit K Bag <[email protected]>
> ---
> drivers/bluetooth/btintel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
> index 5270d5513201..7e5cdd37cc1f 100644
> --- a/drivers/bluetooth/btintel.c
> +++ b/drivers/bluetooth/btintel.c
> @@ -313,7 +313,7 @@ EXPORT_SYMBOL_GPL(btintel_load_ddc_config);
>
> int btintel_set_event_mask(struct hci_dev *hdev, bool debug)
> {
> - u8 mask[8] = { 0x87, 0x0c, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 };
> + u8 mask[8] = { 0x01, 0x0c, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00 };
> struct sk_buff *skb;
> int err;

so I enabled actually many more events to ensure we get proper output in btmon in case something happens. So you need to be more specific why we want to not enable these events for our hardware.

Regards

Marcel