2019-04-30 10:30:34

by Michał Lowas-Rzechonek

Subject: [PATCH v2] a2dp: Fixed warn_unused_result warning

This used to break builds when using maintainer mode via
./bootstrap-configure:

profiles/audio/a2dp.c:1775:2: error: ignoring return value of
‘asprintf’, declared with attribute warn_unused_result
[-Werror=unused-result]
asprintf(&sep->path, "%s/sep%d",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
---
profiles/audio/a2dp.c | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/profiles/audio/a2dp.c b/profiles/audio/a2dp.c
index 8f141739c..5f5ad508d 100644
--- a/profiles/audio/a2dp.c
+++ b/profiles/audio/a2dp.c
@@ -1772,8 +1772,15 @@ static void register_remote_sep(void *data, void *user_data)
if (!(g_dbus_get_flags() & G_DBUS_FLAG_ENABLE_EXPERIMENTAL))
goto done;

- asprintf(&sep->path, "%s/sep%d", device_get_path(chan->device),
- avdtp_get_seid(rsep));
+ if (asprintf(&sep->path, "%s/sep%d",
+ device_get_path(chan->device),
+ avdtp_get_seid(rsep)) < 0) {
+ error("Could not allocate path for remote sep %s/sep%d",
+ device_get_path(chan->device),
+ avdtp_get_seid(rsep));
+ sep->path = NULL;
+ goto done;
+ }

if (g_dbus_register_interface(btd_get_dbus_connection(),
sep->path, MEDIA_ENDPOINT_INTERFACE,
--
2.19.1

2019-04-30 12:43:45

by Luiz Augusto von Dentz

Subject: Re: [PATCH v2] a2dp: Fixed warn_unused_result warning

Hi Michał,

On Tue, Apr 30, 2019 at 1:31 PM Michał Lowas-Rzechonek
<[email protected]> wrote:
>
> This used to break builds when using maintainer mode via
> ./bootstrap-configure:
>
> profiles/audio/a2dp.c:1775:2: error: ignoring return value of
> ‘asprintf’, declared with attribute warn_unused_result
> [-Werror=unused-result]
> asprintf(&sep->path, "%s/sep%d",
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ---
> profiles/audio/a2dp.c | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/profiles/audio/a2dp.c b/profiles/audio/a2dp.c
> index 8f141739c..5f5ad508d 100644
> --- a/profiles/audio/a2dp.c
> +++ b/profiles/audio/a2dp.c
> @@ -1772,8 +1772,15 @@ static void register_remote_sep(void *data, void *user_data)
> if (!(g_dbus_get_flags() & G_DBUS_FLAG_ENABLE_EXPERIMENTAL))
> goto done;
>
> - asprintf(&sep->path, "%s/sep%d", device_get_path(chan->device),
> - avdtp_get_seid(rsep));
> + if (asprintf(&sep->path, "%s/sep%d",
> + device_get_path(chan->device),
> + avdtp_get_seid(rsep)) < 0) {
> + error("Could not allocate path for remote sep %s/sep%d",
> + device_get_path(chan->device),
> + avdtp_get_seid(rsep));
> + sep->path = NULL;
> + goto done;
> + }
>
> if (g_dbus_register_interface(btd_get_dbus_connection(),
> sep->path, MEDIA_ENDPOINT_INTERFACE,
> --
> 2.19.1

Applied, thanks.

--
Luiz Augusto von Dentz