2019-06-19 07:49:17

by Jakub Witowski

[permalink] [raw]
Subject: [PATCH v2] mesh: Return dbus error code on Leave() with invalit token given

This removes NotFound error from mesh-api.txt from Leave() function.
---
doc/mesh-api.txt | 2 --
1 file changed, 2 deletions(-)

diff --git a/doc/mesh-api.txt b/doc/mesh-api.txt
index 2a800468b..c82732d2c 100644
--- a/doc/mesh-api.txt
+++ b/doc/mesh-api.txt
@@ -112,8 +112,6 @@ Methods:
identified by the 64-bit token parameter. The token parameter
has been obtained as a result of successful Join() method call.

- PossibleErrors:
- org.bluez.mesh.Error.NotFound

uint64 token CreateNetwork(object app_root, array{byte}[16] uuid)

--
2.20.1


2019-06-19 08:33:06

by Grzegorz Kołodziejczyk

[permalink] [raw]
Subject: Re: [PATCH v2] mesh: Return dbus error code on Leave() with invalit token given

Hi Jakub,

You have commit message typo "invalit".


śr., 19 cze 2019 o 09:49 Jakub Witowski <[email protected]> napisał(a):
>
> This removes NotFound error from mesh-api.txt from Leave() function.
btw. what is the purpose of this patch (or why is this needed) ? since
commit message describes what can be easily read from code diff.
> ---
> doc/mesh-api.txt | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/doc/mesh-api.txt b/doc/mesh-api.txt
> index 2a800468b..c82732d2c 100644
> --- a/doc/mesh-api.txt
> +++ b/doc/mesh-api.txt
> @@ -112,8 +112,6 @@ Methods:
> identified by the 64-bit token parameter. The token parameter
> has been obtained as a result of successful Join() method call.
>
> - PossibleErrors:
> - org.bluez.mesh.Error.NotFound
>
> uint64 token CreateNetwork(object app_root, array{byte}[16] uuid)
>
> --
> 2.20.1
>
Regards,
Grzegorz

2019-06-19 17:46:11

by Michał Lowas-Rzechonek

[permalink] [raw]
Subject: Re: [PATCH v2] mesh: Return dbus error code on Leave() with invalit token given

Hi Grzegorz,

On 06/19, Grzegorz Kołodziejczyk wrote:
> You have commit message typo "invalit".

And you top-post ;)

--
Michał Lowas-Rzechonek <[email protected]>
Silvair http://silvair.com
Jasnogórska 44, 31-358 Krakow, POLAND