2020-01-16 16:39:46

by Gix, Brian

Subject: [PATCH BlueZ v3 0/1] mesh: Sequence number related fixes

Version 3 -
Adjusted comments for clarity, and adjusted the cache-write code
to not rewrite the NVM storage if nothing has changed, to prevent
NVM thrashing if we do reach the out-of-range boundary.

I would like both Michal and Jakub's comments on these adjustments.

Jakub Witowski (1):
mesh: Sequence number related fixes

mesh/crypto.c | 3 +++
mesh/mesh-config-json.c | 16 ++++++++++++++--
mesh/net.c | 9 +++++++++
3 files changed, 26 insertions(+), 2 deletions(-)

--
2.21.1

2020-01-16 18:17:25

by Michał Lowas-Rzechonek

Subject: Re: [PATCH BlueZ v3 0/1] mesh: Sequence number related fixes

Brian, Jakub,

On 01/16, Brian Gix wrote:
> Adjusted comments for clarity,

Thank you.

> and adjusted the cache-write code to not rewrite the NVM storage if
> nothing has changed, to prevent NVM thrashing if we do reach the
> out-of-range boundary

True.

> I would like both Michal and Jakub's comments on these adjustments.

Thanks again, LGTM.

--
Michał Lowas-Rzechonek <[email protected]>
Silvair http://silvair.com
Jasnogórska 44, 31-358 Krakow, POLAND

2020-01-16 23:25:04

by Gix, Brian

Subject: Re: [PATCH BlueZ v3 0/1] mesh: Sequence number related fixes

Applied
On Thu, 2020-01-16 at 08:39 -0800, Brian Gix wrote:
> Version 3 -
> Adjusted comments for clarity, and adjusted the cache-write code
> to not rewrite the NVM storage if nothing has changed, to prevent
> NVM thrashing if we do reach the out-of-range boundary.
>
> I would like both Michal and Jakub's comments on these adjustments.
>
> Jakub Witowski (1):
> mesh: Sequence number related fixes
>
> mesh/crypto.c | 3 +++
> mesh/mesh-config-json.c | 16 ++++++++++++++--
> mesh/net.c | 9 +++++++++
> 3 files changed, 26 insertions(+), 2 deletions(-)
>