2021-06-18 07:54:48

by Manish Mandlik

Subject: [BlueZ PATCH v1] adv_monitor: Avoid skipping non-discoverable dev on Monitor match

Do no skip a non-discoverable device if it matches any Advertisement
Monitor.

Reviewed-by: [email protected]
Reviewed-by: [email protected]
Signed-off-by: Manish Mandlik <[email protected]>
---

src/adapter.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/adapter.c b/src/adapter.c
index 98fc78f1e..2175120f4 100644
--- a/src/adapter.c
+++ b/src/adapter.c
@@ -6656,7 +6656,7 @@ static void update_found_devices(struct btd_adapter *adapter,

dev = btd_adapter_find_device(adapter, bdaddr, bdaddr_type);
if (!dev) {
- if (!discoverable) {
+ if (!discoverable && !matched_monitors) {
eir_data_free(&eir_data);
return;
}
--
2.32.0.288.g62a8d224e6-goog

2021-06-24 20:14:35

by Luiz Augusto von Dentz

Subject: Re: [BlueZ PATCH v1] adv_monitor: Avoid skipping non-discoverable dev on Monitor match

Hi Manish,

On Thu, Jun 24, 2021 at 10:10 AM Manish Mandlik <[email protected]> wrote:
>
> Friendly reminder to review this patch.
>
> Regards,
> Manish.
>
>
> On Thu, Jun 17, 2021 at 9:58 PM Manish Mandlik <[email protected]> wrote:
>>
>> Do no skip a non-discoverable device if it matches any Advertisement
>> Monitor.
>>
>> Reviewed-by: [email protected]
>> Reviewed-by: [email protected]
>> Signed-off-by: Manish Mandlik <[email protected]>
>> ---
>>
>> src/adapter.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/adapter.c b/src/adapter.c
>> index 98fc78f1e..2175120f4 100644
>> --- a/src/adapter.c
>> +++ b/src/adapter.c
>> @@ -6656,7 +6656,7 @@ static void update_found_devices(struct btd_adapter *adapter,
>>
>> dev = btd_adapter_find_device(adapter, bdaddr, bdaddr_type);
>> if (!dev) {
>> - if (!discoverable) {
>> + if (!discoverable && !matched_monitors) {
>> eir_data_free(&eir_data);
>> return;
>> }
>> --
>> 2.32.0.288.g62a8d224e6-goog
>>

Applied, thanks.

--
Luiz Augusto von Dentz