btqcomsmd.c hasn't use any macro or function declared in linux/of.h
and linux/slab.h.
Thus, these files can be removed from btqcomsmd.c safely without
affecting the compilation of the ./drivers/bluetooth module
Signed-off-by: Mianhan Liu <[email protected]>
---
drivers/bluetooth/btqcomsmd.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/bluetooth/btqcomsmd.c b/drivers/bluetooth/btqcomsmd.c
index 2acb719e5..e556d96a4 100644
--- a/drivers/bluetooth/btqcomsmd.c
+++ b/drivers/bluetooth/btqcomsmd.c
@@ -5,9 +5,7 @@
*/
#include <linux/module.h>
-#include <linux/slab.h>
#include <linux/rpmsg.h>
-#include <linux/of.h>
#include <linux/soc/qcom/wcnss_ctrl.h>
#include <linux/platform_device.h>
--
2.25.1
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=554499
---Test result---
Test Summary:
CheckPatch PASS 1.54 seconds
GitLint FAIL 0.87 seconds
BuildKernel PASS 685.92 seconds
TestRunner: Setup PASS 502.05 seconds
TestRunner: l2cap-tester PASS 11.37 seconds
TestRunner: bnep-tester PASS 6.01 seconds
TestRunner: mgmt-tester PASS 93.65 seconds
TestRunner: rfcomm-tester PASS 7.35 seconds
TestRunner: sco-tester PASS 7.84 seconds
TestRunner: smp-tester PASS 7.50 seconds
TestRunner: userchan-tester PASS 6.30 seconds
Details
##############################
Test: GitLint - FAIL - 0.87 seconds
Run gitlint with rule in .gitlint
[-next,-v2] ./drivers/bluetooth/btqcomsmd.c: remove superfluous header files from btqcomsmd.c
1: T1 Title exceeds max length (93>80): "[-next,-v2] ./drivers/bluetooth/btqcomsmd.c: remove superfluous header files from btqcomsmd.c"
---
Regards,
Linux Bluetooth
On Tue 28 Sep 13:08 PDT 2021, Mianhan Liu wrote:
If you run a "git log --oneline -- drivers/bluetooth/btqcomsmd.c" you
will see that the appropriate prefix would be "Bluetooth: btqcomsmd: "
In other words, a better $subject would be:
[PATCH v2] Bluetooth: btqcomsmd: remove superfluous includes
> btqcomsmd.c hasn't use any macro or function declared in linux/of.h
> and linux/slab.h.
> Thus, these files can be removed from btqcomsmd.c safely without
> affecting the compilation of the ./drivers/bluetooth module
>
> Signed-off-by: Mianhan Liu <[email protected]>
>
> ---
Here is an excellent place to state "Changes since v1" and mention that
you no longer remove btqca.h and you added your S-o-b.
> drivers/bluetooth/btqcomsmd.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/bluetooth/btqcomsmd.c b/drivers/bluetooth/btqcomsmd.c
> index 2acb719e5..e556d96a4 100644
> --- a/drivers/bluetooth/btqcomsmd.c
> +++ b/drivers/bluetooth/btqcomsmd.c
> @@ -5,9 +5,7 @@
> */
>
> #include <linux/module.h>
> -#include <linux/slab.h>
> #include <linux/rpmsg.h>
> -#include <linux/of.h>
>
This looks reasonable.
Regards,
Bjorn
> #include <linux/soc/qcom/wcnss_ctrl.h>
> #include <linux/platform_device.h>
> --
> 2.25.1
>
>