2021-10-02 18:24:25

by Tedd Ho-Jeong An

Subject: [RFC PATCH] Bluetooth: hci_vhci: Fix to set force_wakeup value

From: Tedd Ho-Jeong An <[email protected]>

This patch sets the wakeup value in the vhci driver data after reading
the value.

Signed-off-by: Tedd Ho-Jeong An <[email protected]>
---
drivers/bluetooth/hci_vhci.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/bluetooth/hci_vhci.c b/drivers/bluetooth/hci_vhci.c
index b45db0db347c..5fd91106e853 100644
--- a/drivers/bluetooth/hci_vhci.c
+++ b/drivers/bluetooth/hci_vhci.c
@@ -176,6 +176,8 @@ static ssize_t force_wakeup_write(struct file *file,
if (data->wakeup == enable)
return -EALREADY;

+ data->wakeup = enable;
+
return count;
}

--
2.25.1

2021-10-02 21:04:08

by Marcel Holtmann

Subject: Re: [RFC PATCH] Bluetooth: hci_vhci: Fix to set force_wakeup value

Hi Tedd,

> This patch sets the wakeup value in the vhci driver data after reading
> the value.
>
> Signed-off-by: Tedd Ho-Jeong An <[email protected]>
> ---
> drivers/bluetooth/hci_vhci.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/bluetooth/hci_vhci.c b/drivers/bluetooth/hci_vhci.c
> index b45db0db347c..5fd91106e853 100644
> --- a/drivers/bluetooth/hci_vhci.c
> +++ b/drivers/bluetooth/hci_vhci.c
> @@ -176,6 +176,8 @@ static ssize_t force_wakeup_write(struct file *file,
> if (data->wakeup == enable)
> return -EALREADY;
>
> + data->wakeup = enable;
> +
> return count;

patch looks good, but the commit message is confusing.

Regards

Marcel

2021-10-04 23:53:03

by Luiz Augusto von Dentz

Subject: Re: [RFC PATCH] Bluetooth: hci_vhci: Fix to set force_wakeup value

Hi Marcel, Tedd,

On Sat, Oct 2, 2021 at 2:04 PM Marcel Holtmann <[email protected]> wrote:
>
> Hi Tedd,
>
> > This patch sets the wakeup value in the vhci driver data after reading
> > the value.
> >
> > Signed-off-by: Tedd Ho-Jeong An <[email protected]>
> > ---
> > drivers/bluetooth/hci_vhci.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/bluetooth/hci_vhci.c b/drivers/bluetooth/hci_vhci.c
> > index b45db0db347c..5fd91106e853 100644
> > --- a/drivers/bluetooth/hci_vhci.c
> > +++ b/drivers/bluetooth/hci_vhci.c
> > @@ -176,6 +176,8 @@ static ssize_t force_wakeup_write(struct file *file,
> > if (data->wakeup == enable)
> > return -EALREADY;
> >
> > + data->wakeup = enable;
> > +
> > return count;
>
> patch looks good, but the commit message is confusing.

Ive ended up fixing the original patch since I had to force push due
to the pull request problem with committer/sign-off problem.

> Regards
>
> Marcel
>


--
Luiz Augusto von Dentz