2023-07-17 06:05:47

by joeyli

[permalink] [raw]
Subject: Re: [PATCH] Bluetooth: hci_event: Ignore NULL link key in hci_link_key_notify_evt()

Hi Markus,

Thanks for your review!

On Fri, Jul 14, 2023 at 10:30:17PM +0200, Markus Elfring wrote:
> …
> > We can ignore null link key in the handler of "Link Key Notification
> > event" to relieve the attack. …
>
> Are imperative change descriptions still preferred?
>
> See also:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.5-rc1#n94
>
>
> How do you think about to add the tag “Fixes” because of
> an added case distinction?
>

Sorry for I didn't capture your point. The "Link Key Notification event"
is a term in bluetooth-core spec. What should I change in my patch
description?

Thanks a lot!
Joey Le