2023-10-03 14:49:48

by Iulia Tanasescu

[permalink] [raw]
Subject: [PATCH 0/1] Bluetooth: ISO: Allow binding a bcast listener to 0 bises

Some Broadcast scenarios require for a broadcast listener to listen for
a broadcaster only for PA sync.

This patch adds support for binding to a broadcaster address without
asking for any BIS to sync with.

Iulia Tanasescu (1):
Bluetooth: ISO: Allow binding a bcast listener to 0 bises

net/bluetooth/hci_conn.c | 2 +-
net/bluetooth/iso.c | 3 +--
2 files changed, 2 insertions(+), 3 deletions(-)


base-commit: 091e25d6b54992d1d702ae91cbac139d4c243251
--
2.39.2


2023-10-03 14:49:52

by Iulia Tanasescu

[permalink] [raw]
Subject: [PATCH 1/1] Bluetooth: ISO: Allow binding a bcast listener to 0 bises

This makes it possible to bind a broadcast listener to a broadcaster
address without asking for any BIS indexes to sync with.

Signed-off-by: Iulia Tanasescu <[email protected]>
---
net/bluetooth/hci_conn.c | 2 +-
net/bluetooth/iso.c | 3 +--
2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/net/bluetooth/hci_conn.c b/net/bluetooth/hci_conn.c
index e62a5f368a51..c4395d34da70 100644
--- a/net/bluetooth/hci_conn.c
+++ b/net/bluetooth/hci_conn.c
@@ -2138,7 +2138,7 @@ int hci_le_big_create_sync(struct hci_dev *hdev, struct hci_conn *hcon,
} pdu;
int err;

- if (num_bis > sizeof(pdu.bis))
+ if (num_bis < 0x01 || num_bis > sizeof(pdu.bis))
return -EINVAL;

err = qos_set_big(hdev, qos);
diff --git a/net/bluetooth/iso.c b/net/bluetooth/iso.c
index 2132a16be93c..8ab7ea5ebedf 100644
--- a/net/bluetooth/iso.c
+++ b/net/bluetooth/iso.c
@@ -790,8 +790,7 @@ static int iso_sock_bind_bc(struct socket *sock, struct sockaddr *addr,
BT_DBG("sk %p bc_sid %u bc_num_bis %u", sk, sa->iso_bc->bc_sid,
sa->iso_bc->bc_num_bis);

- if (addr_len > sizeof(*sa) + sizeof(*sa->iso_bc) ||
- sa->iso_bc->bc_num_bis < 0x01 || sa->iso_bc->bc_num_bis > 0x1f)
+ if (addr_len > sizeof(*sa) + sizeof(*sa->iso_bc))
return -EINVAL;

bacpy(&iso_pi(sk)->dst, &sa->iso_bc->bc_bdaddr);
--
2.39.2

2023-10-03 15:38:29

by bluez.test.bot

[permalink] [raw]
Subject: RE: Bluetooth: ISO: Allow binding a bcast listener to 0 bises

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=789631

---Test result---

Test Summary:
CheckPatch PASS 0.81 seconds
GitLint PASS 0.30 seconds
SubjectPrefix PASS 0.10 seconds
BuildKernel PASS 34.70 seconds
CheckAllWarning PASS 38.04 seconds
CheckSparse PASS 44.49 seconds
CheckSmatch PASS 116.78 seconds
BuildKernel32 PASS 33.12 seconds
TestRunnerSetup PASS 510.61 seconds
TestRunner_l2cap-tester PASS 31.12 seconds
TestRunner_iso-tester PASS 54.18 seconds
TestRunner_bnep-tester PASS 10.63 seconds
TestRunner_mgmt-tester FAIL 229.78 seconds
TestRunner_rfcomm-tester PASS 16.20 seconds
TestRunner_sco-tester PASS 19.63 seconds
TestRunner_ioctl-tester PASS 18.64 seconds
TestRunner_mesh-tester PASS 13.54 seconds
TestRunner_smp-tester PASS 14.64 seconds
TestRunner_userchan-tester PASS 12.42 seconds
IncrementalBuild PASS 32.09 seconds

Details
##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner
Output:
Total: 497, Passed: 496 (99.8%), Failed: 1, Not Run: 0

Failed Test Cases
LL Privacy - Add Device 5 (2 Devices to RL) Failed 0.424 seconds


---
Regards,
Linux Bluetooth

2023-10-03 17:11:07

by patchwork-bot+bluetooth

[permalink] [raw]
Subject: Re: [PATCH 0/1] Bluetooth: ISO: Allow binding a bcast listener to 0 bises

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <[email protected]>:

On Tue, 3 Oct 2023 17:49:32 +0300 you wrote:
> Some Broadcast scenarios require for a broadcast listener to listen for
> a broadcaster only for PA sync.
>
> This patch adds support for binding to a broadcaster address without
> asking for any BIS to sync with.
>
> Iulia Tanasescu (1):
> Bluetooth: ISO: Allow binding a bcast listener to 0 bises
>
> [...]

Here is the summary with links:
- [1/1] Bluetooth: ISO: Allow binding a bcast listener to 0 bises
https://git.kernel.org/bluetooth/bluetooth-next/c/8e437e71f361

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html