2023-07-27 07:53:56

by Johan Hovold

Subject: Re: [PATCH v13 2/2] Bluetooth: hci_qca: Add support for Qualcomm Bluetooth SoC QCA2066

On Thu, Jul 27, 2023 at 12:40:11PM +0800, Tim Jiang wrote:
> This patch adds support for QCA2066 firmware patch and NVM downloading.
> as the RF performance of QCA2066 SOC chip from different foundries may
> vary. Therefore we use different NVM to configure them based on board ID.
>
> Signed-off-by: Tim Jiang <[email protected]>
> ---

> @@ -1931,6 +1934,12 @@ static const struct qca_device_data qca_soc_data_wcn3998 __maybe_unused = {
> .num_vregs = 4,
> };
>
> +static const struct qca_device_data qca_soc_data_qca2066 __maybe_unused = {
> + .soc_type = QCA_QCA2066,
> + .num_vregs = 0,
> +};
> +
> +

Stray newline.

> static const struct qca_device_data qca_soc_data_qca6390 __maybe_unused = {
> .soc_type = QCA_QCA6390,
> .num_vregs = 0,

Johan

2023-07-27 09:00:02

by Tim Jiang

Subject: Re: [PATCH v13 2/2] Bluetooth: hci_qca: Add support for Qualcomm Bluetooth SoC QCA2066

On 7/27/23 15:30, Johan Hovold wrote:
> On Thu, Jul 27, 2023 at 12:40:11PM +0800, Tim Jiang wrote:
>> This patch adds support for QCA2066 firmware patch and NVM downloading.
>> as the RF performance of QCA2066 SOC chip from different foundries may
>> vary. Therefore we use different NVM to configure them based on board ID.
>>
>> Signed-off-by: Tim Jiang <[email protected]>
>> ---
>
>> @@ -1931,6 +1934,12 @@ static const struct qca_device_data qca_soc_data_wcn3998 __maybe_unused = {
>> .num_vregs = 4,
>> };
>>
>> +static const struct qca_device_data qca_soc_data_qca2066 __maybe_unused = {
>> + .soc_type = QCA_QCA2066,
>> + .num_vregs = 0,
>> +};
>> +
>> +
> Stray newline.
[Tim] sorry for this typo, will address it in v14 , thank you.
>
>> static const struct qca_device_data qca_soc_data_qca6390 __maybe_unused = {
>> .soc_type = QCA_QCA6390,
>> .num_vregs = 0,
> Johan