2023-08-22 11:56:04

by Paul Menzel

Subject: Re: [PATCH] Bluetooth: btusb: Fix quirks table naming

Dear Bastian,


Thank you for the patch.

Am 22.08.23 um 12:20 schrieb Bastien Nocera:
> The quirks table was named "blacklist_table" which isn't a good
> description for that table as devices detected using it weren't ignored
> by the driver.
>
> Rename the table to match what it actually does.

Maybe mention the new name also in the summary to be more specific? Maybe:

Bluetooth: btusb: Rename blacklist_table to quirks_table

> Signed-off-by: Bastien Nocera <[email protected]>
> ---
> drivers/bluetooth/btusb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index 764d176e9735..a1be66ef175c 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -175,7 +175,7 @@ static const struct usb_device_id btusb_table[] = {
>
> MODULE_DEVICE_TABLE(usb, btusb_table);
>
> -static const struct usb_device_id blacklist_table[] = {
> +static const struct usb_device_id quirks_table[] = {
> /* CSR BlueCore devices */
> { USB_DEVICE(0x0a12, 0x0001), .driver_info = BTUSB_CSR },
>
> @@ -4113,7 +4113,7 @@ static int btusb_probe(struct usb_interface *intf,
> if (!id->driver_info) {
> const struct usb_device_id *match;
>
> - match = usb_match_id(intf, blacklist_table);
> + match = usb_match_id(intf, quirks_table);
> if (match)
> id = match;
> }

Thank you for doing this.

Reviewed-by: Paul Menzel <[email protected]>


Kind regards,

Paul

2023-08-22 12:11:51

by Bastien Nocera

Subject: Re: [PATCH] Bluetooth: btusb: Fix quirks table naming

On Tue, 2023-08-22 at 12:41 +0200, Paul Menzel wrote:
> Dear Bastian,
>
>
> Thank you for the patch.
>
> Am 22.08.23 um 12:20 schrieb Bastien Nocera:
> > The quirks table was named "blacklist_table" which isn't a good
> > description for that table as devices detected using it weren't
> > ignored
> > by the driver.
> >
> > Rename the table to match what it actually does.
>
> Maybe mention the new name also in the summary to be more specific?
> Maybe:
>
> Bluetooth: btusb: Rename blacklist_table to quirks_table

I think that's clear enough from the commit message itself.

> > Signed-off-by: Bastien Nocera <[email protected]>
> > ---
> >   drivers/bluetooth/btusb.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> > index 764d176e9735..a1be66ef175c 100644
> > --- a/drivers/bluetooth/btusb.c
> > +++ b/drivers/bluetooth/btusb.c
> > @@ -175,7 +175,7 @@ static const struct usb_device_id btusb_table[]
> > = {
> >  
> >   MODULE_DEVICE_TABLE(usb, btusb_table);
> >  
> > -static const struct usb_device_id blacklist_table[] = {
> > +static const struct usb_device_id quirks_table[] = {
> >         /* CSR BlueCore devices */
> >         { USB_DEVICE(0x0a12, 0x0001), .driver_info = BTUSB_CSR },
> >  
> > @@ -4113,7 +4113,7 @@ static int btusb_probe(struct usb_interface
> > *intf,
> >         if (!id->driver_info) {
> >                 const struct usb_device_id *match;
> >  
> > -               match = usb_match_id(intf, blacklist_table);
> > +               match = usb_match_id(intf, quirks_table);
> >                 if (match)
> >                         id = match;
> >         }
>
> Thank you for doing this.
>
> Reviewed-by: Paul Menzel <[email protected]>
>
>
> Kind regards,
>
> Paul