2022-03-23 08:28:05

by Dan Carpenter

Subject: [PATCH] Bluetooth: mt7921s: fix a NULL check

There is a typo in the NULL check so it's never true. It should be
checking "*ven_data" instead of "ven_data".

Fixes: 3cabc5ca2c9d ("Bluetooth: mt7921s: Add .btmtk_get_codec_config_data")
Signed-off-by: Dan Carpenter <[email protected]>
---
drivers/bluetooth/btmtksdio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/bluetooth/btmtksdio.c b/drivers/bluetooth/btmtksdio.c
index f3dc5881fff7..b6d77e04240c 100644
--- a/drivers/bluetooth/btmtksdio.c
+++ b/drivers/bluetooth/btmtksdio.c
@@ -961,7 +961,7 @@ static int btmtksdio_get_codec_config_data(struct hci_dev *hdev,
}

*ven_data = kmalloc(sizeof(__u8), GFP_KERNEL);
- if (!ven_data) {
+ if (!*ven_data) {
err = -ENOMEM;
goto error;
}
--
2.20.1

2022-03-23 15:23:18

by patchwork-bot+bluetooth

Subject: Re: [PATCH] Bluetooth: mt7921s: fix a NULL check

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Marcel Holtmann <[email protected]>:

On Wed, 23 Mar 2022 10:48:30 +0300 you wrote:
> There is a typo in the NULL check so it's never true. It should be
> checking "*ven_data" instead of "ven_data".
>
> Fixes: 3cabc5ca2c9d ("Bluetooth: mt7921s: Add .btmtk_get_codec_config_data")
> Signed-off-by: Dan Carpenter <[email protected]>
> ---
> drivers/bluetooth/btmtksdio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
- Bluetooth: mt7921s: fix a NULL check
https://git.kernel.org/bluetooth/bluetooth-next/c/864cc8a234cd

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

2022-03-24 14:08:23

by Yake Yang (杨亚克)

Subject: 回复: [PATCH] Bluetooth: mt7921s: fix a NULL check

Hi Dan,
Thanks for fixing this issue, we will update patch.

-----?ʼ?ԭ??-----
??????: Dan Carpenter <[email protected]>
????ʱ??: 2022??3??23?? 15:49
?ռ???: Marcel Holtmann <[email protected]>; Yake Yang (???ǿ?) <[email protected]>
????: Johan Hedberg <[email protected]>; Luiz Augusto von Dentz <[email protected]>; Matthias Brugger <[email protected]>; Sean Wang <[email protected]>; Mark Chen <[email protected]>; [email protected]; [email protected]; [email protected]
????: [PATCH] Bluetooth: mt7921s: fix a NULL check

There is a typo in the NULL check so it's never true. It should be checking "*ven_data" instead of "ven_data".

Fixes: 3cabc5ca2c9d ("Bluetooth: mt7921s: Add .btmtk_get_codec_config_data")
Signed-off-by: Dan Carpenter <[email protected]>
---
drivers/bluetooth/btmtksdio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/bluetooth/btmtksdio.c b/drivers/bluetooth/btmtksdio.c index f3dc5881fff7..b6d77e04240c 100644
--- a/drivers/bluetooth/btmtksdio.c
+++ b/drivers/bluetooth/btmtksdio.c
@@ -961,7 +961,7 @@ static int btmtksdio_get_codec_config_data(struct hci_dev *hdev,
}

*ven_data = kmalloc(sizeof(__u8), GFP_KERNEL);
- if (!ven_data) {
+ if (!*ven_data) {
err = -ENOMEM;
goto error;
}
--
2.20.1

2022-03-24 15:43:11

by bluez.test.bot

Subject: RE: Bluetooth: mt7921s: fix a NULL check

This is an automated email and please do not reply to this email.

Dear Submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
While preparing the CI tests, the patches you submitted couldn't be applied to the current HEAD of the repository.

----- Output -----
error: patch failed: drivers/bluetooth/btmtksdio.c:961
error: drivers/bluetooth/btmtksdio.c: patch does not apply
hint: Use 'git am --show-current-patch' to see the failed patch


Please resolve the issue and submit the patches again.


---
Regards,
Linux Bluetooth