This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=786455
---Test result---
Test Summary:
CheckPatch PASS 2.52 seconds
GitLint FAIL 1.58 seconds
BuildEll PASS 34.31 seconds
BluezMake PASS 1192.51 seconds
MakeCheck PASS 13.44 seconds
MakeDistcheck PASS 195.33 seconds
CheckValgrind PASS 314.03 seconds
CheckSmatch PASS 437.84 seconds
bluezmakeextell PASS 131.38 seconds
IncrementalBuild PASS 5145.48 seconds
ScanBuild PASS 1374.82 seconds
Details
##############################
Test: GitLint - FAIL
Desc: Run gitlint
Output:
[BlueZ,3/5] client: Make transport.show to print QoS property
WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
10: B3 Line contains hard tab characters (\t): " UUID: 00002bcb-0000-1000-8000-00805f9b34fb"
11: B3 Line contains hard tab characters (\t): " Codec: 0x06 (6)"
12: B3 Line contains hard tab characters (\t): " Configuration:"
14: B3 Line contains hard tab characters (\t): " Device: /org/bluez/hci0/dev_00_AA_01_01_00_03"
15: B3 Line contains hard tab characters (\t): " State: idle"
16: B3 Line contains hard tab characters (\t): " Endpoint: /org/bluez/hci0/dev_00_AA_01_01_00_03/pac_sink0"
17: B3 Line contains hard tab characters (\t): " QoS Key: CIG"
18: B3 Line contains hard tab characters (\t): " QoS Value: 0x00 (0)"
19: B3 Line contains hard tab characters (\t): " QoS Key: CIS"
20: B3 Line contains hard tab characters (\t): " QoS Value: 0x00 (0)"
21: B3 Line contains hard tab characters (\t): " QoS Key: Framing"
22: B3 Line contains hard tab characters (\t): " QoS Value: 0x00 (0)"
23: B3 Line contains hard tab characters (\t): " QoS Key: PresentationDelay"
24: B3 Line contains hard tab characters (\t): " QoS Value: 0x00009c40 (40000)"
25: B3 Line contains hard tab characters (\t): " QoS Key: Interval"
26: B3 Line contains hard tab characters (\t): " QoS Value: 0x00002710 (10000)"
27: B3 Line contains hard tab characters (\t): " QoS Key: Latency"
28: B3 Line contains hard tab characters (\t): " QoS Value: 0x000a (10)"
29: B3 Line contains hard tab characters (\t): " QoS Key: SDU"
30: B3 Line contains hard tab characters (\t): " QoS Value: 0x0028 (40)"
31: B3 Line contains hard tab characters (\t): " QoS Key: PHY"
32: B3 Line contains hard tab characters (\t): " QoS Value: 0x02 (2)"
33: B3 Line contains hard tab characters (\t): " QoS Key: Retransmissions"
34: B3 Line contains hard tab characters (\t): " QoS Value: 0x02 (2)"
35: B3 Line contains hard tab characters (\t): " Location: 0x00000003 (3)"
36: B3 Line contains hard tab characters (\t): " Links: /org/bluez/hci0/dev_00_AA_01_01_00_03/pac_source0/fd0"
---
Regards,
Linux Bluetooth
Hi,
On Thu, Sep 21, 2023 at 8:23 PM <[email protected]> wrote:
>
> This is automated email and please do not reply to this email!
>
> Dear submitter,
>
> Thank you for submitting the patches to the linux bluetooth mailing list.
> This is a CI test results with your patch series:
> PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=786455
Have a look if I capture everything correctly, Ive made sure the
bluetoothctl works with QoS being a single property but we still have
to do the changes at upper layers.
@Pauli Virtanen You can use bluetoothctl as an example how to encode
the QoS property, note that there are multiple containers involved
because the QoS dict becomes the variant portion of the outer
dictionary but you will notice if the daemon is not able to parse it.
I could consider supporting the old format though if you think we
should maintain backwards compatibility.
> ---Test result---
>
> Test Summary:
> CheckPatch PASS 2.52 seconds
> GitLint FAIL 1.58 seconds
> BuildEll PASS 34.31 seconds
> BluezMake PASS 1192.51 seconds
> MakeCheck PASS 13.44 seconds
> MakeDistcheck PASS 195.33 seconds
> CheckValgrind PASS 314.03 seconds
> CheckSmatch PASS 437.84 seconds
> bluezmakeextell PASS 131.38 seconds
> IncrementalBuild PASS 5145.48 seconds
> ScanBuild PASS 1374.82 seconds
>
> Details
> ##############################
> Test: GitLint - FAIL
> Desc: Run gitlint
> Output:
> [BlueZ,3/5] client: Make transport.show to print QoS property
>
> WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
> 10: B3 Line contains hard tab characters (\t): " UUID: 00002bcb-0000-1000-8000-00805f9b34fb"
> 11: B3 Line contains hard tab characters (\t): " Codec: 0x06 (6)"
> 12: B3 Line contains hard tab characters (\t): " Configuration:"
> 14: B3 Line contains hard tab characters (\t): " Device: /org/bluez/hci0/dev_00_AA_01_01_00_03"
> 15: B3 Line contains hard tab characters (\t): " State: idle"
> 16: B3 Line contains hard tab characters (\t): " Endpoint: /org/bluez/hci0/dev_00_AA_01_01_00_03/pac_sink0"
> 17: B3 Line contains hard tab characters (\t): " QoS Key: CIG"
> 18: B3 Line contains hard tab characters (\t): " QoS Value: 0x00 (0)"
> 19: B3 Line contains hard tab characters (\t): " QoS Key: CIS"
> 20: B3 Line contains hard tab characters (\t): " QoS Value: 0x00 (0)"
> 21: B3 Line contains hard tab characters (\t): " QoS Key: Framing"
> 22: B3 Line contains hard tab characters (\t): " QoS Value: 0x00 (0)"
> 23: B3 Line contains hard tab characters (\t): " QoS Key: PresentationDelay"
> 24: B3 Line contains hard tab characters (\t): " QoS Value: 0x00009c40 (40000)"
> 25: B3 Line contains hard tab characters (\t): " QoS Key: Interval"
> 26: B3 Line contains hard tab characters (\t): " QoS Value: 0x00002710 (10000)"
> 27: B3 Line contains hard tab characters (\t): " QoS Key: Latency"
> 28: B3 Line contains hard tab characters (\t): " QoS Value: 0x000a (10)"
> 29: B3 Line contains hard tab characters (\t): " QoS Key: SDU"
> 30: B3 Line contains hard tab characters (\t): " QoS Value: 0x0028 (40)"
> 31: B3 Line contains hard tab characters (\t): " QoS Key: PHY"
> 32: B3 Line contains hard tab characters (\t): " QoS Value: 0x02 (2)"
> 33: B3 Line contains hard tab characters (\t): " QoS Key: Retransmissions"
> 34: B3 Line contains hard tab characters (\t): " QoS Value: 0x02 (2)"
> 35: B3 Line contains hard tab characters (\t): " Location: 0x00000003 (3)"
> 36: B3 Line contains hard tab characters (\t): " Links: /org/bluez/hci0/dev_00_AA_01_01_00_03/pac_source0/fd0"
>
>
> ---
> Regards,
> Linux Bluetooth
>
--
Luiz Augusto von Dentz