Hi all,
Could you please enable this profile in the coming release?
To update:
Add VID,PID,VER setting in main.conf
I think the parse_config also need add code in order to parse these value to main_opt.did.
Thanks
Zhigang
Hi Zhigang,
please stop top-posting. This is an open source mailing list and we do
bottom posting and inline quoting.
> If USB Vendor ID and Bluetooth Vendor ID are both exist which one you prefer in DID? We can't add both right?
Default is Bluetooth since we are doing Bluetooth here and not USB. USB
would need a specific prefix. So I prefer usb:1223:1233:1223 for
indicating USB ids and without we default to Bluetooth. Care to send a
patch for it.
Regards
Marcel
SGkgTWFyY2VsLA0KSWYgVVNCIFZlbmRvciBJRCBhbmQgQmx1ZXRvb3RoIFZlbmRvciBJRCBhcmUg
Ym90aCBleGlzdCB3aGljaCBvbmUgeW91IHByZWZlciBpbiBESUQ/IFdlIGNhbid0IGFkZCBib3Ro
IHJpZ2h0Pw0KVGhhbmtzDQoNCg0KLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCkZyb206IE1h
cmNlbCBIb2x0bWFubiBbbWFpbHRvOm1hcmNlbEBob2x0bWFubi5vcmddIA0KU2VudDogMjAwOMTq
MTLUwjE4yNUgMzo1OQ0KVG86IExpLCBaaGlnYW5nDQpDYzogSm9oYW4gSGVkYmVyZzsgbGludXgt
Ymx1ZXRvb3RoQHZnZXIua2VybmVsLm9yZw0KU3ViamVjdDogUkU6IFRvIGVuYWJsdWUgRElEIGlu
IGNvbWluZyBibHVleiByZWxlYXNlDQoNCkhpIFpoaWdhbmcsDQoNCnNvIGZpcnN0IHRoaW5ncyBm
aXJzdC4gTk8gdG9wLXBvc3Rpbmcgb24gdGhpcyBtYWlsaW5nIGxpc3QuDQoNCj4gVXBkYXRlZDoN
Cj4gLS0tIGEvbWFpbi5jCVR1ZSBEZWMgMTYgMTc6NDM6MjQgMjAwOCArMDgwMA0KPiArKysgYi9t
YWluLmMJV2VkIERlYyAxNyAxMTo1Nzo0NyAyMDA4ICswODAwDQo+IEBAIC0xNzQsNiArMTc0LDE3
IEBAIHN0YXRpYyB2b2lkIHBhcnNlX2NvbmZpZyhHS2V5RmlsZSAqY29uZmkNCj4gIAkJbWFpbl9v
cHRzLmlucW1vZGUgPSB2YWw7DQo+ICAJfQ0KPiAgDQo+ICsJc3RyID0gZ19rZXlfZmlsZV9nZXRf
c3RyaW5nKGNvbmZpZywgIkdlbmVyYWwiLA0KPiArCQkJCQkiRGV2aWNlSUQiLCAmZXJyKTsNCj4g
KwlpZiAoZXJyKSB7DQo+ICsJCWRlYnVnKCIlcyIsIGVyci0+bWVzc2FnZSk7DQo+ICsJCWdfY2xl
YXJfZXJyb3IoJmVycik7DQo+ICsJfSBlbHNlIHsNCj4gKwkJZGVidWcoImRldmljZWlkPSVzIiwg
c3RyKTsNCj4gKwkJc3RybmNweShtYWluX29wdHMuZGV2aWNlaWQsIHN0ciwgc2l6ZW9mKG1haW5f
b3B0cy5kZXZpY2VpZCkpOw0KPiArCQlnX2ZyZWUoc3RyKTsNCj4gKwl9DQo+ICsNCj4gIAltYWlu
X29wdHMubGlua19tb2RlID0gSENJX0xNX0FDQ0VQVDsNCj4gIA0KPiAgCW1haW5fb3B0cy5saW5r
X3BvbGljeSA9IEhDSV9MUF9SU1dJVENIIHwgSENJX0xQX1NOSUZGIHwNCg0KSSBhbHdheXMgbmVl
ZCBwYXRjaGVzIGFnYWluc3QgdGhlIGxhdGVzdCBHSVQgdHJlZS4gT3RoZXJ3aXNlIEkgY2FuJ3QN
Cm1lcmdlIHRoZW0gYW5kIHN1Ym1pdHRpbmcgdGhlbSBpbiBhIHByb3BlciBmb3JtYXQgaGVscHMg
bWUgdG8gYXBwbHkNCnRoZW0uDQoNCj4gZGlmZiAtciA2NTU1NjUwMjkxMWQgbWFpbi5jb25mDQo+
IC0tLSBhL21haW4uY29uZglUdWUgRGVjIDE2IDE3OjQzOjI0IDIwMDggKzA4MDANCj4gKysrIGIv
bWFpbi5jb25mCVR1ZSBEZWMgMTcgMTE6NTc6NTEgMjAwOCArMDgwMA0KPiBAQCAtMjgsMyArMjgs
OSBAQCBPZmZNb2RlID0gTm9TY2FuDQo+ICAjIERpc2NvdmVyIHNjaGVkdWxlciBpbnRlcnZhbCB1
c2VkIGluIEFkYXB0ZXIuRGlzY292ZXJEZXZpY2VzDQo+ICAjIFRoZSB2YWx1ZSBpcyBpbiBzZWNv
bmRzLiBEZWZhdWx0cyBpcyAwIHRvIHVzZSBjb250cm9sbGVyIHNjaGVkdWxlcg0KPiAgRGlzY292
ZXJTY2hlZHVsZXJJbnRlcnZhbCA9IDANCj4gKw0KPiArDQo+ICsjIFVzZXIgdmVybmRvciBhbmQg
cHJvZHVjdCBhbmQgdmVyc2lvbiBpbmZvcm1hdGlvbiBhcmUgdXNlZCBpbiBESUQgcHJvZmlsZQ0K
PiArIyAiOiIgdG8gaWRlbnRpZnkgdGhlIHZhbHVlLiBGRkZGIGlzIHJlc2VydmVkIGZvciBWZW5k
b3JJZCBieSBkZWZhdWx0Lg0KPiArRGV2aWNlSUQgPSAxMjM0OjU2Nzg6YWJjZA0KDQpTbyB0aGUg
b3B0aW9uIHNob3VsZCBiZSBjb21tZW50ZWQgb3V0IGJ5IGRlZmF1bHQgc2luY2Ugb3RoZXJ3aXNl
IGV2ZXJ5DQppbnN0YWxsYXRpb24gbm93IHVzZXMgdmVuZG9yIGlkIDEyMzQgYW5kIHRoYXQgaXMg
YWN0dWFsbHkgYSB2YWxpZCBvbmUuDQpBbHNvIHRoZSBkZXNjcmlwdGlvbiBhYm92ZSBtYWtlcyBu
byBzZW5zZS4NCg0KSSBjb21taXR0ZWQgYSBwYXRjaCBieSBteXNlbGYgdG8gdGhlIEdJVCB0cmVl
IG5vdyB0aGF0IHNob3VsZCBmaXggdGhpcy4NCkhvd2V2ZXIgdGhlcmUgaXMgb25lIHRoaW5nIG1p
c3NpbmcuIFRoZSBESUQgc3VwcG9ydHMgVVNCIGJhc2VkIHZlbmRvcg0KaWRzIGFuZCBCbHVldG9v
dGggYmFzZWQgb25lcy4gU28gd2UgbmVlZCB0byBzdXBwb3J0IGJvdGguIEZlZWwgZnJlZSB0bw0K
Y29tZSB1cCB3aXRoIHNvbWV0aGluZy4NCg0KUmVnYXJkcw0KDQpNYXJjZWwNCg0KDQo=
Hi Zhigang,
so first things first. NO top-posting on this mailing list.
> Updated:
> --- a/main.c Tue Dec 16 17:43:24 2008 +0800
> +++ b/main.c Wed Dec 17 11:57:47 2008 +0800
> @@ -174,6 +174,17 @@ static void parse_config(GKeyFile *confi
> main_opts.inqmode = val;
> }
>
> + str = g_key_file_get_string(config, "General",
> + "DeviceID", &err);
> + if (err) {
> + debug("%s", err->message);
> + g_clear_error(&err);
> + } else {
> + debug("deviceid=%s", str);
> + strncpy(main_opts.deviceid, str, sizeof(main_opts.deviceid));
> + g_free(str);
> + }
> +
> main_opts.link_mode = HCI_LM_ACCEPT;
>
> main_opts.link_policy = HCI_LP_RSWITCH | HCI_LP_SNIFF |
I always need patches against the latest GIT tree. Otherwise I can't
merge them and submitting them in a proper format helps me to apply
them.
> diff -r 65556502911d main.conf
> --- a/main.conf Tue Dec 16 17:43:24 2008 +0800
> +++ b/main.conf Tue Dec 17 11:57:51 2008 +0800
> @@ -28,3 +28,9 @@ OffMode = NoScan
> # Discover scheduler interval used in Adapter.DiscoverDevices
> # The value is in seconds. Defaults is 0 to use controller scheduler
> DiscoverSchedulerInterval = 0
> +
> +
> +# User verndor and product and version information are used in DID profile
> +# ":" to identify the value. FFFF is reserved for VendorId by default.
> +DeviceID = 1234:5678:abcd
So the option should be commented out by default since otherwise every
installation now uses vendor id 1234 and that is actually a valid one.
Also the description above makes no sense.
I committed a patch by myself to the GIT tree now that should fix this.
However there is one thing missing. The DID supports USB based vendor
ids and Bluetooth based ones. So we need to support both. Feel free to
come up with something.
Regards
Marcel
VXBkYXRlZDoNCi0tLSBhL21haW4uYwlUdWUgRGVjIDE2IDE3OjQzOjI0IDIwMDggKzA4MDANCisr
KyBiL21haW4uYwlXZWQgRGVjIDE3IDExOjU3OjQ3IDIwMDggKzA4MDANCkBAIC0xNzQsNiArMTc0
LDE3IEBAIHN0YXRpYyB2b2lkIHBhcnNlX2NvbmZpZyhHS2V5RmlsZSAqY29uZmkNCiAJCW1haW5f
b3B0cy5pbnFtb2RlID0gdmFsOw0KIAl9DQogDQorCXN0ciA9IGdfa2V5X2ZpbGVfZ2V0X3N0cmlu
Zyhjb25maWcsICJHZW5lcmFsIiwNCisJCQkJCSJEZXZpY2VJRCIsICZlcnIpOw0KKwlpZiAoZXJy
KSB7DQorCQlkZWJ1ZygiJXMiLCBlcnItPm1lc3NhZ2UpOw0KKwkJZ19jbGVhcl9lcnJvcigmZXJy
KTsNCisJfSBlbHNlIHsNCisJCWRlYnVnKCJkZXZpY2VpZD0lcyIsIHN0cik7DQorCQlzdHJuY3B5
KG1haW5fb3B0cy5kZXZpY2VpZCwgc3RyLCBzaXplb2YobWFpbl9vcHRzLmRldmljZWlkKSk7DQor
CQlnX2ZyZWUoc3RyKTsNCisJfQ0KKw0KIAltYWluX29wdHMubGlua19tb2RlID0gSENJX0xNX0FD
Q0VQVDsNCiANCiAJbWFpbl9vcHRzLmxpbmtfcG9saWN5ID0gSENJX0xQX1JTV0lUQ0ggfCBIQ0lf
TFBfU05JRkYgfA0KZGlmZiAtciA2NTU1NjUwMjkxMWQgbWFpbi5jb25mDQotLS0gYS9tYWluLmNv
bmYJVHVlIERlYyAxNiAxNzo0MzoyNCAyMDA4ICswODAwDQorKysgYi9tYWluLmNvbmYJVHVlIERl
YyAxNyAxMTo1Nzo1MSAyMDA4ICswODAwDQpAQCAtMjgsMyArMjgsOSBAQCBPZmZNb2RlID0gTm9T
Y2FuDQogIyBEaXNjb3ZlciBzY2hlZHVsZXIgaW50ZXJ2YWwgdXNlZCBpbiBBZGFwdGVyLkRpc2Nv
dmVyRGV2aWNlcw0KICMgVGhlIHZhbHVlIGlzIGluIHNlY29uZHMuIERlZmF1bHRzIGlzIDAgdG8g
dXNlIGNvbnRyb2xsZXIgc2NoZWR1bGVyDQogRGlzY292ZXJTY2hlZHVsZXJJbnRlcnZhbCA9IDAN
CisNCisNCisjIFVzZXIgdmVybmRvciBhbmQgcHJvZHVjdCBhbmQgdmVyc2lvbiBpbmZvcm1hdGlv
biBhcmUgdXNlZCBpbiBESUQgcHJvZmlsZQ0KKyMgIjoiIHRvIGlkZW50aWZ5IHRoZSB2YWx1ZS4g
RkZGRiBpcyByZXNlcnZlZCBmb3IgVmVuZG9ySWQgYnkgZGVmYXVsdC4NCitEZXZpY2VJRCA9IDEy
MzQ6NTY3ODphYmNkDQorDQoNCi0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQpGcm9tOiBsaW51
eC1ibHVldG9vdGgtb3duZXJAdmdlci5rZXJuZWwub3JnIFttYWlsdG86bGludXgtYmx1ZXRvb3Ro
LW93bmVyQHZnZXIua2VybmVsLm9yZ10gT24gQmVoYWxmIE9mIE1hcmNlbCBIb2x0bWFubg0KU2Vu
dDogMjAwOMTqMTLUwjE3yNUgMTA6MzgNClRvOiBKb2hhbiBIZWRiZXJnDQpDYzogbGludXgtYmx1
ZXRvb3RoQHZnZXIua2VybmVsLm9yZw0KU3ViamVjdDogUmU6IFRvIGVuYWJsdWUgRElEIGluIGNv
bWluZyBibHVleiByZWxlYXNlDQoNCkhpIEpvaGFuLA0KDQo+IENvdXBsZSBvZiBjb21tZW50czoN
Cj4gDQo+IE9uIFR1ZSwgRGVjIDE2LCAyMDA4LCBMaSwgWmhpZ2FuZyB3cm90ZToNCj4gPiAgCQlt
YWluX29wdHMuaW5xbW9kZSA9IHZhbDsNCj4gPiAgCX0NCj4gPiArCXN0ciA9IGdfa2V5X2ZpbGVf
Z2V0X3N0cmluZyhjb25maWcsICJHZW5lcmFsIiwNCj4gDQo+IENvZGluZyBzdHlsZTogYWRkIGVt
cHR5IGxpbmUgYWZ0ZXIgdGhlIGNsb3NpbmcgYnJhY2tldC4NCj4gDQo+ID4gKwkJCQkJIlZJRC9Q
SUQvVkVSIiwgJmVycik7DQo+IA0KPiBEaWQgeW91IGFncmVlIHdpdGggdGhpcyAiVklEL1BJRC9W
RVIiIG5hbWUgd2l0aCBNYXJjZWw/IEknZCBoYXZlIHVzZWQNCj4gc29tZXRoaW5nIGxpa2UgIkRl
dmljZUlEIiwgIkRldmljZUlESW5mbyIgb3IgIkRJREluZm8iLg0KDQpJIHRoaW5rICJEZXZpY2VJ
RCIgc291bmRzIHJlYXNvbmFibGUuIExldHMgdXNlIHRoYXQgb25lLg0KDQpSZWdhcmRzDQoNCk1h
cmNlbA0KDQoNCi0tDQpUbyB1bnN1YnNjcmliZSBmcm9tIHRoaXMgbGlzdDogc2VuZCB0aGUgbGlu
ZSAidW5zdWJzY3JpYmUgbGludXgtYmx1ZXRvb3RoIiBpbg0KdGhlIGJvZHkgb2YgYSBtZXNzYWdl
IHRvIG1ham9yZG9tb0B2Z2VyLmtlcm5lbC5vcmcNCk1vcmUgbWFqb3Jkb21vIGluZm8gYXQgIGh0
dHA6Ly92Z2VyLmtlcm5lbC5vcmcvbWFqb3Jkb21vLWluZm8uaHRtbA0K
Hi Johan,
> Couple of comments:
>
> On Tue, Dec 16, 2008, Li, Zhigang wrote:
> > main_opts.inqmode = val;
> > }
> > + str = g_key_file_get_string(config, "General",
>
> Coding style: add empty line after the closing bracket.
>
> > + "VID/PID/VER", &err);
>
> Did you agree with this "VID/PID/VER" name with Marcel? I'd have used
> something like "DeviceID", "DeviceIDInfo" or "DIDInfo".
I think "DeviceID" sounds reasonable. Lets use that one.
Regards
Marcel
Typo in main.conf: "verndor"
Li, Zhigang wrote:
> Please check it again.
> Marcel mention it in IRC for VID/PID/VER
>
> --- a/main.c Tue Dec 16 17:43:24 2008 +0800
> +++ b/main.c Wed Dec 17 09:57:37 2008 +0800
> @@ -174,6 +174,17 @@ static void parse_config(GKeyFile *confi
> main_opts.inqmode = val;
> }
>
> + str = g_key_file_get_string(config, "General",
> + "VID/PID/VER", &err);
> + if (err) {
> + debug("%s", err->message);
> + g_clear_error(&err);
> + } else {
> + debug("vid/pid/ver=%s", str);
> + strncpy(main_opts.deviceid, str, sizeof(main_opts.deviceid));
> + g_free(str);
> + }
> +
> main_opts.link_mode = HCI_LM_ACCEPT;
>
> main_opts.link_policy = HCI_LP_RSWITCH | HCI_LP_SNIFF |
> diff -r 65556502911d main.conf
> --- a/main.conf Tue Dec 16 17:43:24 2008 +0800
> +++ b/main.conf Tue Dec 16 17:50:31 2008 +0800
> @@ -28,3 +28,9 @@ OffMode = NoScan
> # Discover scheduler interval used in Adapter.DiscoverDevices
> # The value is in seconds. Defaults is 0 to use controller scheduler
> DiscoverSchedulerInterval = 0
> +
> +
> +# User verndor and product and version information are used in DID profile
> +# ":" to identify the value. FFFF is reserved for VendorId by default.
> +VID/PID/VER = 1234:5678:abcd
> +
>
> Thanks
>
> -----Original Message-----
> From: [email protected] [mailto:[email protected]] On Behalf Of Johan Hedberg
> Sent: 2008??12??16?? 18:29
> To: [email protected]
> Subject: Re: To enablue DID in coming bluez release
>
> Hi,
>
> Couple of comments:
>
> On Tue, Dec 16, 2008, Li, Zhigang wrote:
>
>> main_opts.inqmode = val;
>> }
>> + str = g_key_file_get_string(config, "General",
>>
>
> Coding style: add empty line after the closing bracket.
>
>
>> + "VID/PID/VER", &err);
>>
>
> Did you agree with this "VID/PID/VER" name with Marcel? I'd have used
> something like "DeviceID", "DeviceIDInfo" or "DIDInfo".
>
>
>> + strcpy( main_opts.deviceid,str);
>>
>
> First, coding style: remove the extra space after the opening
> parenthesis and add the missing one after the comma. Second, you're
> overflowing main_opts.deviceid if the string provided in main.conf is
> longer than 14 characters. So the call should be:
> strncpy(main_opts.deviceid, src, sizeof(main_opts.deviceid));
>
> Johan
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> N?????r??y????b?X??ǧv?^?){.n?+????{?n[???-?)????w* jg??? ?????ݢj/???z?ޖ????譁&?)ߡ?a???? ?G???h??j:+v???w??٥
UGxlYXNlIGNoZWNrIGl0IGFnYWluLg0KTWFyY2VsIG1lbnRpb24gaXQgaW4gSVJDIGZvciBWSUQv
UElEL1ZFUg0KDQotLS0gYS9tYWluLmMJVHVlIERlYyAxNiAxNzo0MzoyNCAyMDA4ICswODAwDQor
KysgYi9tYWluLmMJV2VkIERlYyAxNyAwOTo1NzozNyAyMDA4ICswODAwDQpAQCAtMTc0LDYgKzE3
NCwxNyBAQCBzdGF0aWMgdm9pZCBwYXJzZV9jb25maWcoR0tleUZpbGUgKmNvbmZpDQogCQltYWlu
X29wdHMuaW5xbW9kZSA9IHZhbDsNCiAJfQ0KIA0KKwlzdHIgPSBnX2tleV9maWxlX2dldF9zdHJp
bmcoY29uZmlnLCAiR2VuZXJhbCIsDQorCQkJCQkiVklEL1BJRC9WRVIiLCAmZXJyKTsNCisJaWYg
KGVycikgew0KKwkJZGVidWcoIiVzIiwgZXJyLT5tZXNzYWdlKTsNCisJCWdfY2xlYXJfZXJyb3Io
JmVycik7DQorCX0gZWxzZSB7DQorCQlkZWJ1ZygidmlkL3BpZC92ZXI9JXMiLCBzdHIpOw0KKwkJ
c3RybmNweShtYWluX29wdHMuZGV2aWNlaWQsIHN0ciwgc2l6ZW9mKG1haW5fb3B0cy5kZXZpY2Vp
ZCkpOw0KKwkJZ19mcmVlKHN0cik7DQorCX0NCisNCiAJbWFpbl9vcHRzLmxpbmtfbW9kZSA9IEhD
SV9MTV9BQ0NFUFQ7DQogDQogCW1haW5fb3B0cy5saW5rX3BvbGljeSA9IEhDSV9MUF9SU1dJVENI
IHwgSENJX0xQX1NOSUZGIHwNCmRpZmYgLXIgNjU1NTY1MDI5MTFkIG1haW4uY29uZg0KLS0tIGEv
bWFpbi5jb25mCVR1ZSBEZWMgMTYgMTc6NDM6MjQgMjAwOCArMDgwMA0KKysrIGIvbWFpbi5jb25m
CVR1ZSBEZWMgMTYgMTc6NTA6MzEgMjAwOCArMDgwMA0KQEAgLTI4LDMgKzI4LDkgQEAgT2ZmTW9k
ZSA9IE5vU2Nhbg0KICMgRGlzY292ZXIgc2NoZWR1bGVyIGludGVydmFsIHVzZWQgaW4gQWRhcHRl
ci5EaXNjb3ZlckRldmljZXMNCiAjIFRoZSB2YWx1ZSBpcyBpbiBzZWNvbmRzLiBEZWZhdWx0cyBp
cyAwIHRvIHVzZSBjb250cm9sbGVyIHNjaGVkdWxlcg0KIERpc2NvdmVyU2NoZWR1bGVySW50ZXJ2
YWwgPSAwDQorDQorDQorIyBVc2VyIHZlcm5kb3IgYW5kIHByb2R1Y3QgYW5kIHZlcnNpb24gaW5m
b3JtYXRpb24gYXJlIHVzZWQgaW4gRElEIHByb2ZpbGUNCisjICI6IiB0byBpZGVudGlmeSB0aGUg
dmFsdWUuIEZGRkYgaXMgcmVzZXJ2ZWQgZm9yIFZlbmRvcklkIGJ5IGRlZmF1bHQuDQorVklEL1BJ
RC9WRVIgPSAxMjM0OjU2Nzg6YWJjZA0KKw0KDQpUaGFua3MNCg0KLS0tLS1PcmlnaW5hbCBNZXNz
YWdlLS0tLS0NCkZyb206IGxpbnV4LWJsdWV0b290aC1vd25lckB2Z2VyLmtlcm5lbC5vcmcgW21h
aWx0bzpsaW51eC1ibHVldG9vdGgtb3duZXJAdmdlci5rZXJuZWwub3JnXSBPbiBCZWhhbGYgT2Yg
Sm9oYW4gSGVkYmVyZw0KU2VudDogMjAwOMTqMTLUwjE2yNUgMTg6MjkNClRvOiBsaW51eC1ibHVl
dG9vdGhAdmdlci5rZXJuZWwub3JnDQpTdWJqZWN0OiBSZTogVG8gZW5hYmx1ZSBESUQgaW4gY29t
aW5nIGJsdWV6IHJlbGVhc2UNCg0KSGksDQoNCkNvdXBsZSBvZiBjb21tZW50czoNCg0KT24gVHVl
LCBEZWMgMTYsIDIwMDgsIExpLCBaaGlnYW5nIHdyb3RlOg0KPiAgCQltYWluX29wdHMuaW5xbW9k
ZSA9IHZhbDsNCj4gIAl9DQo+ICsJc3RyID0gZ19rZXlfZmlsZV9nZXRfc3RyaW5nKGNvbmZpZywg
IkdlbmVyYWwiLA0KDQpDb2Rpbmcgc3R5bGU6IGFkZCBlbXB0eSBsaW5lIGFmdGVyIHRoZSBjbG9z
aW5nIGJyYWNrZXQuDQoNCj4gKwkJCQkJIlZJRC9QSUQvVkVSIiwgJmVycik7DQoNCkRpZCB5b3Ug
YWdyZWUgd2l0aCB0aGlzICJWSUQvUElEL1ZFUiIgbmFtZSB3aXRoIE1hcmNlbD8gSSdkIGhhdmUg
dXNlZA0Kc29tZXRoaW5nIGxpa2UgIkRldmljZUlEIiwgIkRldmljZUlESW5mbyIgb3IgIkRJRElu
Zm8iLg0KDQo+ICsJCXN0cmNweSggbWFpbl9vcHRzLmRldmljZWlkLHN0cik7DQoNCkZpcnN0LCBj
b2Rpbmcgc3R5bGU6IHJlbW92ZSB0aGUgZXh0cmEgc3BhY2UgYWZ0ZXIgdGhlIG9wZW5pbmcNCnBh
cmVudGhlc2lzIGFuZCBhZGQgdGhlIG1pc3Npbmcgb25lIGFmdGVyIHRoZSBjb21tYS4gU2Vjb25k
LCB5b3UncmUNCm92ZXJmbG93aW5nIG1haW5fb3B0cy5kZXZpY2VpZCBpZiB0aGUgc3RyaW5nIHBy
b3ZpZGVkIGluIG1haW4uY29uZiBpcw0KbG9uZ2VyIHRoYW4gMTQgY2hhcmFjdGVycy4gU28gdGhl
IGNhbGwgc2hvdWxkIGJlOg0Kc3RybmNweShtYWluX29wdHMuZGV2aWNlaWQsIHNyYywgc2l6ZW9m
KG1haW5fb3B0cy5kZXZpY2VpZCkpOw0KDQpKb2hhbg0KLS0NClRvIHVuc3Vic2NyaWJlIGZyb20g
dGhpcyBsaXN0OiBzZW5kIHRoZSBsaW5lICJ1bnN1YnNjcmliZSBsaW51eC1ibHVldG9vdGgiIGlu
DQp0aGUgYm9keSBvZiBhIG1lc3NhZ2UgdG8gbWFqb3Jkb21vQHZnZXIua2VybmVsLm9yZw0KTW9y
ZSBtYWpvcmRvbW8gaW5mbyBhdCAgaHR0cDovL3ZnZXIua2VybmVsLm9yZy9tYWpvcmRvbW8taW5m
by5odG1sDQo=
Hi,
Couple of comments:
On Tue, Dec 16, 2008, Li, Zhigang wrote:
> main_opts.inqmode = val;
> }
> + str = g_key_file_get_string(config, "General",
Coding style: add empty line after the closing bracket.
> + "VID/PID/VER", &err);
Did you agree with this "VID/PID/VER" name with Marcel? I'd have used
something like "DeviceID", "DeviceIDInfo" or "DIDInfo".
> + strcpy( main_opts.deviceid,str);
First, coding style: remove the extra space after the opening
parenthesis and add the missing one after the comma. Second, you're
overflowing main_opts.deviceid if the string provided in main.conf is
longer than 14 characters. So the call should be:
strncpy(main_opts.deviceid, src, sizeof(main_opts.deviceid));
Johan
UmVzZW5kOg0KDQotLS0gYS9tYWluLmMJVHVlIERlYyAxNiAxNzo0MzoyNCAyMDA4ICswODAwDQor
KysgYi9tYWluLmMJVHVlIERlYyAxNiAxNzo0NDo0MyAyMDA4ICswODAwDQpAQCAtMTczLDYgKzE3
MywxNiBAQCBzdGF0aWMgdm9pZCBwYXJzZV9jb25maWcoR0tleUZpbGUgKmNvbmZpDQogCQlkZWJ1
ZygiaW5xbW9kZT0lZCIsIHZhbCk7DQogCQltYWluX29wdHMuaW5xbW9kZSA9IHZhbDsNCiAJfQ0K
KwlzdHIgPSBnX2tleV9maWxlX2dldF9zdHJpbmcoY29uZmlnLCAiR2VuZXJhbCIsDQorCQkJCQki
VklEL1BJRC9WRVIiLCAmZXJyKTsNCisJaWYgKGVycikgew0KKwkJZGVidWcoIiVzIiwgZXJyLT5t
ZXNzYWdlKTsNCisJCWdfY2xlYXJfZXJyb3IoJmVycik7DQorCX0gZWxzZSB7DQorCQlkZWJ1Zygi
dmlkL3BpZC92ZXI9JXMiLCBzdHIpOw0KKwkJc3RyY3B5KCBtYWluX29wdHMuZGV2aWNlaWQsc3Ry
KTsNCisJCWdfZnJlZShzdHIpOw0KKwl9DQogDQogCW1haW5fb3B0cy5saW5rX21vZGUgPSBIQ0lf
TE1fQUNDRVBUOw0KDQotLS0gYS9tYWluLmNvbmYJVHVlIERlYyAxNiAxNzo0MzoyNCAyMDA4ICsw
ODAwDQorKysgYi9tYWluLmNvbmYJVHVlIERlYyAxNiAxNzo1MDozMSAyMDA4ICswODAwDQpAQCAt
MjgsMyArMjgsOSBAQCBPZmZNb2RlID0gTm9TY2FuDQogIyBEaXNjb3ZlciBzY2hlZHVsZXIgaW50
ZXJ2YWwgdXNlZCBpbiBBZGFwdGVyLkRpc2NvdmVyRGV2aWNlcw0KICMgVGhlIHZhbHVlIGlzIGlu
IHNlY29uZHMuIERlZmF1bHRzIGlzIDAgdG8gdXNlIGNvbnRyb2xsZXIgc2NoZWR1bGVyDQogRGlz
Y292ZXJTY2hlZHVsZXJJbnRlcnZhbCA9IDANCisNCisNCisjIFVzZXIgdmVybmRvciBhbmQgcHJv
ZHVjdCBhbmQgdmVyc2lvbiBpbmZvcm1hdGlvbiBhcmUgdXNlZCBpbiBESUQgcHJvZmlsZQ0KKyMg
IjoiIHRvIGlkZW50aWZ5IHRoZSB2YWx1ZS4gRkZGRiBpcyByZXNlcnZlZCBmb3IgVmVuZG9ySWQg
YnkgZGVmYXVsdC4NCitWSUQvUElEL1ZFUiA9IDEyMzQ6NTY3ODphYmNkDQorDQoNCg0KVGhhbmtz
DQoNCg0KLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCkZyb206IGxpbnV4LWJsdWV0b290aC1v
d25lckB2Z2VyLmtlcm5lbC5vcmcgW21haWx0bzpsaW51eC1ibHVldG9vdGgtb3duZXJAdmdlci5r
ZXJuZWwub3JnXSBPbiBCZWhhbGYgT2YgTGksIFpoaWdhbmcNClNlbnQ6IDIwMDjE6jEy1MIxNsjV
IDE1OjU2DQpUbzogTWFyY2VsIEhvbHRtYW5uDQpDYzogbGludXgtYmx1ZXRvb3RoQHZnZXIua2Vy
bmVsLm9yZw0KU3ViamVjdDogUkU6IFRvIGVuYWJsdWUgRElEIGluIGNvbWluZyBibHVleiByZWxl
YXNlDQoNClBsZWFzZSBzZWUgdGhlIGF0dGFjaGVkIA0KVGhlIHBhdGNoIGlzIHZhbGlkYXRlZCBp
biBteSBwYyB3aXRoIDQuMTggdmVyc2lvbiBhbmQgd29ya3MgZmluZS4NCklmIGl0J3Mgb2sgZm9y
IHlvdSBwbGVhc2UgbWVyZ2UgaXQgaW50byB1cHN0cmVhbS4NClRoYW5rcw0KDQoNCi0tLS0tT3Jp
Z2luYWwgTWVzc2FnZS0tLS0tDQpGcm9tOiBNYXJjZWwgSG9sdG1hbm4gW21haWx0bzptYXJjZWxA
aG9sdG1hbm4ub3JnXSANClNlbnQ6IDIwMDjE6jEy1MIxMsjVIDk6NTYNClRvOiBMaSwgWmhpZ2Fu
Zw0KQ2M6IGxpbnV4LWJsdWV0b290aEB2Z2VyLmtlcm5lbC5vcmcNClN1YmplY3Q6IFJlOiBUbyBl
bmFibHVlIERJRCBpbiBjb21pbmcgYmx1ZXogcmVsZWFzZQ0KDQpIaSBaaGlnYW5nLA0KDQo+IENv
dWxkIHlvdSBwbGVhc2UgZW5hYmxlIHRoaXMgcHJvZmlsZSBpbiB0aGUgY29taW5nIHJlbGVhc2U/
DQo+IFRvIHVwZGF0ZToNCj4gQWRkIFZJRCxQSUQsVkVSIHNldHRpbmcgaW4gbWFpbi5jb25mDQo+
IA0KPiBJIHRoaW5rIHRoZSBwYXJzZV9jb25maWcgYWxzbyBuZWVkIGFkZCBjb2RlIGluIG9yZGVy
IHRvIHBhcnNlIHRoZXNlIHZhbHVlIHRvIG1haW5fb3B0LmRpZC4NCg0KSSB3YXMgZXhwZWN0aW5n
IHRoYXQgeW91IHNlbmQgbWUgYSBwYXRjaCBmb3IgaXQuDQoNClJlZ2FyZHMNCg0KTWFyY2VsDQoN
Cg0K
Please see the attached
The patch is validated in my pc with 4.18 version and works fine.
If it's ok for you please merge it into upstream.
Thanks
-----Original Message-----
From: Marcel Holtmann [mailto:[email protected]]
Sent: 2008??12??12?? 9:56
To: Li, Zhigang
Cc: [email protected]
Subject: Re: To enablue DID in coming bluez release
Hi Zhigang,
> Could you please enable this profile in the coming release?
> To update:
> Add VID,PID,VER setting in main.conf
>
> I think the parse_config also need add code in order to parse these value to main_opt.did.
I was expecting that you send me a patch for it.
Regards
Marcel
Hi Zhigang,
> Could you please enable this profile in the coming release?
> To update:
> Add VID,PID,VER setting in main.conf
>
> I think the parse_config also need add code in order to parse these value to main_opt.did.
I was expecting that you send me a patch for it.
Regards
Marcel