2023-01-27 11:37:27

by Marcin Kraglak

Subject: [PATCH 1/2] shared/util: Add CAS, HAS, TMAS and PBAS UUIDs

Add UUIDs for: Common Audio service, Hearing Aid service,
TMAS service and Public Broadcast Announcement service.
---
src/shared/util.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/src/shared/util.c b/src/shared/util.c
index 69abfba31..1ff9c56fc 100644
--- a/src/shared/util.c
+++ b/src/shared/util.c
@@ -447,7 +447,11 @@ static const struct {
{ 0x1850, "Published Audio Capabilities" },
{ 0x1851, "Basic Audio Announcement" },
{ 0x1852, "Broadcast Audio Announcement" },
- /* 0x1853 to 0x27ff undefined */
+ { 0x1853, "Common Audio" },
+ { 0x1854, "Hearing Aid" },
+ { 0x1855, "TMAS" },
+ { 0x1856, "Public Broadcast Announcement" },
+ /* 0x1857 to 0x27ff undefined */
{ 0x2800, "Primary Service" },
{ 0x2801, "Secondary Service" },
{ 0x2802, "Include" },
@@ -681,6 +685,7 @@ static const struct {
{ 0x2b29, "Client Supported Features" },
{ 0x2b2A, "Database Hash" },
{ 0x2b3a, "Server Supported Features" },
+ { 0x2b51, "TMAP Role" },
{ 0x2b77, "Audio Input State" },
{ 0x2b78, "Gain Settings Attribute" },
{ 0x2b79, "Audio Input Type" },
@@ -751,6 +756,9 @@ static const struct {
{ 0x2bcc, "Source Audio Locations" },
{ 0x2bcd, "Available Audio Contexts" },
{ 0x2bce, "Supported Audio Contexts" },
+ { 0x2bda, "Hearing Aid Features" },
+ { 0x2bdb, "Hearing Aid Preset Control Point" },
+ { 0x2bdc, "Active Preset Index" },
/* vendor defined */
{ 0xfeff, "GN Netcom" },
{ 0xfefe, "GN ReSound A/S" },
--
2.39.0

2023-01-27 11:37:39

by Marcin Kraglak

Subject: [PATCH 2/2] AUTHORS: Update Marcin's email

---
AUTHORS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/AUTHORS b/AUTHORS
index 291d9b049..5d2d09688 100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -84,7 +84,7 @@ Petri Gynther <[email protected]>
Scott James Remnant <[email protected]>
Jakub Tyszkowski <[email protected]>
Grzegorz Kołodziejczyk <[email protected]>
-Marcin Krąglak <[email protected]>
+Marcin Krąglak <[email protected]>
Łukasz Rymanowski <[email protected]>
Jerzy Kasenberg <[email protected]>
Arman Uguray <[email protected]>
--
2.39.0

2023-01-27 13:29:51

by bluez.test.bot

Subject: RE: [1/2] shared/util: Add CAS, HAS, TMAS and PBAS UUIDs

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=716204

---Test result---

Test Summary:
CheckPatch PASS 0.86 seconds
GitLint PASS 0.47 seconds
BuildEll PASS 27.10 seconds
BluezMake PASS 744.08 seconds
MakeCheck PASS 11.42 seconds
MakeDistcheck PASS 146.04 seconds
CheckValgrind PASS 237.78 seconds
CheckSmatch PASS 316.33 seconds
bluezmakeextell PASS 95.14 seconds
IncrementalBuild PASS 1217.19 seconds
ScanBuild PASS 985.60 seconds



---
Regards,
Linux Bluetooth

2023-01-27 20:12:15

by Luiz Augusto von Dentz

Subject: Re: [PATCH 1/2] shared/util: Add CAS, HAS, TMAS and PBAS UUIDs

Hi Marcin,

On Fri, Jan 27, 2023 at 3:42 AM Marcin Kraglak
<[email protected]> wrote:
>
> Add UUIDs for: Common Audio service, Hearing Aid service,
> TMAS service and Public Broadcast Announcement service.
> ---
> src/shared/util.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/src/shared/util.c b/src/shared/util.c
> index 69abfba31..1ff9c56fc 100644
> --- a/src/shared/util.c
> +++ b/src/shared/util.c
> @@ -447,7 +447,11 @@ static const struct {
> { 0x1850, "Published Audio Capabilities" },
> { 0x1851, "Basic Audio Announcement" },
> { 0x1852, "Broadcast Audio Announcement" },
> - /* 0x1853 to 0x27ff undefined */
> + { 0x1853, "Common Audio" },
> + { 0x1854, "Hearing Aid" },
> + { 0x1855, "TMAS" },

We don't use the abbreviation here, so it should be Telephony and Media Audio

> + { 0x1856, "Public Broadcast Announcement" },
> + /* 0x1857 to 0x27ff undefined */
> { 0x2800, "Primary Service" },
> { 0x2801, "Secondary Service" },
> { 0x2802, "Include" },
> @@ -681,6 +685,7 @@ static const struct {
> { 0x2b29, "Client Supported Features" },
> { 0x2b2A, "Database Hash" },
> { 0x2b3a, "Server Supported Features" },
> + { 0x2b51, "TMAP Role" },

Ditto.

> { 0x2b77, "Audio Input State" },
> { 0x2b78, "Gain Settings Attribute" },
> { 0x2b79, "Audio Input Type" },
> @@ -751,6 +756,9 @@ static const struct {
> { 0x2bcc, "Source Audio Locations" },
> { 0x2bcd, "Available Audio Contexts" },
> { 0x2bce, "Supported Audio Contexts" },
> + { 0x2bda, "Hearing Aid Features" },
> + { 0x2bdb, "Hearing Aid Preset Control Point" },
> + { 0x2bdc, "Active Preset Index" },
> /* vendor defined */
> { 0xfeff, "GN Netcom" },
> { 0xfefe, "GN ReSound A/S" },
> --
> 2.39.0
>


--
Luiz Augusto von Dentz