Hello Maintainers,
This Patch is for following point:
- In current implementation Autoconnecttimeout max value is
16384[0x4000] msecs.
- Since some controllers need some more time to respond to
cmd - LE Extended Create Connection' hence increased this
Autoconnecttimeout max value to 20480[0x5000] msecs.
For ex:
- In some controllers, If we include LE-Coded PHY in the initiating
PHY List, BLE INIT scheduler selects the 1M and Coded PHY scanning
as an initiator in round robin manner, and due to this available
bandwidth gets distributed between 1M and Coded PHY, and this
results in longer time taken for connection establishment by
the controller.
- If ref device is advertising at 1.5 sec intervals, with create
connection timeout of 4 sec, the controller gets only 2 opportunities
for the connection. Without the inclusion of LE-coded PHY,
DUT takes ~3.8 sec for the connection establishment.Hence as described
in above point with the inclusion of LE-coded PHY it is difficult to
achieve 100% connection success with the device having
adv interval of 1.5 sec.
Hence increased Autoconnecttimeout max value to 20480[0x5000] msecs.
Thank you in advance for your review.
Thanks and regards,
Mahesh Vithal Talewad
Mahesh Talewad (1):
Increase autoconnect timeout max from 16.384s to 20.480s
src/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.34.1
- In current implementation Autoconnecttimeout max value is
16384[0x4000] msecs.
- Since some controllers need some more time to respond to cmd
'LE Extended Create Connection' hence increased this
Autoconnecttimeout max value to 20480[0x5000] msecs.
For ex:
- In some controllers, If we include LE-Coded PHY in the initiating
PHY List, BLE INIT scheduler selects the 1M and Coded PHY scanning
as an initiator in round robin manner, and due to this available
bandwidth gets distributed between 1M and Coded PHY, and this
results in longer time taken for connection establishment by
the controller.
- If ref device is advertising at 1.5 sec intervals, with create
connection timeout of 4 sec, the controller gets only 2 opportunities
for the connection. Without the inclusion of LE-coded PHY,
DUT takes ~3.8 sec for the connection establishment.Hence as described
in above point with the inclusion of LE-coded PHY it is difficult to
achieve 100% connection success with the device having
adv interval of 1.5 sec.
Hence increased Autoconnecttimeout max value to 20480[0x5000] msecs.
Signed-off-by: Mahesh Talewad <[email protected]>
---
src/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/main.c b/src/main.c
index f774670e4..081a388ad 100644
--- a/src/main.c
+++ b/src/main.c
@@ -657,7 +657,7 @@ static void parse_le_config(GKeyFile *config)
&btd_opts.defaults.le.autoconnect_timeout,
sizeof(btd_opts.defaults.le.autoconnect_timeout),
0x0001,
- 0x4000},
+ 0x5000}, /*max val: 20480 msec*/
{ "AdvMonAllowlistScanDuration",
&btd_opts.defaults.le.advmon_allowlist_scan_duration,
sizeof(btd_opts.defaults.le.advmon_allowlist_scan_duration),
--
2.34.1
Dear Mahesh,
Thank you for sending version 2.
Am 04.04.24 um 13:40 schrieb Mahesh Talewad:
> - In current implementation Autoconnecttimeout max value is
> 16384[0x4000] msecs.
> - Since some controllers need some more time to respond to cmd
> 'LE Extended Create Connection' hence increased this
> Autoconnecttimeout max value to 20480[0x5000] msecs.
>
> For ex:
> - In some controllers, If we include LE-Coded PHY in the initiating
> PHY List, BLE INIT scheduler selects the 1M and Coded PHY scanning
> as an initiator in round robin manner, and due to this available
> bandwidth gets distributed between 1M and Coded PHY, and this
> results in longer time taken for connection establishment by
> the controller.
> - If ref device is advertising at 1.5 sec intervals, with create
> connection timeout of 4 sec, the controller gets only 2 opportunities
> for the connection. Without the inclusion of LE-coded PHY,
> DUT takes ~3.8 sec for the connection establishment.Hence as described
> in above point with the inclusion of LE-coded PHY it is difficult to
> achieve 100% connection success with the device having
> adv interval of 1.5 sec.
>
> Hence increased Autoconnecttimeout max value to 20480[0x5000] msecs.
>
> Signed-off-by: Mahesh Talewad <[email protected]>
> ---
> src/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/main.c b/src/main.c
> index f774670e4..081a388ad 100644
> --- a/src/main.c
> +++ b/src/main.c
> @@ -657,7 +657,7 @@ static void parse_le_config(GKeyFile *config)
> &btd_opts.defaults.le.autoconnect_timeout,
> sizeof(btd_opts.defaults.le.autoconnect_timeout),
> 0x0001,
> - 0x4000},
> + 0x5000}, /*max val: 20480 msec*/
Please add spaces after /* and before */.
> { "AdvMonAllowlistScanDuration",
> &btd_opts.defaults.le.advmon_allowlist_scan_duration,
> sizeof(btd_opts.defaults.le.advmon_allowlist_scan_duration),
Kind regards,
Paul
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=841385
---Test result---
Test Summary:
CheckPatch PASS 0.32 seconds
GitLint PASS 0.23 seconds
BuildEll PASS 24.59 seconds
BluezMake PASS 1652.90 seconds
MakeCheck PASS 13.39 seconds
MakeDistcheck PASS 176.66 seconds
CheckValgrind PASS 245.64 seconds
CheckSmatch PASS 347.36 seconds
bluezmakeextell PASS 118.76 seconds
IncrementalBuild PASS 1418.35 seconds
ScanBuild PASS 990.80 seconds
---
Regards,
Linux Bluetooth
Hi Mahesh,
On Thu, Apr 4, 2024 at 7:41 AM Mahesh Talewad <[email protected]> wrote:
>
> - In current implementation Autoconnecttimeout max value is
> 16384[0x4000] msecs.
> - Since some controllers need some more time to respond to cmd
> 'LE Extended Create Connection' hence increased this
> Autoconnecttimeout max value to 20480[0x5000] msecs.
>
> For ex:
> - In some controllers, If we include LE-Coded PHY in the initiating
> PHY List, BLE INIT scheduler selects the 1M and Coded PHY scanning
> as an initiator in round robin manner, and due to this available
> bandwidth gets distributed between 1M and Coded PHY, and this
> results in longer time taken for connection establishment by
> the controller.
> - If ref device is advertising at 1.5 sec intervals, with create
> connection timeout of 4 sec, the controller gets only 2 opportunities
> for the connection. Without the inclusion of LE-coded PHY,
> DUT takes ~3.8 sec for the connection establishment.Hence as described
> in above point with the inclusion of LE-coded PHY it is difficult to
> achieve 100% connection success with the device having
> adv interval of 1.5 sec.
Have a look at:
https://patchwork.kernel.org/project/bluetooth/list/?series=841493
> Hence increased Autoconnecttimeout max value to 20480[0x5000] msecs.
>
> Signed-off-by: Mahesh Talewad <[email protected]>
> ---
> src/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/main.c b/src/main.c
> index f774670e4..081a388ad 100644
> --- a/src/main.c
> +++ b/src/main.c
> @@ -657,7 +657,7 @@ static void parse_le_config(GKeyFile *config)
> &btd_opts.defaults.le.autoconnect_timeout,
> sizeof(btd_opts.defaults.le.autoconnect_timeout),
> 0x0001,
> - 0x4000},
> + 0x5000}, /*max val: 20480 msec*/
> { "AdvMonAllowlistScanDuration",
> &btd_opts.defaults.le.advmon_allowlist_scan_duration,
> sizeof(btd_opts.defaults.le.advmon_allowlist_scan_duration),
> --
> 2.34.1
>
--
Luiz Augusto von Dentz