2020-06-16 04:29:47

by Miao-chen Chou

Subject: [BlueZ PATCH v1] lib: Correct the name of Add Advertisement Patterns Monitor Command opcode

lib/mgmt.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/mgmt.h b/lib/mgmt.h
index f44f2465d..bb31156ab 100644
--- a/lib/mgmt.h
+++ b/lib/mgmt.h
@@ -673,7 +673,7 @@ struct mgmt_adv_pattern {
uint8_t value[31];
} __packed;

-#define MGMT_OP_ADD_ADV_MONITOR 0x0052
+#define MGMT_OP_ADD_ADV_PATTERNS_MONITOR 0x0052
struct mgmt_cp_add_adv_monitor {
uint8_t pattern_count;
struct mgmt_adv_pattern patterns[0];
--
2.26.2

2020-06-16 04:37:29

by bluez.test.bot

Subject: RE: [BlueZ,v1] lib: Correct the name of Add Advertisement Patterns Monitor Command opcode

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
While we are preparing for reviewing the patches, we found the following
issue/warning.

Test Result:
checkgitlint Failed

Outputs:
1: T1 Title exceeds max length (74>72): "lib: Correct the name of Add Advertisement Patterns Monitor Command opcode"



---
Regards,
Linux Bluetooth

2020-06-16 06:16:22

by Von Dentz, Luiz

Subject: Re: [BlueZ PATCH v1] lib: Correct the name of Add Advertisement Patterns Monitor Command opcode

Hi Miao,

On Mon, Jun 15, 2020 at 9:28 PM Miao-chen Chou <[email protected]> wrote:
>
> lib/mgmt.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/mgmt.h b/lib/mgmt.h
> index f44f2465d..bb31156ab 100644
> --- a/lib/mgmt.h
> +++ b/lib/mgmt.h
> @@ -673,7 +673,7 @@ struct mgmt_adv_pattern {
> uint8_t value[31];
> } __packed;
>
> -#define MGMT_OP_ADD_ADV_MONITOR 0x0052
> +#define MGMT_OP_ADD_ADV_PATTERNS_MONITOR 0x0052
> struct mgmt_cp_add_adv_monitor {
> uint8_t pattern_count;
> struct mgmt_adv_pattern patterns[0];
> --
> 2.26.2


The name already contains PATTERNS:

https://git.kernel.org/pub/scm/bluetooth/bluez.git/tree/doc/mgmt-api.txt#n3499

2020-06-16 06:39:12

by Luiz Augusto von Dentz

Subject: Re: [BlueZ PATCH v1] lib: Correct the name of Add Advertisement Patterns Monitor Command opcode

On Mon, Jun 15, 2020 at 11:18 PM Von Dentz, Luiz
<[email protected]> wrote:
>
> Hi Miao,
>
> On Mon, Jun 15, 2020 at 9:28 PM Miao-chen Chou <[email protected]> wrote:
> >
> > lib/mgmt.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/mgmt.h b/lib/mgmt.h
> > index f44f2465d..bb31156ab 100644
> > --- a/lib/mgmt.h
> > +++ b/lib/mgmt.h
> > @@ -673,7 +673,7 @@ struct mgmt_adv_pattern {
> > uint8_t value[31];
> > } __packed;
> >
> > -#define MGMT_OP_ADD_ADV_MONITOR 0x0052
> > +#define MGMT_OP_ADD_ADV_PATTERNS_MONITOR 0x0052
> > struct mgmt_cp_add_adv_monitor {
> > uint8_t pattern_count;
> > struct mgmt_adv_pattern patterns[0];
> > --
> > 2.26.2
>
>
> The name already contains PATTERNS:
>
> https://git.kernel.org/pub/scm/bluetooth/bluez.git/tree/doc/mgmt-api.txt#n3499

Nevermind this is actually the command name rather than its definition
which is what you are fixing.

--
Luiz Augusto von Dentz

2020-06-16 17:28:30

by Luiz Augusto von Dentz

Subject: Re: [BlueZ PATCH v1] lib: Correct the name of Add Advertisement Patterns Monitor Command opcode

Hi Miao,

On Mon, Jun 15, 2020 at 9:32 PM Miao-chen Chou <[email protected]> wrote:
>
> lib/mgmt.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/mgmt.h b/lib/mgmt.h
> index f44f2465d..bb31156ab 100644
> --- a/lib/mgmt.h
> +++ b/lib/mgmt.h
> @@ -673,7 +673,7 @@ struct mgmt_adv_pattern {
> uint8_t value[31];
> } __packed;
>
> -#define MGMT_OP_ADD_ADV_MONITOR 0x0052
> +#define MGMT_OP_ADD_ADV_PATTERNS_MONITOR 0x0052
> struct mgmt_cp_add_adv_monitor {
> uint8_t pattern_count;
> struct mgmt_adv_pattern patterns[0];
> --
> 2.26.2
>

Applied, thanks.

--
Luiz Augusto von Dentz