2017-09-08 22:19:34

by Stotland, Inga

Subject: [PATCH BlueZ] mesh: Add characteristic property name check

If PropertyChanged signal is not emitted due to a change in
characteristic's "Value" property, the characteristic does
not need to be processed.
---
mesh/main.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/mesh/main.c b/mesh/main.c
index 42506a6..3a39d8f 100644
--- a/mesh/main.c
+++ b/mesh/main.c
@@ -1295,8 +1295,9 @@ static void property_changed(GDBusProxy *proxy, const char *name,
rl_printf("Characteristic property changed %s\n",
g_dbus_proxy_get_path(proxy));

- if ((connection.type == CONN_TYPE_PROVISION) ||
- connection.session_open)
+ if ((strcmp(name, "Value") == 0) &&
+ ((connection.type == CONN_TYPE_PROVISION) ||
+ connection.session_open))
process_mesh_characteristic(proxy);
}
}
--
2.9.5

2017-09-11 13:10:43

by Luiz Augusto von Dentz

Subject: Re: [PATCH BlueZ] mesh: Add characteristic property name check

Hi,

On Sat, Sep 9, 2017 at 12:07 PM, Laczen JMS <[email protected]> wrote:
> Hi Inga,
>
> This solves the issue.
>
> Kind regards,
>
> Jehudi
>
> 2017-09-09 0:19 GMT+02:00 Inga Stotland <[email protected]>:
>> If PropertyChanged signal is not emitted due to a change in
>> characteristic's "Value" property, the characteristic does
>> not need to be processed.
>> ---
>> mesh/main.c | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/mesh/main.c b/mesh/main.c
>> index 42506a6..3a39d8f 100644
>> --- a/mesh/main.c
>> +++ b/mesh/main.c
>> @@ -1295,8 +1295,9 @@ static void property_changed(GDBusProxy *proxy, const char *name,
>> rl_printf("Characteristic property changed %s\n",
>> g_dbus_proxy_get_path(proxy));
>>
>> - if ((connection.type == CONN_TYPE_PROVISION) ||
>> - connection.session_open)
>> + if ((strcmp(name, "Value") == 0) &&
>> + ((connection.type == CONN_TYPE_PROVISION) ||
>> + connection.session_open))
>> process_mesh_characteristic(proxy);
>> }
>> }
>> --
>> 2.9.5

Applied, thanks.

--
Luiz Augusto von Dentz

2017-09-09 09:07:08

by Laczen JMS

Subject: Re: [PATCH BlueZ] mesh: Add characteristic property name check

Hi Inga,

This solves the issue.

Kind regards,

Jehudi

2017-09-09 0:19 GMT+02:00 Inga Stotland <[email protected]>:
> If PropertyChanged signal is not emitted due to a change in
> characteristic's "Value" property, the characteristic does
> not need to be processed.
> ---
> mesh/main.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/mesh/main.c b/mesh/main.c
> index 42506a6..3a39d8f 100644
> --- a/mesh/main.c
> +++ b/mesh/main.c
> @@ -1295,8 +1295,9 @@ static void property_changed(GDBusProxy *proxy, const char *name,
> rl_printf("Characteristic property changed %s\n",
> g_dbus_proxy_get_path(proxy));
>
> - if ((connection.type == CONN_TYPE_PROVISION) ||
> - connection.session_open)
> + if ((strcmp(name, "Value") == 0) &&
> + ((connection.type == CONN_TYPE_PROVISION) ||
> + connection.session_open))
> process_mesh_characteristic(proxy);
> }
> }
> --
> 2.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html