2016-08-17 08:05:15

by Michał Narajowski

[permalink] [raw]
Subject: Re: [PATCH BlueZ v3] client: Add better support for managing devices of multiple controllers

Added mailing list in CC.

2016-08-17 9:55 GMT+02:00 Michał Narajowski <[email protected]>:

> Hi Marcel,
>
> of course I should have used libshared-glib.la. Will fix that. I needed
> it for new0() by the way.
>
> Regards,
> Michał Narajowski
>
> 2016-08-17 9:45 GMT+02:00 Marcel Holtmann <[email protected]>:
>
>> Hi Michal,
>>
>> > Previously devices list was cleared when selecting new default
>> > controller. Now devices list is preserverd allowing to list and suggest
>> > devices for default controller even after changing the default
>> > controller.
>> > ---
>> > Makefile.tools | 2 +-
>> > client/main.c | 262 ++++++++++++++++++++++++++++++
>> +++++++++++----------------
>> > 2 files changed, 189 insertions(+), 75 deletions(-)
>> >
>> > diff --git a/Makefile.tools b/Makefile.tools
>> > index 7706dc7..944c8e9 100644
>> > --- a/Makefile.tools
>> > +++ b/Makefile.tools
>> > @@ -10,7 +10,7 @@ client_bluetoothctl_SOURCES = client/main.c \
>> > client/gatt.h client/gatt.c \
>> > monitor/uuid.h monitor/uuid.c
>> > client_bluetoothctl_LDADD = gdbus/libgdbus-internal.la @GLIB_LIBS@
>> @DBUS_LIBS@ \
>> > - -lreadline
>> > + -lreadline src/libshared-mainloop.la
>>
>> I have no idea on how this is going to work. It would need to be
>> libshared-glib.la first of all, and second of all, what would you be
>> using in a D-Bus client that justifies using it.
>>
>> Regards
>>
>> Marcel
>>
>>
>