2022-06-08 14:14:38

by Dan Carpenter

[permalink] [raw]
Subject: [PATCH] Bluetooth: fix an error code in hci_register_dev()

Preserve the error code from hci_register_suspend_notifier(). Don't
return success.

Fixes: d6bb2a91f95b ("Bluetooth: Unregister suspend with userchannel")
Signed-off-by: Dan Carpenter <[email protected]>
---
net/bluetooth/hci_core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
index a4b4b3b927f2..dbddf891a4a9 100644
--- a/net/bluetooth/hci_core.c
+++ b/net/bluetooth/hci_core.c
@@ -2646,7 +2646,8 @@ int hci_register_dev(struct hci_dev *hdev)
hci_sock_dev_event(hdev, HCI_DEV_REG);
hci_dev_hold(hdev);

- if (hci_register_suspend_notifier(hdev))
+ error = hci_register_suspend_notifier(hdev);
+ if (error)
goto err_wqueue;

queue_work(hdev->req_workqueue, &hdev->power_on);
--
2.35.1


2022-06-08 14:32:41

by bluez.test.bot

[permalink] [raw]
Subject: RE: Bluetooth: fix an error code in hci_register_dev()

This is an automated email and please do not reply to this email.

Dear Submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
While preparing the CI tests, the patches you submitted couldn't be applied to the current HEAD of the repository.

----- Output -----
error: patch failed: net/bluetooth/hci_core.c:2646
error: net/bluetooth/hci_core.c: patch does not apply
hint: Use 'git am --show-current-patch' to see the failed patch


Please resolve the issue and submit the patches again.


---
Regards,
Linux Bluetooth

2022-06-08 17:20:13

by patchwork-bot+bluetooth

[permalink] [raw]
Subject: Re: [PATCH] Bluetooth: fix an error code in hci_register_dev()

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Marcel Holtmann <[email protected]>:

On Wed, 8 Jun 2022 16:46:13 +0300 you wrote:
> Preserve the error code from hci_register_suspend_notifier(). Don't
> return success.
>
> Fixes: d6bb2a91f95b ("Bluetooth: Unregister suspend with userchannel")
> Signed-off-by: Dan Carpenter <[email protected]>
> ---
> net/bluetooth/hci_core.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)

Here is the summary with links:
- Bluetooth: fix an error code in hci_register_dev()
https://git.kernel.org/bluetooth/bluetooth-next/c/ad564394b3db

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html