2022-07-20 11:32:40

by Dan Carpenter

[permalink] [raw]
Subject: [PATCH] Bluetooth: clean up error pointer checking

The bt_skb_sendmsg() function can't return NULL so there is no need to
check for that. Several of these checks were removed previously but
this one was missed.

Signed-off-by: Dan Carpenter <[email protected]>
---
include/net/bluetooth/bluetooth.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/net/bluetooth/bluetooth.h b/include/net/bluetooth/bluetooth.h
index 6b48d9e2aab9..a8b52175af05 100644
--- a/include/net/bluetooth/bluetooth.h
+++ b/include/net/bluetooth/bluetooth.h
@@ -494,7 +494,7 @@ static inline struct sk_buff *bt_skb_sendmmsg(struct sock *sk,
struct sk_buff *skb, **frag;

skb = bt_skb_sendmsg(sk, msg, len, mtu, headroom, tailroom);
- if (IS_ERR_OR_NULL(skb))
+ if (IS_ERR(skb))
return skb;

len -= skb->len;
--
2.35.1


2022-07-20 12:09:49

by bluez.test.bot

[permalink] [raw]
Subject: RE: Bluetooth: clean up error pointer checking

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=661424

---Test result---

Test Summary:
CheckPatch PASS 1.37 seconds
GitLint PASS 0.56 seconds
SubjectPrefix PASS 0.30 seconds
BuildKernel PASS 45.84 seconds
BuildKernel32 PASS 40.97 seconds
Incremental Build with patchesPASS 69.34 seconds
TestRunner: Setup PASS 676.66 seconds
TestRunner: l2cap-tester PASS 19.85 seconds
TestRunner: bnep-tester PASS 7.13 seconds
TestRunner: mgmt-tester PASS 118.69 seconds
TestRunner: rfcomm-tester PASS 11.35 seconds
TestRunner: sco-tester PASS 11.69 seconds
TestRunner: smp-tester PASS 11.14 seconds
TestRunner: userchan-tester PASS 7.73 seconds



---
Regards,
Linux Bluetooth

2022-07-20 16:25:02

by patchwork-bot+bluetooth

[permalink] [raw]
Subject: Re: [PATCH] Bluetooth: clean up error pointer checking

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <[email protected]>:

On Wed, 20 Jul 2022 14:23:49 +0300 you wrote:
> The bt_skb_sendmsg() function can't return NULL so there is no need to
> check for that. Several of these checks were removed previously but
> this one was missed.
>
> Signed-off-by: Dan Carpenter <[email protected]>
> ---
> include/net/bluetooth/bluetooth.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
- Bluetooth: clean up error pointer checking
https://git.kernel.org/bluetooth/bluetooth-next/c/3c7ec89ab45e

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html