2024-05-05 10:38:42

by Julia Lawall

[permalink] [raw]
Subject: Re: Bluetooth: qca: Use common error handling code in two functions



On Sun, 5 May 2024, Markus Elfring wrote:

> >> Add a jump target so that the setting of an error code can be better reused
> >> at the end of these function implementations.
> …
> > This reduces readability, and backwards jumps are rarely desirable.
>
> Would you like to support any other design approaches better for
> the reduction of questionable source code duplication?

Maybe cleanup.h can be used to get rid of the kfree_skb. I have no idea.

It would be nice to keep the patch in the message so that one could see
what is being discussed from the message itself.

julia