2020-05-07 21:06:39

by Luiz Augusto von Dentz

Subject: [PATCH BlueZ] avrcp: Handle not implemented response to AVRCP_LIST_PLAYER_ATTRIBUTES

From: Luiz Augusto von Dentz <[email protected]>

If remote device respond with ctype set to not implement don't continue
parsing the packet.
---
profiles/audio/avrcp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/profiles/audio/avrcp.c b/profiles/audio/avrcp.c
index 6b3f685d2..773ccdb60 100644
--- a/profiles/audio/avrcp.c
+++ b/profiles/audio/avrcp.c
@@ -2223,7 +2223,7 @@ static gboolean avrcp_list_player_attributes_rsp(struct avctp *conn,
uint8_t len, count = 0;
int i;

- if (code == AVC_CTYPE_REJECTED)
+ if (code == AVC_CTYPE_REJECTED || code == AVC_CTYPE_NOT_IMPLEMENTED)
return FALSE;

len = pdu->params[0];
--
2.25.3

2020-05-07 23:52:49

by Andrey Semashev

Subject: Re: [PATCH BlueZ] avrcp: Handle not implemented response to AVRCP_LIST_PLAYER_ATTRIBUTES

I think this patch is correct, but unfortunately, it doesn't solve the
problem with the Sennheiser MTW2 reboot.

On 2020-05-08 00:03, Luiz Augusto von Dentz wrote:
> From: Luiz Augusto von Dentz <[email protected]>
>
> If remote device respond with ctype set to not implement don't continue
> parsing the packet.
> ---
> profiles/audio/avrcp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/profiles/audio/avrcp.c b/profiles/audio/avrcp.c
> index 6b3f685d2..773ccdb60 100644
> --- a/profiles/audio/avrcp.c
> +++ b/profiles/audio/avrcp.c
> @@ -2223,7 +2223,7 @@ static gboolean avrcp_list_player_attributes_rsp(struct avctp *conn,
> uint8_t len, count = 0;
> int i;
>
> - if (code == AVC_CTYPE_REJECTED)
> + if (code == AVC_CTYPE_REJECTED || code == AVC_CTYPE_NOT_IMPLEMENTED)
> return FALSE;
>
> len = pdu->params[0];
>